[General] I'm begining using JASS but...

[HerlySQR]

I tried this thing of creating a functions, but always I get Syntax errors, and the tutorials of this forum don't say why?

What am I doing bad?

(Pls don't ask me why am I using the old Jass New Gen)

 

[Uncle]

gg_trg_Detonador_sin_nombre_002 is already a trigger. You don't need to create it again.

You can use a Variable in that situation like:

NewTrigger = CreateTrigger()

Then you can reference NewTrigger.

 

[HerlySQR]

gg_trg_Detonador_sin_nombre_002 is already a trigger. You don't need to create it again.

You can use a Variable in that situation like:

NewTrigger = CreateTrigger()

Then you can reference NewTrigger.

Can you show me how will look the entire script?

 

[Uncle]

Can you show me how will look the entire script?

Just delete set gg_trg_Detonador_sin_nombre_002 = CreateTrigger( ) and you should be good to go.

 

[HerlySQR]

Just delete set gg_trg_Detonador_sin_nombre_002 = CreateTrigger( ) and you should be good to go.

Ok I will see

 

[Zwiebelchen]

Mixing GUI globals with Jass is not recommended as the initialization of GUI globals is very weird.

Unless you still want to use GUI triggers here and there, I recommend using vJass globals:

Just put a block like this on the top of your script to initialize a Jass global variable:

globals
    trigger MyTrig = CreateTrigger()
endglobals

Then use MyTrig instead of the GUI global there.


However, in your case, you can also use a local variable right in your init function:
local trigger MyTrig = CreateTrigger()

You only need global variables of you want to use them outside of your function.

 

[BloodSoul]

I just wanna explain that the error related to "gg_trg_Detonador_sin_nomber_002" being undeclared probably happened because you used the "Syntax Check" button instead of saving the map. That button doesn't check the entire map script, but only the scope being visible at run time. Since that variable isn't being declared there, it threw such error. I recommend that you save your map if you want to check for any real errors.

 

[Zwiebelchen]

I just wanna explain that the error related to "gg_trg_Detonador_sin_nomber_002" being undeclared probably happened because you used the "Syntax Check" button instead of saving the map. That button doesn't check the entire map script, but only the scope being visible at run time. Since that variable isn't being declared there, it threw such error. I recommend that you save your map if you want to check for any real errors.

Jasshelper does often throw errors on GUI initialized globals regardless.
Hence why the TO should learn how to declare globals in Jass next.

 

[BloodSoul]

Jasshelper does often throw errors on GUI initialized globals regardless.

That's strange; I've never had any trouble with it.

Hence why the TO should learn how to declare globals in Jass next.

Well, one must know how to declare globals in JASS if they want to switch to it, anyway.

 

[HerlySQR]

Pls, Can you show me how must look the entire script?

 

[BloodSoul]

Let's take another approach. Despite the error being shown, your piece of code primarily won't run because there's no event associated with the trigger, and the trigger itself doesn't reference your "HelloWorld" function even if it had a proper event.

Change your script to this:

function HelloWorld takes nothing returns nothing
    call BJDebugMsg("Hello World!")
endfunction

//===========================================================================
function InitTrig_Detonador_sin_nombre_002 takes nothing returns nothing
    local trigger triggerVar = CreateTrigger()
    call TriggerAddAction(triggerVar, function HelloWorld)
    call TriggerRegisterTimerEvent(triggerVar, 1.00, false)
endfunction

//===========================================================================
// The function name below is generated by the editor when converting from GUI to JASS. It should respect the "trigger name".
// This function is called by another "hidden" function (Main -> InitCustomTriggers)
function InitTrig_Detonador_sin_nombre_002 takes nothing returns nothing
    local trigger triggerVar = CreateTrigger() // Local variable, type: Trigger, Name: triggerVar = Initializes a new trigger object.
    call TriggerAddAction(triggerVar, function HelloWorld) // TriggerAddAction appends a function ("HelloWorld" in this case) to a trigger, and such function is fired when using events or running this trigger.
    call TriggerRegisterTimerEvent(triggerVar, 1.00, false) // This registers a timer event which expires in 1 second and doesn't repeat (Just like "Time Elapsed" GUI event)
endfunction

Here's how the trigger works so far:
1 - Map loads, and InitTrig_Detonador_sin_nombre_002 function is called by the game automatically.
2 - A new trigger object is created and assigned to a local variable
3 - Adds an action and event to the trigger object, referencing the local variable.
4 - After timer event expires, the "action" (function) added to the trigger is called. (Calls HelloWorld function)
5 - Prints "Hello World" to all possible clients.

 

[HerlySQR]

Let's take another approach. Despite the error being shown, your piece of code primarily won't run because there's no event associated with the trigger, and the trigger itself doesn't reference your "HelloWorld" function even if it had a proper event.

Change your script to this:

function HelloWorld takes nothing returns nothing
    call BJDebugMsg("Hello World!")
endfunction

//===========================================================================
function InitTrig_Detonador_sin_nombre_002 takes nothing returns nothing
    local trigger triggerVar = CreateTrigger()
    call TriggerAddAction(triggerVar, function HelloWorld)
    call TriggerRegisterTimerEvent(triggerVar, 1.00, false)
endfunction

//===========================================================================
// The function name below is generated by the editor when converting from GUI to JASS. It should respect the "trigger name".
// This function is called by another "hidden" function (Main -> InitCustomTriggers)
function InitTrig_Detonador_sin_nombre_002 takes nothing returns nothing
    local trigger triggerVar = CreateTrigger() // Local variable, type: Trigger, Name: triggerVar = Initializes a new trigger object.
    call TriggerAddAction(triggerVar, function HelloWorld) // TriggerAddAction appends a function ("HelloWorld" in this case) to a trigger, and such function is fired when using events or running this trigger.
    call TriggerRegisterTimerEvent(triggerVar, 1.00, false) // This registers a timer event which expires in 1 second and doesn't repeat (Just like "Time Elapsed" GUI event)
endfunction

Here's how the trigger works so far:
1 - Map loads, and InitTrig_Detonador_sin_nombre_002 function is called by the game automatically.
2 - A new trigger object is created and assigned to a local variable
3 - Adds an action and event to the trigger object, referencing the local variable.
4 - After timer event expires, the "action" (function) added to the trigger is called. (Calls HelloWorld function)
5 - Prints "Hello World" to all possible clients.

There is no longer Syntax error, but the map doesn't load.

 

[BloodSoul]

Not sure what's going on with your editor. It works as intended for me, even with 1.27b JNGP (either Vexorian's JassHelper turned on or off)

 

[HerlySQR]

Not sure what's going on with your editor. It works as intended for me, even with 1.27b JNGP (either Vexorian's JassHelper turned on or off)

View attachment 361188

Ok, I don't get why, but it worked to me too.

 

[HerlySQR]

I even deleted this

call TriggerRegisterTimerEvent(triggerVar, 1.00, false)

And added this

• Events
  • Player - Player 1 Red press left arrow
• Conditions
• Actions
  • Custom script: call HelloWorld()

And it worked.

 

[HerlySQR]

I even added more functions and they work, seriously why?

 

[Zwiebelchen]

Because you simply call your hello world function.

The InitTrig stuff is only there to attach an event and establish your trigger. If you directly call your function from another trigger, you don't need it at all.

You need the InitTrig if you want to build event triggers in JASS. But calling Jass functions from GUI also works. Its just a matter of how much you want to commit coding in Jass versus applying a hybrid of GUI and Jass.

 

[HerlySQR]

Because you simply call your hello world function.

The InitTrig stuff is only there to attach an event and establish your trigger. If you directly call your function from another trigger, you don't need it at all.

You need the InitTrig if you want to build event triggers in JASS. But calling Jass functions from GUI also works. Its just a matter of how much you want to commit coding in Jass versus applying a hybrid of GUI and Jass.

I mean, why it work now when I downloaded his test map and not when I did it myself if I did the same thing?

 

[HerlySQR]

Ok I finally got it, thanks for your help.