[Trigger] I removed leaks, but in wrong way?

[Super-Sheep]

• Boost loop
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Set BoostGroup = (Units in (Playable map area) matching (((Matching unit) has buff Boost ) Equal to True))
    • Unit Group - Pick every unit in BoostGroup and do (Actions)
      • Loop - Actions
        • Set Point[(Player number of (Owner of (Picked unit)))] = (Position of (Picked unit))
        • Set Point_2[(Player number of (Owner of (Picked unit)))] = (Point[(Player number of (Picked player))] offset by 35.00 towards (Facing of Player_Car[(Player number of (Owner of (Picked unit)))]) degrees)
        • Unit - Move Player_Car[(Player number of (Owner of (Picked unit)))] instantly to Point_2[(Player number of (Owner of (Picked unit)))]
    • Custom script: call RemoveLocation(udg_Point[1])
    • Custom script: call RemoveLocation(udg_Point[2])
    • Custom script: call RemoveLocation(udg_Point[3])
    • Custom script: call RemoveLocation(udg_Point[4])
    • Custom script: call RemoveLocation(udg_Point[5])
    • Custom script: call RemoveLocation(udg_Point[6])
    • Custom script: call RemoveLocation(udg_Point[7])
    • Custom script: call RemoveLocation(udg_Point[8])
    • Custom script: call RemoveLocation(udg_Point[9])
    • Custom script: call RemoveLocation(udg_Point[10])
    • Custom script: call RemoveLocation(udg_Point[11])
    • Custom script: call RemoveLocation(udg_Point[12])
    • Custom script: call RemoveLocation(udg_Point_2[1])
    • Custom script: call RemoveLocation(udg_Point_2[2])
    • Custom script: call RemoveLocation(udg_Point_2[3])
    • Custom script: call RemoveLocation(udg_Point_2[4])
    • Custom script: call RemoveLocation(udg_Point_2[5])
    • Custom script: call RemoveLocation(udg_Point_2[6])
    • Custom script: call RemoveLocation(udg_Point_2[7])
    • Custom script: call RemoveLocation(udg_Point_2[8])
    • Custom script: call RemoveLocation(udg_Point_2[9])
    • Custom script: call RemoveLocation(udg_Point_2[10])
    • Custom script: call RemoveLocation(udg_Point_2[11])
    • Custom script: call RemoveLocation(udg_Point_2[12])

Duh?

 

[Paladon]

• Boost loop
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Set BoostGroup = (Units in (Playable map area) matching (((Matching unit) has buff Boost ) Equal to True))
    • Unit Group - Pick every unit in BoostGroup and do (Actions)
      • Loop - Actions
        • Set Point[(Player number of (Owner of (Picked unit)))] = (Position of (Picked unit))
        • Set Point_2[(Player number of (Owner of (Picked unit)))] = (Point[(Player number of (Picked player))] offset by 35.00 towards (Facing of Player_Car[(Player number of (Owner of (Picked unit)))]) degrees)
        • Unit - Move Player_Car[(Player number of (Owner of (Picked unit)))] instantly to Point_2[(Player number of (Owner of (Picked unit)))]
        • Custom script: call RemoveLocation (udg_Point[GetConvertedPlayerId(GetOwningPlayer(GetEnumUnit()))])
        • Custom script: call RemoveLocation (udg_Point_2[GetConvertedPlayerId(GetOwningPlayer(GetEnumUnit()))])
    • Custom script: call DestroyGroup (udg_BoostGroup)

Duh! Jass knowledge ftw

 

[SanKakU]

yeah i don't think you're supposed to use arrays for temporary points...

 

[Eleandor]

Duh?

Well, it more or less looks correct (although buggy: why are you using "pick every unit" rather than "pick every player"?), but

Duh! Jass knowledge ftw

is obviously "cleaner".

yeah i don't think you're supposed to use arrays for temporary points...

Sure, why not? But there's no need for any in this case anyway.

The best solution however does not use arrays anyway.

• Boost loop
• Events
  • Time - Every 0.05 seconds of game time
• Conditions
• Actions
  • Set BoostGroup = (Units in (Playable map area) matching (((Matching unit) has buff Boost ) Equal to True))
  • Unit Group - Pick every unit in BoostGroup and do (Actions)
    • Loop - Actions
      • Set Point = (Position of (Picked unit))
      • Set Point_2 = (Point offset by 35.00 towards (Facing of Picked unit) degrees)
      • Unit - Move Picked unit instantly to Point_2
      • Custom script: call RemoveLocation (udg_Point)
      • Custom script: call RemoveLocation (udg_Point_2)
  • Custom script: call DestroyGroup (udg_BoostGroup)

 

[Super-Sheep]

Is you suer that it works with all 12 players without array? I have done this kind of triggers before, but somehow I just got so confused. ><

 

[GhostWolf]

This trigger has nothing to do with players. You picked a group, you interact with that group. Where do you see the word "player" mentioned?

 

[Super-Sheep]

DUnno, but it may pick up to 12 players and all of them need to have different directions?

 

[GhostWolf]

No, it can't pick up to 12 players because YOU ARE NOT PICKING PLAYERS. You are picking units -.-

 

[Super-Sheep]

yyyy but 12 different UNIT directions?

 

[Eleandor]

• Set Point_2 = (Point offset by 35.00 towards (Facing of Picked unit) degrees)

Each unit has a different facing, right? So if you pick each unit in the group, "Picked unit" will have a different facing for each unit picked...

 

[Super-Sheep]

[Solved]

It runs trigger for 12 times cuz is loop!

 

[GhostWolf]

No, it doesn't, for god's sake.

Your unit group contains units as follows:

unit1,unit2,unit3,unit4.

You loop through them and do all your actions:

Do stuff for unit1
Do stuff for unit2
Do stuff for unit3
Do stuff for unit4

And that's it. It has NOTHING TO DO WITH FREAKING PLAYERS.

 

[Super-Sheep]

It runs trigger for number of units with boost buff, cuz is loop! One run per unit picked.

Now right???!?!?

 

[Palaslayer]

• Boost loop
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Set BoostGroup = (Units in (Playable map area) matching (((Matching unit) has buff Boost ) Equal to True))
    • Unit Group - Pick every unit in BoostGroup and do (Actions)
      • Loop - Actions
        • Set Point[(Player number of (Owner of (Picked unit)))] = (Position of (Picked unit))
        • Set Point_2[(Player number of (Owner of (Picked unit)))] = (Point[(Player number of (Picked player))] offset by 35.00 towards (Facing of Player_Car[(Player number of (Owner of (Picked unit)))]) degrees)
        • Unit - Move Player_Car[(Player number of (Owner of (Picked unit)))] instantly to Point_2[(Player number of (Owner of (Picked unit)))]
        • Custom script: call RemoveLocation (udg_Point[GetConvertedPlayerId(GetOwningPlayer(GetEnumUnit()))])
        • Custom script: call RemoveLocation (udg_Point_2[GetConvertedPlayerId(GetOwningPlayer(GetEnumUnit()))])
    • Custom script: call DestroyGroup (udg_BoostGroup)

Duh! Jass knowledge ftw

yep ur right, JASS ftw!! are u gonna move to JASS? u said so in one of ur spellmaps

gl

 

[SanKakU]

heh, i learned some stuff...i think it may help me with my ai triggering. thanks guys (about the unit groups)

 

[Ramsey]

How do you guys attach those pictures of triggers and how u attach maps?
lol im serious

 

[Cokemonkey11]

what looks like a picture of a trigger isn't, it's just a colorized code.

use the [ trigger ] and [ trigger /] (without the extra spaces) tags and paste your trigger as text into it - voila it looks just like in the editor when you submit the post.

right click your trigger and click "copy as text" to get the formatting and spacing correct.

 

[GhostWolf]

[trigger]text[/trigger]

 

[Ramsey]

ok cool now back to the main topic
(sorry for changing the subject)