How to fix timer leak

[emil23]

• Init UI
  • Events
  • Time - Elapsed game time is 1.00 seconds
  • Conditions
  • Actions
  • Player Group - Pick every player in (All players) and do (Actions)
  • Loop - Actions
  • Camera - Set (Picked player)'s camera Height Offset to 1000.00 over 1.00 seconds
  • Trigger - Turn off Germany Extra Income <gen>
  • Trigger - Turn off Lend Lease Income <gen>
  • Trigger - Turn off Units Soviet Buildup <gen>
  • Trigger - Turn off Cold War Fighting <gen>
  • Trigger - Turn off Cold War Forced Enemy <gen>
  • Trigger - Turn off Western <gen>
  • Trigger - Turn off Greece Extra Income <gen>
  • Countdown Timer - Create a timer window for Turn with title Iconome in :
  • Set Turn_TimerWindow = (Last created timer window)
  • Countdown Timer - Start Turn as a Repeating timer that will expire in 60.00 seconds

Leak tester says that theres leak
type of leak Type: timer
CreateTimer [Blizzard.j:605] please help! i dont know how to remove that leak.

 

[Abovegame]

• Set PlayerGroup = (Your Player Group)
• Player Group - Pick every player in PlayerGroup and do (Do nothing)
• Custom script: call DestroyForce(udg_PlayerGroup)

Maybe there are more don't know.

 

[GIMLI_2]

call DestroyTimer(GetExpiredTimer())

 

[emil23]

• Set PlayerGroup = (Your Player Group)
• Player Group - Pick every player in PlayerGroup and do (Do nothing)
• Custom script: call DestroyForce(udg_PlayerGroup)

Maybe there are more don't know.

What IF i have about 6 players group in my map what should i do? Or i should do pick every player in all group

 

[GIMLI_2]

If you have a player group that is used frequently, you do not need to remove it. Otherwise stick to Abovegame's example.

 

[Dr Super Good]

To be honest I cannot see any timer leak at all. I ran through the JASS pretty much line by line and none of it creates any timers and the timer which is used is created at map initialization as part of the global initialization and must never be destroyed. I am guessing the leak checker tool has a bug in it or something?

 

[Chaosy]

Well you do create a timer that never's destroyed, but in your case it might not need to be cause you want to to run the whole game.

 

[Dr Super Good]

Well you do create a timer that never's destroyed

The timer is created as part of the variable and is always reachable.

 

[Chaosy]

It's a bit of a long shot but it could leak in other triggers if the variable is overwritten.

I would not say the shown trigger leaked either, but if I were to guess why the tool said it was leaking..

 

[Flux]

@emil23
You don't leak a Player Group because 'All Players' does not leak. Your timer is created at map initialization (not dynamically) so only 1 timer is created. Since you're dealing with GUI, it's best not to destroy this timer so you can re-use it. Note that tere is no GUI action that allows you to create a timer dynamically (except Custom scripts).
However, you're creatimg a timer window every second

I would not say the shown trigger leaked either, but if I were to guess why the tool said it was leaking..

If the leak checker thinks his trigger leaks a timer, then it is a bad leak checker.

 

[Dr Super Good]

However, you're creating a timer window every second.

No he creates only one ever...

• Time - Elapsed game time is 1.00 seconds

This trigger should only ever fire once. I can also assure you that it does not create the timer dialog in the loop (that part did not copy well).

If the leak checker thinks his trigger leaks a timer, then it is a bad leak checker.

Probably is. It also failed to pick up many other leaks.

 

[Flux]

My bad, I misread the event. That means if ever there was a leak here, it won't be critical since it's a one time trigger.

 

[darwin]

This might be a bit controversial...but if a trigger fires only once without any repeated code... why would anyone care if it leaks a bit? All of Blizzard's maps leaked and the campaign runs just fine.

I know experts like to be precise and thorough, but this poor map maker has been wasting a lot of time hunting down a leak that probably doesn't exist, and even if it did would be completely unnoticeable to anyone playing his map.

 

[SAUS]

Is it even a leak?

• Countdown Timer - Start Turn as a Repeating timer that will expire in 60.00 seconds

I think this will create a timer object for the variable Turn. Then it will use that internally. In this sense, it HAS to "leak" in order to keep the periodic (Repeating) timer. I can't be certain since I'm not 100% sure what this function translates to in JASS, but that is my guess.

 

[Dr Super Good]

I think this will create a timer object for the variable Turn. Then it will use that internally. In this sense, it HAS to "leak" in order to keep the periodic (Repeating) timer. I can't be certain since I'm not 100% sure what this function translates to in JASS, but that is my guess.

It translates into a call of the following.

function StartTimerBJ takes timer t,boolean periodic,real timeout returns timer
    set bj_lastStartedTimer = t
    call TimerStart(t, timeout, periodic, null)
    return bj_lastStartedTimer
endfunction

So as you can see, no leak.