[GUI] Wander v0.4

[Moderator]

23:53, 14th Nov 2015
BPower: Just a small review. Check my last post in the thread.
Remove the debug keyword.

16:09, 6th Oct 2015
Bribe: Review

 

[Chaosy]

Oh look, another wander system. And in GUIJASS <3

I will keep my eye on this as I need to get my own wander system approved sooner or later so I might as well steal an idea or two.

 

[Reventhous]

For me its kinda great to have two version of a system.
Both version has its own features.

EDIT : Can someone tell me how to make the countdown work precisely. I mean, if the Wander_Delay is 0.50 scale and i set Wander_Periodic to any number that not 0.50 scale, how to calculate the countdown to make Wander_DelayCount == Wander_Delay and not Wander_DelayCount >= Wander_Delay
or should i make the timer periodic unconfigurable.

 

[Flux]

set i = 2
loop
  set Wander_Periodic = Wander_Delay/i
  exitwhen  Wander_Periodic <= Wander_Max_Periodic_Time
  set i = i + 1
endloop

Wander_Max_Periodic_Time is configurable.
You get what I mean?

 

[Reventhous]

i forgot to tell that i want Wander_Periodic to be constant.
any solution?

EDIT : wow, how long i'm gonna wait to see my work reviewed.

 

[Bribe]

Improvements:
- Only start the timers if they weren't already started
- Instead of a hashtable, use arrays and the custom value of the unit as the array index.
Arrays names:

WanderLocX/Y
WanderMin/MaxDist
WanderDelay
WanderDelayCount
etc.

Maybe an option to make the NPCs attack-move instead of just move.

Instead of doing a perfect "Equal to" when you check if the wander duration has expired, do an equal to or greater than. This way you also don't have to do weird stuff like converting real to integer.

Move this out of the if-block to shorten the code: Unit - Order Wander_Unit to Move To Wander_Point[2]

This looks conceptually good. The other systems seem to want to add 6,000 features in addition to wandering. I like just strictly wandering as a standalone system.

 

[Reventhous]

Updated..
improved just as you want
I'll make it standalone in the next update

 

[Chaosy]

For some reason the code feels super long..

Anyway, why create a point and then get the coordinates of that point? Use either lol

 

[Wrda]

Anyway, why create a point and then get the coordinates of that point? Use either lol

Agreed. this is pointless:

• Custom script: set udg_WanderPoint[1] = Location(udg_WanderLocX[udg_WanderIndex], udg_WanderLocY[udg_WanderIndex])

Just use locations.

• Custom script: call MoveRectTo(udg_WanderPathRect, x[1], y[1])

What is this? I never see you using it anywhere else on the triggers, only once...


Correct me If I'm wrong, but you will leak if the udg_WanderPathCheck is false

Hidden

• Custom script: loop
• Set WanderPoint[2] = (WanderPoint[1] offset by (Random real number between WanderMinDist[WanderIndex] and WanderMaxDist[WanderIndex]) towards (Random angle) degrees)
• Custom script: set x[1] = GetLocationX(udg_WanderPoint[2])
• Custom script: set y[1] = GetLocationY(udg_WanderPoint[2])
• Custom script: call MoveRectTo(udg_WanderPathRect, x[1], y[1])
• Custom script: call SetItemPosition(udg_WanderPathChecker, x[1], y[1])
• Custom script: set x[2] = GetItemX(udg_WanderPathChecker)
• Custom script: set y[2] = GetItemY(udg_WanderPathChecker)
• Item - Hide WanderPathChecker
• Custom script: set udg_WanderPathCheck = ((x[2]-x[1])*(x[2]-x[1]) + (y[2]-y[1])*(y[2]-y[1]) <= 100) and (not IsTerrainPathable(x[1], y[1], PATHING_TYPE_WALKABILITY))
• Custom script: exitwhen udg_WanderPathCheck == true
• Custom script: endloop

 

[Reventhous]

For some reason the code feels super long..

Anyway, why create a point and then get the coordinates of that point? Use either lol

yes it is long because of its features. if you can see in the description, this system will make unit wander if the unit is out of combat and if the terrain is pathable. btw i will try to make it short later and thanks for telling, i forgot to change that

Agreed. this is pointless:

• Custom script: set udg_WanderPoint[1] = Location(udg_WanderLocX[udg_WanderIndex], udg_WanderLocY[udg_WanderIndex])

Just use locations.

• Custom script: call MoveRectTo(udg_WanderPathRect, x[1], y[1])

What is this? I never see you using it anywhere else on the triggers, only once...


Correct me If I'm wrong, but you will leak if the udg_WanderPathCheck is false

Hidden

• Custom script: loop
• Set WanderPoint[2] = (WanderPoint[1] offset by (Random real number between WanderMinDist[WanderIndex] and WanderMaxDist[WanderIndex]) towards (Random angle) degrees)
• Custom script: set x[1] = GetLocationX(udg_WanderPoint[2])
• Custom script: set y[1] = GetLocationY(udg_WanderPoint[2])
• Custom script: call MoveRectTo(udg_WanderPathRect, x[1], y[1])
• Custom script: call SetItemPosition(udg_WanderPathChecker, x[1], y[1])
• Custom script: set x[2] = GetItemX(udg_WanderPathChecker)
• Custom script: set y[2] = GetItemY(udg_WanderPathChecker)
• Item - Hide WanderPathChecker
• Custom script: set udg_WanderPathCheck = ((x[2]-x[1])*(x[2]-x[1]) + (y[2]-y[1])*(y[2]-y[1]) <= 100) and (not IsTerrainPathable(x[1], y[1], PATHING_TYPE_WALKABILITY))
• Custom script: exitwhen udg_WanderPathCheck == true
• Custom script: endloop

Oh, my mistake. i just copy the copy from my rpg map, i'll remove that and thanks again, thats leak. i'll try to remake some of the code.

 

[BPower]

The debug keyword can only be compiled with JPNG. In public GUI only code it shouldn't be used.

Here and there you check if a specific goup is empty. Even if that is true you perform
a ForGroup operation. Move that to the else part of the is group empty condition.