Warden Leap [GUI] v0.4

[Moderator]

10:43, 14th Oct 2012
Magtheridon96: Approved.
This is a nice spell with decent effects, good configuration and an efficient script.
Well done.

 

[Almia]

Increase the loop by 0.03,this spell seems fine to me.
Also i forgot,put a configuration trigger
your arc sucks too.
Use this:
(((4xHeightBase)/MaxDistance)x((MaxDistance-Travelled)x(Travelled/Distance)))
In this case,the arc will be smooth

 

[sonofjay]

Simple but really creative spell.(I really hate those leap spell that just literally make your hero leap.) Good job.

 

[Magtheridon96]

I have a cool suggestion for you to reduce the number of triggers.

When you change the period from 0.02 to 0.03, you can move the code inside your Leap Loop Anim trigger to the Leap Loop trigger, but you would have an integer called counter for the spell that would be incremented (increased by 1) inside the loop, and when (Counter Mod 5) equals 0, then set the animation of the caster.

This way, it will indeed only happen every 0.15 seconds

Also, you have several location/group leaks:

Example

• Set Leap_X = (X of ((Position of Leap_Caster[Leap_Integer[3]]) offset by Leap_Speed[Leap_Integer[3]] towards Leap_Angle degrees))
• Set Leap_Y = (Y of ((Position of Leap_Caster[Leap_Integer[3]]) offset by Leap_Speed[Leap_Integer[3]] towards Leap_Angle degrees))
• Set Leap_Loc = ((Position of Leap_Caster[Leap_Integer[3]]) offset by 15.00 towards Leap_Angle degrees)
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Terrain pathing at Leap_Loc of type Flyability is off) Not equal to True
  • Then - Actions
    • Custom script: call SetUnitX(udg_Leap_Caster[udg_Leap_Integer[3]],udg_Leap_X)
    • Custom script: call SetUnitY(udg_Leap_Caster[udg_Leap_Integer[3]],udg_Leap_Y)
  • Else - Actions
• Custom script: call RemoveLocation(udg_Leap_Loc)

How to fix this:

Code

• Set CasterLoc = (Position of Leap_Caster[Leap_Integer[3]])
• Set Leap_pos = (CasterLoc offset by Leap_Speed[Leap_Integer[3]] towards Leap_Angle degrees)
• Set Leap_Loc = (CasterLoc offset by 15.00 towards Leap_Angle degrees)
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Terrain pathing at Leap_Loc of type Flyability is off) Not equal to True
  • Then - Actions
    • Custom script: call SetUnitX(udg_Leap_Caster[udg_Leap_Integer[3]], GetLocationX(udg_Leap_pos))
    • Custom script: call SetUnitY(udg_Leap_Caster[udg_Leap_Integer[3]], GetLocationY(udg_Leap_pos))
  • Else - Actions
• Custom script: call RemoveLocation(udg_Leap_Loc)
• Custom script: call RemoveLocation(udg_CasterLoc)
• Custom script: call RemoveLocation(udg_Leap_pos)

There are other leaks as well, such as the Leap_Damage_Group that never gets destroyed and this line:

Line

• Set Leap_Loc = ((Position of Leap_Caster[Leap_Integer[3]]) offset by 15.00 towards Leap_Angle degrees)

In the last Else code block of your Loop trigger.

Other improvements:
- Instead of using a rate of 1000000000.00 for the flying height change, use 0, because that's instant. 1000000000.00 isn't totally instant.
- You should make the Thunder Clap special effect configurable. You should also make the water elemental projectile effect configurable.
- Instead of setting all the constant variables like the special effects, the damage type, the attack type and all the other constants in the casting trigger, you should do it on map initialization. You don't need to use an arrayed variable to lookup the special effect used for example, you can do it from a constant variable that only gets set once.

So, Leap_Speed, Leap_Height, Leap_Range_Base, Leap_Range_Factor, Leap_Anim_Integer, Leap_Sfx_2, Leap_Sfx_3, Leap_Damage_AoE, Leap_Damage_Type_1 and Leap_Damage_Type_2 should all be changed to normal variables (not arrays) and be set on map initialization.

 

[Marcos DAB]

I'm working on it now.

your arc sucks too.
Use this:
(((4xHeightBase)/MaxDistance)x((MaxDistance-Travelled)x(Travelled/Distance)))
In this case,the arc will be smooth

I don't want an arc purposely.

Edit: Updated <> 17:28, 14th Oct 2012

 

[Magtheridon96]

Hey, did you change the thumbnail to an in-game screenshot? Because I really don't want to clear my cache in order to find out :L

 

[Marcos DAB]

Hey, did you change the thumbnail to an in-game screenshot? Because I really don't want to clear my cache in order to find out :L

Thi is already done in v0.3.
Press F5.

Edit: Last version released (v0.4) <> 11:48, 15th Oct 2012

 

[Mapcreator_BL]

WOW cool... thanks man! nice job

 

[FUJI]

• Set Leap_Damage_Group = (Units within Leap_Damage_AoE[Leap_Index_Temp] of Leap_Caster_Loc)
• Unit Group - Pick every unit in Leap_Damage_Group and do (Actions)

You can use set bj_wantDestroyGroup = true and put the Leap_Damage_Group inside the group block like this:

• Custom Script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in (Units within Leap_Damage_AoE[Leap_Index_Temp] of Leap_Caster_Loc) and do (Actions)

Anyway pausing units is bad ^^.
Other than that nice effects and spell ^^.