[GUI] Corruption

[Moderator]

08:10, 14th Sep 2015
BPower: Requires proper tooltip.

 

[Daffa]

Those loop stuff can be put into the configurable or at least linked.

 

[Chaosy]

What do you mean? I don't quite understand.

 

[Daffa]

The loop trigger, those configurations before

• Trigger - Run CreateMissile <gen> (checking conditions)

(those set variables) would be better if moved into a separate trigger, allowing users to spot it easier.

 

[BPower]

Can you give a link to the Missile System?

in cast you could use CR_unit instead of GetTriggerUnit() within the loop.

Use an integer variable instead of bj_forLoopAIndex.

if b == false then --> if not b then.

Custom script: call SaveBoolean(udg_CR_hash, GetHandleId(udg_CR_unit), GetHandleId(GetEnumUnit()), true) --> you have the handle id stored in "h", use the variable.

The missile config stuff shouldn't be hardcoded.

 

[Chaosy]

The loop trigger, those configurations before

• Trigger - Run CreateMissile <gen> (checking conditions)

(those set variables) would be better if moved into a separate trigger, allowing users to spot it easier.

I see, that is a fair point. I will do that.

Can you give a link to the Missile System?

in cast you could use CR_unit instead of GetTriggerUnit() within the loop.

Use an integer variable instead of bj_forLoopAIndex.

if b == false then --> if not b then.

Custom script: call SaveBoolean(udg_CR_hash, GetHandleId(udg_CR_unit), GetHandleId(GetEnumUnit()), true) --> you have the handle id stored in "h", use the variable.

The missile config stuff shouldn't be hardcoded.

1. Sure, will do. (Done)
2. Not you too! but fine.(Done)
3. *nods* (Done)
4. Thanks! will fix (Done)
5. will do something about that. (Done)

 

[BPower]

Provide a proper tooltip. Currently it's the one used for thunderclap.
I would recommend to base the spell on the Channel ability.

 

[Chaosy]

Oh damn you, fine. I will do that too (Done)

I have not much experience with that spell, doesn't that have a channel time by default?

 

[BPower]

No it doesn't.

 

[nhocklanhox6]

What a beauty green power.
5/5 for me.

 

[Yours Truly]

Is this spell MUI?I need to know...

 

[Chaosy]

It is indeed MUI.

 

[Tank-Commander]

Noticed a few small details that were missed when you updated this:
- You use GetTriggerUnit() in the cast trigger when you already have CR_unit set to the triggering unit
- Trigger names should have the same prefix as your variables (CR Loop for example)
- Small note that it'd make sense to put the missile setup in with the init trigger, just reduces the amount of triggers to import at no cost
- Collision size of the outgoing projectiles should be configurable
- Add a version number to the resource
- You reference picked unit twice in the loop (once to assign to a variable, the other time to damage it)
- You also reference picked unit again when you remove it from the unit group when it should be CR_unit
- Change the folder name to match the spell, people need to be able to easily import and locate the files later

 

[Chaosy]

I'll fix everything but the missile setup trigger, I call that trigger in the loop when creating missiles. This is done to make the code less ugly.

 

[Tank-Commander]

That's fair enough, just a note that you missed out the AOE of outgoing projectiles (Pick units within 50.00 of (...)) into the cofigurables, the resource is however in an approvable state now, thanks for your work - it's a great looking spell which can have a lot of uses

 

[Chaosy]

Added CR_detect_range to config.

 

[KILLCIDE]

Cool looking spell I can't stop watching the GIF. I do have some minor suggestions though:

• I believe the filters to damage only enemy units is not enough. What about magic immune, units that are alive, etc?
• Why is the level of the ability and triggering player not stored on cast?
• Attack type and Damage type should be configurable

 

[Chaosy]

I will fix that soon TM.
Aka within the hour.

edit: I added the damage and attack type, the other require me to edit the code which is not something I want to do at the moment since I have not touched this spell in a while, I barely know how it works anymore.

 

[Deleted member 247165]

Extraordinary and well made spell! I have no objections for it. 5/5 from me.

 

[KILLCIDE]

Sorry for the update. Just updating the tags.

 

[tipou4444]

I am getting compile error from these two lines :
set udg_MS_tempreal[2] = ParabolaZ(udg_MS_MissileH2[udg_MS_Integer[3]], udg_MS_tempreal[1], udg_MS_distance[udg_MS_Integer[3]])
set udg_MS_tempreal[4] = (ZFacing(udg_MS_MissileH2[udg_MS_Integer[3]], udg_MS_tempreal[1], udg_MS_distance[udg_MS_Integer[3]])+90)
''Symbol not declared''
(ParabolaZ)
(ZFacing)
what does it means? and how can I fix it?

 

[Daffa]

Do you import everything properly? I assume it's from the missile system.

 

[tipou4444]

Do you import everything properly? I assume it's from the missile system.

I followed the steps and tried to import it from both original and this version, the only problem is this line which is the exact same in all versions

 

[KILLCIDE]

You need to add this to the map header:

function ParabolaZ takes real h, real d, real x returns real
  return (4 * h / d) * (d - x) * (x / d)
endfunction

function ZFacing takes real h, real d, real x returns real
  return Atan(4*h/d - 8*h*x/(d*d))*bj_RADTODEG+0.5
endfunction

 

[tipou4444]

function ParabolaZ takes real h, real d, real x returns real
return (4 * h / d) * (d - x) * (x / d)
endfunction

function ZFacing takes real h, real d, real x returns real
return Atan(4*h/d - 8*h*x/(d*d))*bj_RADTODEG+0.5
endfunction

Thanks alot!

 

[Warndong]

Hey, I was wondering if I had done something wrong, because I transfered this spell to my map and everything worked except for the healing part. Then I went back to the original map and reduced the health of the caster there to 1% and casted the spell. It seems the healing does not work on that map ethier. Any chance someone could help me fix it? Thanks

 

[Chaosy]

Not touched this in a long time, but it seems like the missile system should handle the healing. Not really sure why it wouldn't work to be honest.

 

[Dr Super Good]

Was brought to my attention that this spell fails some of the requirements to be approved.

The following issues must be resolved before the spell map can be approved.

1. The map description fields must be set to attempt to uniquely identify the map from other maps. This is to allow the map to be more easily searchable from the in game custom game list. Just another "Just another Warcraft III map" is not useful for searching. Player 2 must also be at least an empty slot to allow the map to be started. Although this is not the recommended approach to test spell maps, some people might prefer doing this which is why it must be supported.
2. The singular contained ability must function as described. It claims that it heals the caster for a percentage of affected enemy unit life but it does not when cast. The visuals appear indicating that it should, but no healing occurs.
3. The test map should allow every aspect of an ability to be tested without modification. There currently is no way to damage the ability test unit to check if the ability healing mechanic is working correctly. This is likely why issue 2 was not detected sooner.

 

[Chaosy]

The first point is not really fair. When this map was uploaded the resource section did not use the internal map name at all. You will find hundreds of spells that have not bothered to change this.

As for the rest.. doubt I will bother to update it as I no longer use GUI.