[GUI] Corpse Bomb 1.02

[Moderator]

Approved.

Suggested changes:

• Do this only after you remove a unit from the group, not 33x per second
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (CorpseBombInstanceGroup is empty) Equal to True
    • Then - Actions
      • Trigger - Turn off (This trigger)
    • Else - Actions
• CorpseBomb Cast should not set variables for every spell that is cast
• Removing an ability from a unit causes the ability to not have cooldown
• The throw bomb icon's position doesn't match the pick up ability's position

 

[ndh]

Played with this the other night, it's a pretty fun spell.

 

[Tank-Commander]

Really too many triggers for just one spell, really should have 3 (1 for config, one for cast, one for loop) and a very short one for dummy removal (if applicable) If you want to make checks to potentially cancel the spell, you can make it activate on "Starts casting an ability" then input the instance into the loop, then recheck using an artifical wait that they're still casting the ability and then cause the effects to happen which you want when the effect *actually* starts (note to scan beforehand to make sure each unit can only have one instance) and do it that way. Also the game messages can be spammed by just constantly hitting the spell's cast key and then pressing stop (or not)

Also shouldn't use custom value's (this is to account for system collision)

Just wanted to note that

 

[rulerofiron99]

Really too many triggers for just one spell, really should have 3 (1 for config, one for cast, one for loop) and a very short one for dummy removal (if applicable) If you want to make checks to potentially cancel the spell, you can make it activate on "Starts casting an ability" then input the instance into the loop, then recheck using an artifical wait that they're still casting the ability and then cause the effects to happen which you want when the effect *actually* starts (note to scan beforehand to make sure each unit can only have one instance) and do it that way. Also the game messages can be spammed by just constantly hitting the spell's cast key and then pressing stop (or not)

Also shouldn't use custom value's (this is to account for system collision)

Just wanted to note that

Thanks for the feedback.

On using "begins casting": I've never tried that method; I'll attempt and see how it goes.

On game message spam: the alternative is to clear text messages on the screen, which might clear useful game-related information. Unless there's another method?

On custom values: I'm using unit indexer for the caster and instance index, and custom values only for the units that are part of the "ball", the custom value being the same as their instance (custom value of the main dummy unit).

No comment on the spell itself? :/

 

[Tank-Commander]

You could use a timer for a sort of "cooldown" on the message for each player, so that it cannot come up more than once every x seconds, or use a counter so every 2-3 times they try to cause a failed use it'll give the message, something like that, the latter would be the fastest and most efficient but the x seconds would be most practical from an in-game perspective.

I'm aware of how it's being used, it's just better to index them with your own variables to avoid some global custom value-based system which would alter theirs for whatever reason (just for safety) though sometimes you can get away with it.

Well as far as the spell itself:

Co-ordinates would be better than locations (for moving units, fine for creating them) especially true in high numbers as it causes lag
Programming sections of the spells rather than using any form of object editor spells (other than the initial cast dummy spell) is better because less to import/remember and much easier to modify
Units need caching in your triggers

• Set tempId = (Custom value of (Picked unit))

When this activates when -any- unit dies, this is a particular reason why custom value is a bad idea, because that means if -any- system influences the custom value of this dying unit, you may have problems

more or less it for the skim-over

the spell idea itself has been done (in similar ways but typically not exactly) a few times, so it's nothing new, but I suppose it's useful, but highly situational since it requires units to be dead already for it to do anything at all

 

[rulerofiron99]

You could use a timer for a sort of "cooldown" on the message for each player, so that it cannot come up more than once every x seconds, or use a counter so every 2-3 times they try to cause a failed use it'll give the message, something like that, the latter would be the fastest and most efficient but the x seconds would be most practical from an in-game perspective.

Will do.

I'm aware of how it's being used, it's just better to index them with your own variables to avoid some global custom value-based system which would alter theirs for whatever reason (just for safety) though sometimes you can get away with it.

The main reason I do this is because the alternative was to put them in a unit group array indexed by the main dummy's id, but unit group arrays have that nasty requirement that you have to specify the array size which causes half of all importing problems.

Co-ordinates would be better than locations (for moving units, fine for creating them) especially true in high numbers as it causes lag
Programming sections of the spells rather than using any form of object editor spells (other than the initial cast dummy spell) is better because less to import/remember and much easier to modify
Units need caching in your triggers

• Set tempId = (Custom value of (Picked unit))

When this activates when -any- unit dies, this is a particular reason why custom value is a bad idea, because that means if -any- system influences the custom value of this dying unit, you may have problems

Will do. Ideally I should use a model for the corpse bomb... time to visit the requests forum I suppose.

the spell idea itself has been done (in similar ways but typically not exactly) a few times, so it's nothing new, but I suppose it's useful, but highly situational since it requires units to be dead already for it to do anything at all

Nothing original under the sun

Thanks again for your feedback.

 

[TKF]

If you use "Starts casting an ability" you can press stop after the casting has begun and the cooldown and mana cost will not be triggered.

But using "Starts casting an ability" is good for stopping a unit if you want a desired target you don't want to use the spell on for a certain condition.

 

[Tank-Commander]

The main reason I do this is because the alternative was to put them in a unit group array indexed by the main dummy's id, but unit group arrays have that nasty requirement that you have to specify the array size which causes half of all importing problems.

You could just use a unit array instead and array each dummy unit into the array and index it like you would anything else - that's what I do with my things

 

[CoLd Bon3]

...

How i looked when i viewed the spell

 

[Losam]

Excellent spell. I like it, you did a great job, I hope that your work is approved. Take 5/5 (votes).

 

[rulerofiron99]

Excellent spell. I like it, you did a great job, I hope that your work is approved. Take 5/5 (votes).

Thanks

I'm going to try make a spell every 2-3 weeks.

 

[Losam]

Thanks

I'm going to try make a spell every 2-3 weeks.

That's cool, good luck and creativity.

 

[Klasus]

It's a really great spell, but I found some bugs.

- If you pick up corpses and then skill the ability up one level, you can pick
up corpses again. If you do that, the previous corpse bomb can't be thrown at the ground, but it will still hover.

- If the caster dies, the corpse bomb will still hover above the ground.


EDIT: Sorry, the first problem was fixed by configuring some of the options you provided. The other problem can be fixed by reviving the unit.

I have a request, can you make so that instead of that the unit selects where to pick up the corpses, can it just be an ability that you activate and it will pick upp all corpses in X radius of the hero?

 

[Gustav.]

I imported the spell into my map, but there is one problem: Corpses are standing in mid air until they disappear.

 

[Gustav.]

I imported the spell into my map, but there is one problem: Corpses are standing in mid air until they disappear.

Now it's not working at all. Someone help me please!

 

[Devalut]

I imported the spell into my map, but there is one problem: Corpses are standing in mid air until they disappear.
Now it's not working at all. Someone help me please!

I'm having this problem as well.

Removing the Tempgroup in the initial cast and directly adding the units to the group seems to do the trick but then the Missile doesn't get added to the group which allows it to fire, causing it to spam "No corpse bomb" when trying to launch...