[Group Lab] Found anything interesting that can't be solved? Lets discuss it here!

[Troll-Brain]

So, i don't understand your question, care to elaborate ?

 

[Malhorne]

Null global variables after use.
For example null udg vars after use.

Maker told us to do this because it leaks.

 

[Troll-Brain]

I can't remember a test about that, but that shouldn't leak, unless ofc you destroy the handle later.

 

[Malhorne]

Yes if you set the global var to a unit.
It should be nulled at a moment so.

 

[chobibo]

Yeah, but I won't believe them without tests, at least that's how I roll when I was at wc3c.

I'm gonna call it jaws and vjaws from now on.

 

[Malhorne]

Ahah you're right

 

[Troll-Brain]

Yes, you don't have to believe me.
tests > all, that's how jass myths dead, or at least don't born.
Also it could be fixed since some patch, we all know how Blizzard fix them quickly

If the handle stored in the variable is likely to be destroyed, then yes you should null the variable, if not that really doesn't make any sense if there is a leak, even for jaws, that beats any logic.
I honestly think that you didn't understand what Maker said or himself wasn't aware about the leak i've mentionned, or something like that.
We're all a bunch of amateurs anyway.

 

[chobibo]

@Troll-Brain; Earlier today, I was asking Malhorne if he thinks nulling global variables was good practice, he told me Maker said so, I couldn't believe it so I asked your opinion about it. I wasn't very active those years, I wasn't able to get hold of that information about that awesome feature blizzard put onto jaws2, so I kept on telling Malhorne it was useless, as if I was a madman. Blizzard is fucking awesome.

EDIT: My previous reply was about Maker telling him it leaks, saying it leaks was so vague, I couldn't believe it. I didn't mean to say I won't believe you, or Maker, I just wanted to make sure. Sorry about that dude.

I just got used to seeing people tell "x is slow" without tests so I usually dismiss them as hoax.

 

[Troll-Brain]

No problem, as i told you i was serious, you don't have to believe me and anyone else.
I think i'm one of the most accurate people there, but sometimes i still can say some shit, like every human in fact.

Tests > all, check my signature.

 

[chobibo]

Jake discovered something useful, removing the timed life from an illusion created from the Item illusion thing (can't remember exactly). Pretty neat, I just learned it now, I dunno if it's already known though.

 

[T. D. W.]

Well, i know it is possilble by seting the duration to 0 in thr OE

 

[chobibo]

Cool! never knew that before. Gonna remember that, thanks man!

 

[Troll-Brain]

Many times "0" is for "infinite" in the OE, nothing surprising.
Also IIRC if you remove a timed life (which is an ability or a buff), the unit die.

Now maybe illusions are a special case, idk.

 

[chobibo]

@Troll-Brain: dude do you know the GetWidgetLife bug? The one associated with checking for a dead unit?

 

[Malhorne]

Ah this bug !
Mag explains it once sorry for didn't understanding >_<
Try this code

call SetWidgetLife(u, 0.4)
call SetWidgetLife(u, 10)

You'll see a walking dead xD

 

[T. D. W.]

lol? COOL xDDD

 

[chobibo]

Resurrected dead?

 

[Troll-Brain]

I only know that actually an unit die when his life reach lower than X, it should be a little more than 0.4.
I'm sure you can find the answer somewhere.

The GUI function just check for 0, which is not enough, but well even with the exact value it's still lame, still IIRC you can give some life to a dead unit, and even some passive abilities will do (at least that's what i've read).

I used IsUnitType(UNIT_TYPE_DEAD) and GetUnitTypeId() != 0

Some people also use the native AI function UnitAlive.

I suppose all solutions have pro and cons and might return true or false under some defined situations (unit is resurecting and so one).
And i think the best option would be use a custom function with one function argument and some constants (or maybe just a boolean, depends how many behaviors we have), then you can consider resurecting unit like dead or alive, stuff like that.
But here i'm just guessing that all solutions have a different behavior under some defined situations. And yes speedfreaks should be killed

I don't know any bug about it, ofc that doesn't mean there are none.

Chobibo go back to work, this half of half of half test is really a shame !

 

[chobibo]

Which one? I tested "aAAa" against "aaaa", the results were true, but the other one ("a\b" against "a\\b") doesn't even compile ("a\b") in both vanilla WE and JNGP.

 

[Troll-Brain]

Hmm that's strange, i'm fairly sure about something like that, what if you try a/b and a//b ?

 

[chobibo]

I tried that too, doesn't work either.

 

[Troll-Brain]

Ok i've finally found one of my post on a other forum :

StringHash("a/b") == StringHash("a\\b")
You could also try "ab" and "a b" maybe.

Never tested with gamecache keys.

 

[chobibo]

How'd you make that work? Vanilla just crashes on me when I try that. Gonna try the ab thing later, I'm busy atm hehe

 

[Troll-Brain]

Hmm strange, i will ask someone else which have wc3 installed in my native langage, just in case.

 

[chobibo]

Okay, good luck with that test.

 

[Malhorne]

Sorry I got it only in english bro :/
I left the french version ^^'

 

[chobibo]

:/ emote is so annoying...

 

[Troll-Brain]

Well, he has just tested and yes my claim was true (and gamecache key don't act like that), no crash whatever.
It should be something else which causes the crash, that doesn't make sense that a simple string "a/b" cause the worldeditor to crash on saving ...

 

[Malhorne]

Ahah chobibo is in bad emote mood

@Troll-Brain : ok

 

[chobibo]

I tested it on a blank map, dunno what else could it be though. Another case of Weird Editor... Oh I forgot to tell you that when it crashes, the map files aren't compressed, meaning all those *.* are left scattered on the save directory. Do note that the crashes happen on the vanilla editor.

EDIT: okay, I tested it again this time, for some reason it didn't crash, @_@ weird shit... Oh and StringHash("a/b") and StringHash("a\\b") is not equal. I'm using the vanilla Editor.

Heres the jass script:

//===========================================================================
function InitTrig_Melee_Initialization takes nothing returns nothing
local integer a=StringHash("a\b")
local integer b=StringHash("a\\b")
call BJDebugMsg("a is equal to "+I2S(a))
call BJDebugMsg("a is equal to "+I2S(b))
endfunction

The result was:

Hidden

Uh-oh, TB is now pissed! *runs away*

 

[Troll-Brain]

You have failed, it is a/b and a\\b

 

[chobibo]

Ahaha XD, sorry about that...
EDIT: Tested it, they're equal

function InitTrig_A takes nothing returns nothing
 local integer a=StringHash("a/b")
 local integer b=StringHash("a\\b")
 call DisplayTextToPlayer(GetLocalPlayer(),0,0,I2S(a))
 call DisplayTextToPlayer(GetLocalPlayer(),0,0,I2S(b))
endfunction

image

 

[Malhorne]

Lol Chobibo

 

[chobibo]

Yeah, I failed once more. I'm going to move on to particle emitters, at least they're more dumb friendly haha XD.

 

[Vinz]

What does Spy do. Ansp I think. I can't solve it.

 

[Malhorne]

Nobody knows.

 

[chobibo]

Maybe Troll-Brain knows.

 

[Vinz]

Nobody knows.

I think Jad does; since he asked that in the Daily Quiz.
Though I've done several tests with Permanent Invisibility and Spy, nothing happens.

 

[chobibo]

Where are you gonna use it? Why were you experimenting with it?

 

[Vinz]

I just wanted to know.
Love style.

 

[chobibo]

Oh, the ability doesn't show in-game when I tested it. It could be used as a marker ability though.

 

[Vinz]

Marker ability?

 

[chobibo]

Yeah, for campaign maps where MUI isn't required.

 

[Malhorne]

You can do it by adding unit to a group or using a temp buff to mark unit.

 

[Vinz]

Can anyone explain if we can simulate LoL's targeting system? I'm not a copycat, but it will highly benefit skillshots and such.

 

[Malhorne]

What do you mean ?
You mean the smart cast ?

 

[Vinz]

No, the targeting images.

 

[Rheiko]

ah, now you mention it.. their targeting images are look cool indeed
especially the ones for skillshots

i'm not sure if we can do it though, how about asking at WEHZ? maybe an expert know about this

 

[Malhorne]

You mean the little blue arrow ?

 

[Rheiko]

it's big malhorne not little ._.