[General] finding leak in trigger

[Yudistira]

i want ask something

i use this jass for finding leak in my map

HandleCount

function HandleCount takes nothing returns nothing
    local location L = Location(0,0)
    call BJDebugMsg(I2S(GetHandleId(L)-0x100000))
    call RemoveLocation(L)
    set L = null
endfunction

//===========================================================================
function InitTrig_HandleCount_Copy takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterTimerEvent(t,0.09,true)
    call TriggerAddAction(t,function HandleCount)
endfunction

and i found leak in this trigger , i already make it short

Bug

• bug
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Set LkasiTrap = (Position of Paladin 0002 <gen>)
    • Set Unit_Groups = (Units within 150.00 of LkasiTrap)
    • Custom script: call DestroyGroup(udg_Unit_Groups)
    • Custom script: set udg_Unit_Groups = null
    • Custom script: call RemoveLocation(udg_LkasiTrap)

how to fix the leak ?

 

[jonhysone]

Remove this line or put it before the third line .

• Custom script: set udg_Unit_Groups = null

You need to null the group then destroy it . Or don't null it . If you Null a unit group . Then it has leaks . Because it already has a value .

 

[Yudistira]

Still cant , the number still increasing

 

[edo494]

your logic john is flawed, if you null group and then you try to destroy it, you will try to destroy null group, that will create leak

If you null agent without destroying/removing it, it will leak, if you dont null local agents the handle counter will be kept(maybe 4 bytes/non nulling)

I once found out printing handle ids of timers that the handle id is not recycled immedietally, it is recycled in buches, so after like 3000 handle ids it flushed them all at once

 

[Yudistira]

your logic john is flawed, if you null group and then you try to destroy it, you will try to destroy null group, that will create leak

If you null agent without destroying/removing it, it will leak, if you dont null local agents the handle counter will be kept(maybe 4 bytes/non nulling)

I once found out printing handle ids of timers that the handle id is not recycled immedietally, it is recycled in buches, so after like 3000 handle ids it flushed them all at once

so how to fix that leak edo ??

 

[Assassins-Creed]

Use this before destroying the group:

• Unit Group - Pick every unit in UnitGroups and do (Unit Group - Remove (Picked unit) from UnitGroups)

 

[flacidTurtle]

lol this is my thread

 

[Yudistira]

Use this before destroying the group:

• Unit Group - Pick every unit in UnitGroups and do (Unit Group - Remove (Picked unit) from UnitGroups)

Doesn't work also..

how can remove that leak ?
is it possible ?

 

[Assassins-Creed]

Are there any actions in this trigger? Cause if you have another trigger that uses the unit group variable you made, it wont be able to use it. The unitgroup gets destroyed instantly after creation.

 

[Yudistira]

no , actually i make a new map with just 1 trigger , that trigger

 

[Vinz]

You need to null the group then destroy it .

Isn't it actually the other way around?