[General] Finding leak in trigger

[Yudistira]

Please help me find the leak of this trigger and also the right trigger

Trigger

• setup trap
  • Events
    • Time - Every 10.30 seconds of game time
  • Conditions
  • Actions
    • Set Unit_Groups_Copy = (Units owned by Player 1 (Red) matching (((Matching unit) is Mechanical) Equal to True))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in Unit_Groups_Copy) Greater than 15
        • (Unit-type of Acc1) Equal to P.Shadow
      • Then - Actions
        • Set Unit_Groups = (Random 1 units from (Units in (Entire map) matching (((Owner of (Matching unit)) Equal to Player 1 (Red)) and (((Matching unit) is Mechanical) Equal to True))))
        • Unit Group - Pick every unit in Unit_Groups and do (Unit - Remove (Picked unit) from the game)
        • Game - Display to (Player group(Player 1 (Red))) the text: Maximum trap 15
        • Custom script: call DestroyGroup(udg_Unit_Groups)
        • Custom script: set udg_Unit_Groups = null
      • Else - Actions
        • Do nothing
    • Custom script: call DestroyGroup(udg_Unit_Groups_Copy)
    • Custom script: set udg_Unit_Groups_Copy = null
    • Wait 1.00 seconds
    • Set Unit_Groups_Copy = (Units owned by Player 2 (Blue) matching (((Matching unit) is Mechanical) Equal to True))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in Unit_Groups_Copy) Greater than 15
        • (Unit-type of Acc2) Equal to P.Shadow
      • Then - Actions
        • Set Unit_Groups = (Random 1 units from (Units in (Entire map) matching (((Owner of (Matching unit)) Equal to Player 2 (Blue)) and (((Matching unit) is Mechanical) Equal to True))))
        • Unit Group - Pick every unit in Unit_Groups and do (Unit - Remove (Picked unit) from the game)
        • Game - Display to (Player group(Player 2 (Blue))) the text: Maximum trap 15
        • Custom script: call DestroyGroup(udg_Unit_Groups)
        • Custom script: set udg_Unit_Groups = null
      • Else - Actions
        • Do nothing
    • Custom script: call DestroyGroup(udg_Unit_Groups_Copy)
    • Custom script: set udg_Unit_Groups_Copy = null

 

[Nichilus]

You don't need to create the same group 2 times. Instead of the second unit group, just use this:

• Unit - Remove (Random unit from Unit_Groups_Copy) from the game

Remove Do Nothing

You could improve your trigger by using an array called Acc (e.g. Acc[1] for player 1, Acc[2] for player 2) and integer loop.
Also, is there a need for the 1 second wait?

 

[pOke]

you could cut this down with a for each temp int, or you may want to create a whole new trig, although I don't know what your goal is, seems to me if the player goes from 15 to 17 you only remove 1 keeping them at 16, and if they keep this up they could go as big as they want.