[General] Need help finding leak

[Yudistira]

hello, i want ask something
i make trigger with event every 3 sec , i use handle counter to check if the trigger leaking or not..

but when the trigger already run 3 times ( at 10 sec) , the number increasing..

trigger

• error
  • Events
    • Time - Every 3.00 seconds of game time
  • Conditions
  • Actions
    • Set MLoop[1] = 0
    • Set MLoop[1] = (MLoop[1] + 1)
    • Set Striker[18] = (Position of Hero[MLoop[1]])
    • Set Unit_Groups = (Units within 750.00 of Striker[18] matching ((((Matching unit) is A Hero) Equal to True) and (((Player number of (Owner of (Matching unit))) Greater than or equal to 1) and (((Player number of (Owner of (Matching unit))) Less than or equal to 9) and (((Match
    • Set NumUnit = (Number of units in Unit_Groups)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • NumUnit Greater than 0
      • Then - Actions
        • Unit Group - Pick every unit in Unit_Groups and do (Actions)
          • Loop - Actions
            • Unit - Cause Hero[MLoop[1]] to damage (Picked unit), dealing 5.00 damage of attack type Spells and damage type Normal
      • Else - Actions
    • Custom script: call DestroyGroup(udg_Unit_Groups)
    • Custom script: set udg_Unit_Groups = null
    • Custom script: call RemoveLocation(udg_Striker[18])
    • Game - Display to (All players) the text: post 1
    • Wait 0.10 seconds
    • Game - Display to (All players) the text: post 1.25
    • Set MLoop[1] = (MLoop[1] + 1)
    • Set Striker[18] = (Position of Hero[MLoop[1]])
    • Game - Display to (All players) the text: post 1.3
    • Set Unit_Groups = (Units within 750.00 of Striker[18] matching ((((Matching unit) is A Hero) Equal to True) and (((Player number of (Owner of (Matching unit))) Greater than or equal to 1) and (((Player number of (Owner of (Matching unit))) Less than or equal to 9) and (((Match
    • Game - Display to (All players) the text: post 1.35
    • Set NumUnit = (Number of units in Unit_Groups)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • NumUnit Greater than 0
      • Then - Actions
        • Unit Group - Pick every unit in Unit_Groups and do (Actions)
          • Loop - Actions
            • Unit - Cause Hero[MLoop[1]] to damage (Picked unit), dealing 5.00 damage of attack type Spells and damage type Normal
      • Else - Actions
    • Game - Display to (All players) the text: post 1.5
    • Custom script: call DestroyGroup(udg_Unit_Groups)
    • Custom script: set udg_Unit_Groups = null
    • Custom script: call RemoveLocation(udg_Striker[18])
    • Game - Display to (All players) the text: post 2

Handle counter jass,

handle counter

function HandleCount takes nothing returns nothing
    local location L = Location(0,0)
    call BJDebugMsg(I2S(GetHandleId(L)-0x100000))
    call RemoveLocation(L)
    set L = null
endfunction

//===========================================================================
function InitTrig_HandleCount takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterTimerEvent(t,0.09,true)
    call TriggerAddAction(t,function HandleCount)
endfunction

in game , i take screen shot of handle counter,
it happen when action "wait 0.1 sec " start
i am already turn off all trigger , for checking whether another trigger causing it , but it is not , the causes come from this trigger itself

chatlog

can anyone help me finding the leak ?

 

[lordsent]

dont know where are the leaks. But your wait of 0.1 seconds will not work for this reason:

smallest posible wait is = 0.3 seconds aprox.

Also why set group of units to null if you destroy them ??

 

[Yudistira]

dont know where are the leaks. But your wait of 0.1 seconds will not work for this reason:

smallest posible wait is = 0.3 seconds aprox.

Also why set group of units to null if you destroy them ??

i ordered like that to destroy group then null it..haha (don't know why)

i already try wait 1 sec and nothing changes..

 

[lordsent]

can you write the hole Set Unit_Groups = .... Because i cant see the end of it please

For what you post it seems that the mayor issue is between 1 and 1.25 and that is the wait. Believe me using waits in loop triggers is a bad idea in general pros told me that. Wc3 engine is bad with waits for some ( only god or blizzard knows why ).

 

[Yudistira]

here the map ,
please help , i am already tried doing manything for hours but still can't

http://www.hiveworkshop.com/forums/attachments/world-editor-help-zone-98/128690d1377085032-need-help-finding-leak-pleasehelp.w3x

 

[lordsent]

Yudistira you have like x5 repeat acctions. And you didnt change the time properly. You just set it worst to = wait 0.01 game-time seconds. This does not work.

I am not really good at removing leaks. But all i can tell you is that for me your trigger is better without the waits inside the loops.
Use a counter with a integrer variable.
run the trigger every 1 second.
add +1 to the counter. When reaches 3 active the damage. reset to 0.

 

[Yudistira]

the problem is , it is not must be 3 sec , every 1 sec is not problem,
but if i remove the "wait" even it 0.01 or 1 sec , it already make the number of handle counter increase..
u can test it..
i still confuse

 

[Daffa]

remove the null group, you already nulling a destroyed global group (global auto recycles, there's no need for nulling)
tell me if it's still there.

 

[lordsent]

I dont know really sorry. But you do some strange thinks like for example:

why Set Striker[18] ?? Why 18 if you dont have 17 ?
Also type Spell damage is needed? Can you just set to normal the default.

Trying my best sry.

 

[Daffa]

okay, as I expected, the set udg_Unit_Groups = null causes leaks.
keep in mind global auto recycle, no nullifying is needed

EDIT :
Still Increasing for some unknown reason, send us the whole trigger in fully enabled state.
that can help us remove leaks.

 

[Yudistira]

I dont know really sorry. But you do some strange thinks like for example:

why Set Striker[18] ?? Why 18 if you dont have 17 ?
Also type Spell damage is needed? Can you just set to normal the default.

Trying my best sry.

haha , that just 1 trigger of my map..
i use many times variable striker with any array..btw +rep to u..haha

@daffa the mage..

i already delete

set udg_Unit_Groups = null

, but it same , after 3 times trigger executed , the number of handle counter is increasing..

 

[lordsent]

Okey^^ this is simple. Just tell me the idea of the trigger. And i will trigger for you if i can

 

[Yudistira]

okeyy,actually i not to smart to configure AI well,
i see that if AI attacked he will use all of his skill ,


so i make this trigger , to damage AI if there is another nearby heroes, so he can aggressively attacking / use skill to that heroes..

thats all..

 

[lordsent]

xDD knew what had a problem. Okey dont worry just tell me what spells you want the AI unit or units to cast.

If they are normal spells you can just do:
Order unit group to attack move to point.
If they encounter enemies they will automatically cast the spells.

 

[Yudistira]

if it not normal spell ?
how to make ai use that skill ?

 

[lordsent]

if it not normal spell ?
how to make ai use that skill ?

Post your spell or tell me more about it and then i figure out how the AI can use it.

But the fast way is to use Storm bolt or spells that normaly the mele AI uses when he attack-moves.

 

[jonhysone]

Unit - Issue Order [The Type of the spell -Target Point-Target Unit-No Target-....And the based ability...

Or Order by ID

 

[Yudistira]

how to order by id ?
can you give an example ? , can it used to use custom spell ?

 

[Maker]

I think it is the local group created by the unit group pick in GUI.

This is "Units within x of location matching..."

function GetUnitsInRangeOfLocMatching takes real radius, location whichLocation, boolexpr filter returns group
    local group g = CreateGroup()
    call GroupEnumUnitsInRangeOfLoc(g, whichLocation, radius, filter)
    call DestroyBoolExpr(filter)
    return g
endfunction

Trigger bug Events Time - Every 0.03 seconds of game time Conditions Actions Set MLoop[1] = 0 Set MLoop[1] = (MLoop[1] + 1) Set Striker[18] = (Position of Hero[MLoop[1]]) Set Unit_Groups = (Units within 750.00 of Striker[18] matching ((((Matching unit) is A Hero) Equal to True) and (((Player number of (Owner of (Matching unit))) Greater than or equal to 1) and (((Player number of (Owner of (Matching unit))) Less than or equal to 9) and (((Match Set NumUnit = (Number of units in Unit_Groups) If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions NumUnit Greater than 0 Then - Actions Unit Group - Pick every unit in Unit_Groups and do (Unit - Cause Hero[MLoop[1]] to damage (Picked unit), dealing 5.00 damage of attack type Spells and damage type Normal) Else - Actions Custom script: call DestroyGroup(udg_Unit_Groups) Custom script: set udg_Unit_Groups = null Custom script: call RemoveLocation(udg_Striker[18]) Custom script: set udg_Striker[18] = null

->

function Trig_bug_Copy_2_Func004002003001 takes nothing returns boolean
    return ( IsUnitType(GetFilterUnit(), UNIT_TYPE_HERO) == true )
endfunction

function Trig_bug_Copy_2_Func004002003002001 takes nothing returns boolean
    return ( GetConvertedPlayerId(GetOwningPlayer(GetFilterUnit())) >= 1 )
endfunction

function Trig_bug_Copy_2_Func004002003002002001 takes nothing returns boolean
    return ( GetConvertedPlayerId(GetOwningPlayer(GetFilterUnit())) <= 9 )
endfunction

function Trig_bug_Copy_2_Func004002003002002002 takes nothing returns boolean
    return ( IsUnitEnemy(GetFilterUnit(), ConvertedPlayer(udg_MLoop[1])) == true )
endfunction

function Trig_bug_Copy_2_Func004002003002002 takes nothing returns boolean
    return GetBooleanAnd( Trig_bug_Copy_2_Func004002003002002001(), Trig_bug_Copy_2_Func004002003002002002() )
endfunction

function Trig_bug_Copy_2_Func004002003002 takes nothing returns boolean
    return GetBooleanAnd( Trig_bug_Copy_2_Func004002003002001(), Trig_bug_Copy_2_Func004002003002002() )
endfunction

function Trig_bug_Copy_2_Func004002003 takes nothing returns boolean
    return GetBooleanAnd( Trig_bug_Copy_2_Func004002003001(), Trig_bug_Copy_2_Func004002003002() )
endfunction

function Trig_bug_Copy_2_Func006Func001002 takes nothing returns nothing
    call UnitDamageTargetBJ( udg_Hero[udg_MLoop[1]], GetEnumUnit(), 5.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
endfunction

function Trig_bug_Copy_2_Func006C takes nothing returns boolean
    if ( not ( udg_NumUnit > 0 ) ) then
        return false
    endif
    return true
endfunction

function Trig_bug_Copy_2_Actions takes nothing returns nothing
    set udg_MLoop[1] = 0
    set udg_MLoop[1] = ( udg_MLoop[1] + 1 )
    set udg_Striker[18] = GetUnitLoc(udg_Hero[udg_MLoop[1]])
    set udg_Unit_Groups = GetUnitsInRangeOfLocMatching(750.00, udg_Striker[18], Condition(function Trig_bug_Copy_2_Func004002003))
    set udg_NumUnit = CountUnitsInGroup(udg_Unit_Groups)
    if ( Trig_bug_Copy_2_Func006C() ) then
        call ForGroupBJ( udg_Unit_Groups, function Trig_bug_Copy_2_Func006Func001002 )
    else
    endif
    call DestroyGroup(udg_Unit_Groups)
    set udg_Unit_Groups = null
    call RemoveLocation(udg_Striker[18])
    set udg_Striker[18] = null
endfunction

//===========================================================================
function InitTrig_bug_Copy_2 takes nothing returns nothing
    set gg_trg_bug_Copy_2 = CreateTrigger(  )
    call TriggerRegisterTimerEventPeriodic( gg_trg_bug_Copy_2, 0.03 )
    call TriggerAddAction( gg_trg_bug_Copy_2, function Trig_bug_Copy_2_Actions )
endfunction

Changing

function Trig_bug_Copy_2_Actions takes nothing returns nothing
    set udg_MLoop[1] = 0
    set udg_MLoop[1] = ( udg_MLoop[1] + 1 )
    set udg_Striker[18] = GetUnitLoc(udg_Hero[udg_MLoop[1]])
    set udg_Unit_Groups = GetUnitsInRangeOfLocMatching(750.00, udg_Striker[18], Condition(function Trig_bug_Copy_2_Func004002003))
    set udg_NumUnit = CountUnitsInGroup(udg_Unit_Groups)
    if ( Trig_bug_Copy_2_Func006C() ) then
        call ForGroupBJ( udg_Unit_Groups, function Trig_bug_Copy_2_Func006Func001002 )
    else
    endif
    call DestroyGroup(udg_Unit_Groups)
    set udg_Unit_Groups = null
    call RemoveLocation(udg_Striker[18])
    set udg_Striker[18] = null
endfunction

->

function Trig_bug_Copy_2_Actions takes nothing returns nothing
    local group g = CreateGroup()
    set udg_MLoop[1] = 0
    set udg_MLoop[1] = ( udg_MLoop[1] + 1 )
    set udg_Striker[18] = GetUnitLoc(udg_Hero[udg_MLoop[1]])
    call GroupEnumUnitsInRangeOfLoc(g, udg_Striker[18], 750, Condition(function Trig_bug_Copy_2_Func004002003))
    set udg_NumUnit = CountUnitsInGroup(g)
    if ( Trig_bug_Copy_2_Func006C() ) then
        call ForGroupBJ( g, function Trig_bug_Copy_2_Func006Func001002 )
    else
    endif
    call DestroyGroup(g)
    set g = null
    call RemoveLocation(udg_Striker[18])
    set udg_Striker[18] = null
endfunction

And the handle count will not increase.

 

[Yudistira]

thanks a lot maker for your help..

problem solved..