Eternal Evil v1.0.1

[KILLCIDE]

Cool concept. Also reminds me of Abaddon's ultimate in DotA. However, I am a little concerned with you using the custom value of the unit as the indice. This normally wouldn't be a problem, but what happens when that same unit casts another instance while the other is still active? The special effect will get overwritten, and the Counter variable will be all messed up. Once you add a fix for this, I can quickly approve it Could you also rename the test map?

 

[Daffa]

Thank you for the review. I will deal with the issue soon when I have access to Warcraft editor in Mac.

EDIT :
See my profile for details, will update soon.

 

[Daffa]

1.0.1
Fixed issues mentioned by @KILLCIDE.

 

[KILLCIDE]

A simple spell concept that can easily find itself in the kit of any Hero from any game type. It has decent configurables and is leakless.

Needs Fixed

• Nothing

Suggestions

• As of right now, you have it so that a caster cannot have more than two instances active at once. With this in mind, it seems pretty pointless to store data such as CustomValue, Active[], Level[], & Timer[] before this check. You should only store this data once you know you need it.
• The way you are preventing fatal damage seems incorrect. As of right now, it seems like it will work because there are not a lot of damage instances happening. I had a similar problem with this in the past, and I consulted Bribe on how to properly do it with his damage system. I advise doing the same!
• The logic you have set up in EE Damage for when Eternal Evil user is attacking is right, but I would set it up like this to avoid unnecessary work:
  
  • -------- Eternal Evil user is attacking --------
  • Set EE_CustomValue = (Custom value of DamageEventSource)
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • EE_Active[EE_CustomValue] Equal to True
    • Then - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • EE_PreserveHeal Equal to False
        • Then - Actions
          • Unit - Set life of DamageEventSource to ((Life of DamageEventSource) + DamageEventAmount)
        • Else - Actions
          • Set EE_FinalHeal[EE_CustomValue] = (EE_FinalHeal[EE_CustomValue] + (DamageEventAmount x EE_PercentageOfDamage[EE_Level[EE_CustomValue]]))
    • Else - Actions

Status

Approved​

 

[Daffa]

I would like to know about the second issue in the suggestion, as that is sonewhat concerning and needs to be patched. Would you mind tell me how to fix it or should I ask Bribe himself?

I'll take note of the others and update accordingly.

 

[KILLCIDE]

I don't remember the fix. It was a request I made for someone a loong time ago.

 

[Daffa]

Very well, I will ask Bribe himself on the matter.

 

[Bribe]

Are you using Damage Engine?

If so, the way to do it is via DamageModifyEvent Equal to 4.00

This event is used for applying fixed-damage Shields, but also is fine to use for fatal damage prevention as that is also considered a shield.

You check if DamageEventAmount minus the life of the DamageEventTarget is less than 0.50, and if so set the DamageEventAmount to either 0 or whatever happy medium damage reduction you want.

 

[KILLCIDE]

You check if DamageEventAmount minus the life of the DamageEventTarget is less than 0.50

I recall you giving me a fraction that was more accurate. Was it 2.00 / 4.93?

 

[Bribe]

Easier to just do 4.05/10.00 but there's no reason to be that exact. He could do 0.41 to get close enough - i just couldn't think of the exact number at the time.

 

[Daffa]

I'll go with 0.41 I guess. Thanks for the information.

 

[Dinodin]

Very cool spell! I'm using it in my map but there is also problem with the duration of the spell. It seems to last for 5 seconds for all levels even if I set the duration differently for all levels. Pls fix!

 

[Daffa]

Very cool spell! I'm using it in my map but there is also problem with the duration of the spell. It seems to last for 5 seconds for all levels even if I set the duration differently for all levels. Pls fix!

I started to wonder why this issue exists on two different spells with very different code-base. If possible, would you mind sending me a copy of your map so I can investigate from there?

 

[Daffa]

I also tested this spell on the test map provided and cannot replicate the issue regarding duration. I suspect either something map specific OR the visual cues can be confusing especially due to the duration being extremely similar (0.5 seconds is barely noticeable for human eyes and easy to confuse one's perceptions).