[Trigger] error when testing/loading map

[jooster]

i have no idea why im getting this error....the error messege im receiving is

if ( not ( UnitTypeIsInRegion(gg_rct_start_loc, 'hbla') == false ) ) then


my trigger looks like this

• Player Group - Pick every player in Force1 and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Does start_loc <gen> contain a unit of Type random_race[1]) Equal to False
      • Then - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Does start_loc <gen> contain a unit of Type Blacksmith) Equal to False
          • Then - Actions
            • Unit - Create 1 Blacksmith for (Triggering player) at (starting_location[(Player number of (Triggering player))] offset by (800.00, 150.00)) facing Default building facing (270.0) degrees
          • Else - Actions
            • Do nothing
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Does start_loc <gen> contain a unit of Type random_race[2]) Equal to False
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Does start_loc <gen> contain a unit of Type Blacksmith) Equal to False
              • Then - Actions
                • Unit - Create 1 Blacksmith for (Triggering player) at (starting_location[(Player number of (Triggering player))] offset by (800.00, 150.00)) facing Default building facing (270.0) degrees
              • Else - Actions
                • Do nothing
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Does start_loc <gen> contain a unit of Type random_race[3]) Equal to False
              • Then - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Does start_loc <gen> contain a unit of Type Blacksmith) Equal to False
                  • Then - Actions
                    • Unit - Create 1 Blacksmith for (Triggering player) at (starting_location[(Player number of (Triggering player))] offset by (800.00, 150.00)) facing Default building facing (270.0) degrees
                  • Else - Actions
                    • Do nothing
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Does start_loc <gen> contain a unit of Type random_race[4]) Equal to False
                  • Then - Actions
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • (Does start_loc <gen> contain a unit of Type Blacksmith) Equal to False
                      • Then - Actions
                        • Unit - Create 1 Blacksmith for (Triggering player) at (starting_location[(Player number of (Triggering player))] offset by (800.00, 150.00)) facing Default building facing (270.0) degrees
                      • Else - Actions
                        • Do nothing
                  • Else - Actions
                    • Do nothing

 

[Avator]

Isn't there another message you see just above that? (Starting with Line ...: <ERROR TYPE>)

Also, I suggest you remove all 'Do Nothing' commands from the Else - Actions. There's no need for them, and they seem to still need to be performed as an actions (so I've heared), so it's only annoying to add them if not necessary.

 

[Element of Water]

It's not that trigger (or at least that part of the trigger) that has an error. GUI triggers without custom script in can't give error messages. So you have an error in some custom script somewhere that makes the game think there's an error in that trigger.

 

[Kwah]

A few tips, but these aren't the problem. Nest your if/the/else's it is more efficient. And, as Avator said remove Do Nothings.

 

[jooster]

the error when i got that was "name expected" or w/e, and thanks for the heads up on removing do nothings, and what do you mean by nest my if/then/else's?

 

[Kwah]

Put the if/the/else's inside of each other. That way it reduces the number of checks it has t do. If its this, then it stops checking and does the actions. They way you have it now, even if the first check is true, it will still try the others.

 

[Avator]

Remember that hawk900's way is for when you need only 1 of the If/Then/Else triggers to activate. If you want multiple Then - Actions to activate, don't put them in the Else command of the other trigger that also has to activate.

 

[YO_MA_MA]

if ( not ( UnitTypeIsInRegion(gg_rct_start_loc, 'hbla') == false ) ) then

what type of array is random_race[x] and are u sure that 1-4 have values? i think it's crashing because random_race[x] is set to null or not set yet.

 

[jooster]

random race[x] is a unit-type array thats the main Hall. they have their values set in the map intialization trigger