Energy Glyph V1.25

[Moderator]

A well done spell that looks good.

You should still pay attention to actions that you do in both then and else. Those can be taken out of the if/then/else most of the time. Like the clear child hashtable.
The tooltip text could be redone, I prefer the look of abilities done by Blizzard.

v1.20 review

Set to "needs fix" for the following reasons

• Not flushing child hashtables
• Too many effects
• Lacking importing settings/instructions

Check my reply in this thread for more comments.

19 Dec 2011
Bribe: Approved. The code, like for your other spells, is above the requirements and the effects are really great with this one. I give it 5/5 (Highly Recommended) status. It's a great GUI spell.

 

[Magtheridon96]

In the trigger "Energy Glyph", you should cache that "Load 8 from bla bla bla" into a real variable because you're referencing it a lot.
Same goes for (Level of bla bla) and anything else you're referencing more than once.
(Last created unit) is another example.

Oh and I wouldn't recommend playing around with unit movement speeds :x
You should create dummy units and order them to cast some "Slow" spell instead.
This is because a user might not want you to touch their base movement speed (He may have editted it somewhere), and this method is very bad with Recursion and stacking.

The Warcraft III engine handles these slow effects much better than anyone does. (Stacking is taken into consideration)

edit

• Unit - Kill u

Please don't hurt me D:

Instead of killing the units, you should remove them.

 

[Tank-Commander]

Noted, Should take about 10-20 minutes to make the changes (laziness)

Edit: The reason I kill units is fairly visible - if they're removed instead the trigger isn't activated to actually start the spell properly as it requires death, and I kill the orbs instead of removing them /mainly/ for the death effect

As for the slow effect I guess I'll take my chances XD *Shrugs childishly* granted I did make a change so it'll only effect current - don't know if that helps at all, but yeah I understand the risks of using it like that - I just wanted to avoid using an object data spell for the slow effect; makes me feel like I'm cheating XD

Edit2: I don't see the dublication Bribe, probably a mistake on my part (spaghetti code)

 

[Cihparg]

Edit: The reason I kill units is fairly visible - if they're removed instead the trigger isn't activated to actually start the spell properly as it requires death, and I kill the orbs instead of removing them /mainly/ for the death effect

...or you could check if the unit exists.

 

[Jay the Editor]

At first when I read the description, I thought you stole the idea from my spell. However, it was much more complex and has nicer effect than mine. Energy Ball 1.9b

 

[Tank-Commander]

I can see why you thought that - though I hadn't seen that spell before, maybe it's a sign for me to check old spells before making new ones more closely XD

 

[Jay the Editor]

hahaha..

 

[Maker]

Comments

Importing instructions are lacking

• References to unit types and abilities might point to wrong types
• Create variables for unit type and ability

Unit dies trigger is on all the time

• Turn it on when you create a glyph
• Turn it off when a glyph dies and there are no more living glyphs

You have Custom script: call RemoveLocation (udg_EG_TempPoint) twice in the unit dies trigger, move it out of the if/then/else.

A leak: check the looping trigger, stage 1. In the unit group loop you set TempPoint, but remove TempPoint2.

You should use an active icon for the ability, not a passive ability icon.
The tooltip lists the formulas of the damage and stuff, it doesn't look nice.

I don't see you flushing child hashtables.

The amount of effects is ridiculous. I casted it on four of my units, and it created 536 effects per cast. About 234 effects per second. By my standards this counts as effect spam.

 

[wickedcool]

wow really nice spell 5/5

 

[Marsal]

Effects up in the ass. Pretty nice job dude.

 

[Auildere]

It won't quite work on my W3E please help!

 

[Tank-Commander]

You'll have to be more specific than that if you want my help.

 

[Auildere]

My trigger editor is saying codes that is a error Actually i'm new soo....

 

[Tank-Commander]

That still doesn't help, you have to tell me -what- error -exactly-
there's no reason for there to be an error if the importing instructions were followed correctly in the "information" comment

 

[Auildere]

I copied the instructions but when i save the loop disables and saying errors.....

 

[Tank-Commander]

you need to tell me -what- error, exactly. saying "errors" is not helpful

 

[Auildere]

Somethings wrong with the triggers maybe cuz i already have custom spells?