Energy Fissure - v2.0.3

[Moderator]

16th Dec 2011
Bribe: This is a recommended spell. Nice work!

Your timeouts and "dummy count" stuff could be configurable. Think of things that can be configured, for example the thunderclap special effect. I think after making all these things configurable it should be "Highly Recommended" because I really like the spell.

 

[SpectreD]

thanks for the share ^^

 

[Mr_Bean]

You like it?

 

[Mr_Bean]

Update:
- Slightly improved the code as per Bribe's suggestion.

 

[Ruke]

Nice spell.
Maybe you can try with T32 with short periods.

If a variable will never change his value, make it constant (look your globals).

Maybe you can make your filters configurables for the user (when you enumerate units in a group and work with them in the loop).

In the Timer_Actions3 method, the timer was not nulled.

You don't need null the trigger (you will never destroy it).

set D.owner = GetOwningPlayer(D.caster)

->

set D.owner = GetTriggerPlayer()

I think that's all.
Again, nice spell .

Greetings.

EDIT: Only if you want, you can add a Preload() to your special effect to prevent lag in the first time .

 

[Mr_Bean]

Thanks Ruke!

Update:
- Further improved the code (thanks Ruke).
- You can now configure the following things:

> How many waves make up each pulse.
> What the effects are that are created around the circumference of the energy fissure.
> How many of these effects are created.
> The effect that is created when the spell is cast.
​

 

[Maker]

No need to null u in Timer_Actions_3 as the loop exits when u == null.

(not(IsUnitType(u, UNIT_TYPE_DEAD)))
->
not IsUnitType(u, UNIT_TYPE_DEAD)
^Becomes more readable

In Timer_Actions_2, and Timer_Actions calculate degtorad here:
local real mod = 360 / EFFECT_COUNT * bj_DEGTORAD
and not in Cos and Sin.

Variables of type trigger need not be nulled, only if you destroy the trigger. I think I said to null them in the other spell of yours, but ignore that

Always place at least two casters in test map and you could apply something that restores mana/resets cooldowns.

 

[Bribe]

Even better than not nulling triggers is to use something like RegisterPlayerUnitEvent, then you don't even need triggers >

 

[Mr_Bean]

Update:
- Slightly improved the code.
- Added another caster to the test map.
- Added another spawn region for creeps in the test map.
- Added a new ability in the test map: Refresh (resets all ability cooldowns and restores mana).

 

[baassee]

-JNGP is not made by Vexorian. JASSHelper is.

-call RemoveGuardPosition(dummy) Why?

-You don't check if the enumed units are magic immune thus wastes a lot of dummies if cast on a group which all are magic immune.

-You should use Maker's lightning library and trigger the manaburn. Then you can also trigger custom mana burn values and damage.

-EFFECT_COUNT and WAVE_COUNT are both uppcase but not constants, maybe make a function instead?

-Because of this above, things like this 360 / EFFECT_COUNT * bj_DEGTORAD should be stored into a global.

-I although disagree with myself with the above point. Why use degrees in the first place? Use radians all the way aka 2PI / EFFECT_COUNT which should be stored into a constant.

-You can cast carrion swarm on places which are not pathable? Or am I wrong?

-This should have the debug keyword all over it (infront of each row).

            if WAVE_INDEX <= 0 or WAVE_INDEX > 4 then
                call ClearTextMessages()
                call BJDebugMsg("|cffff0000Energy Fissure Error:|r WAVE_INDEX is set to an invalid value. Defaulting to 2.")
                set WAVE_COUNT = 8
            endif
            if EFFECT_INDEX <= 0 or EFFECT_INDEX > 4 then
                call ClearTextMessages()
                call BJDebugMsg("|cffff0000Energy Fissure Error:|r EFFECT_INDEX is set to an invalid value. Defaulting to 2.")
                set EFFECT_COUNT = 8
            endif

Else I couldn't find any more... fun to pick on. Good job.

 

[Mr_Bean]

call RemoveGuardPosition(dummy) Why?

Because if the caster is owned by a computer player, they will control the dummy, therefore preventing it from casting Manaburn. I have tested this...

You can cast carrion swarm on places which are not pathable? Or am I wrong?

I'm pretty sure you can't. I ran into this issue while I was coding this spell for the first time.

I will update the spell tomorrow. Any more things I can improve on?

 

[baassee]

Although I find calls within the same thread interruptable even by the game engine itself. Seems like you learn something new everyday!

I thought it was ground targeted aka everywhere?

 

[Mr_Bean]

Update:
- More minor code improvements.
- More things you can configure. Among others, you can now configure how much mana is burned and how much damage is dealt. Check out "What You Can Configure".

EDIT: The next quick-fix release will fix the Manaburn effect from being visible in fogged areas. It will also move these lines: call SetTimerData(t, D) and call TimerStart(t, 0.5, false, function thistype.Timer_Actions_4) out of the loop.

 

[Ruke]

if SHOW_MANA_BURNED then

->

static if SHOW_MANA_BURNED then

set t = null
Don't null the trigger, is not required .

Try to add http://www.hiveworkshop.com/forums/jass-resources-412/snippet-spelleffectevent-187193/

if IsUnitEnemy(u, D.owner) and not IsUnitType(u, UNIT_TYPE_DEAD) and not IsUnitType(u, UNIT_TYPE_MAGIC_IMMUNE) then

It be awesome if this was configurable.

if DAMAGE_IS_INDEPENDENT then

->

static if DAMAGE_IS_INDEPENDENT then

Greetings

 

[Mr_Bean]

What difference does having static in front of the if make?

 

[Ruke]

What difference does having static in front of the if make?

Using static ifs will delete the unneeded code.

 

[Mr_Bean]

Excuse my ignorance, but what unneeded code?

 

[baassee]

If the boolean returns false, it will comment out the code that is within the static if and end if.

 

[Ruke]

Read the manual:

Static ifs

static ifs are like normal ifs, except that a) the condition must contain only constant booleans, the and operator and the not operator and b) They are evaluated during compile time. Which means that the code that is not matched to its condition is simply ignored.

    library OptionalCode requires optional UnitKiller
        globals
            constant boolean DO_KILL_LIB = true
        endglobals

        function fun takes nothing returns nothing
            local unit u = GetTriggerUnit()
            //the following code may need to kill the unit
            //but is alternatively able to use the external
            //'UnitKiller' library to do the library.
            // ONLY when DO_KILL_LIB is true AND the
            // library UnitKiller is in the map.
            static if DO_KILL_LIB and LIBRARY_UnitKiller then
                //static if because if the UnitKiller
                // library was not in the map, using a normal
                // if would not remove this line of code and
                // therefore it would cause a syntax error.
                // (unable to find function UnitKiller)
                call UnitKiller(u)
            else
                call KillUnit(u)
            endif
        endfunction

    endlibrary

    library UnitKiller

        function UnitKiller(unit u)
            call BJDebugMsg("Unit kill!")
            call KillUnit(u)
        endfunction

    endfunction

 

[Ranger21]

This spell needs fix, it gives me bugs after some amounts of use

 

[Mr_Bean]

Update - v2.0:
- Completely rewrote everything from scratch. It made me want to cry when I saw how badly I used to code.

I would like to apologise to the Hive community for my poor coding back at the end of 2011. I thought that since I'm running a spell workshop, my resources should be up-to-scratch.

 

[Maker]

I would like to apologise to the Hive community for my poor coding back at the end of 2011. I thought that since I'm running a spell workshop, my resources should be up-to-scratch.

Keep on apologizing since you need to use GetLocationZ when setting the height of lightnings and text tags show through black mask

 

[Mr_Bean]

Sigh, okay. I will fix those issues soon.

Update - v2.0.1:
- Texttags are now only visible to players who have vision of the area (thanks Maker).
- Lightnings' heights are now calculated properly (thanks Maker).
- The player now gains vision of the target point while the spell is active (can be disabled).
- Added a delay between the units being zapped and the "void" being destroyed.

 

[Mr_Bean]

Update - v2.0.2:
- Fixed it so that the waves are destroyed as soon as they reach their max distance, instead of after DESTROY_DELAY (when the energy fissure is destroyed).
- Changed the unit filter so that it properly checks for dead units.

I also added screenshots that illustrate what the spell does.

 

[BPower]

The Spell is not working. Try your testmap, after the visual effect nothing happens.

 

[Mr_Bean]

Thanks! I made such a stupid mistake with the function that filters out bad units.