Dummy Adds Buff

[laserdemon]

I was trying to make a dummy to add buff to damaged unit, but i failed. Any suggestion?

function AntiMagicShell_Conditions takes nothing returns boolean
    return(GetUnitTypeId(udg_GDD_DamagedUnit)=='U001')or(GetUnitTypeId(udg_GDD_DamagedUnit)=='U002')or(GetUnitTypeId(udg_GDD_DamagedUnit)=='U003')
endfunction

function AntiMagicShell_Actions takes nothing returns nothing
    local location udg_GDD_DamagedUnit_Loc=GetUnitLoc(udg_GDD_DamagedUnit)
    local unit AntiMagicShellDummy=CreateUnitAtLoc(Player(10),'h00P',udg_GDD_DamagedUnit_Loc,270.)
    local timer AntiMagicShell_CD=CreateTimer()
    call DisableTrigger(GetTriggeringTrigger())
    call UnitAddAbility(AntiMagicShellDummy,'A000')
    call IssueTargetOrder(AntiMagicShellDummy,"antimagicshell",udg_GDD_DamagedUnit)
    call TimerStart(AntiMagicShell_CD,GetRandomInt(10,20),false,null)
    if TimerGetRemaining(AntiMagicShell_CD)<=0 then
        call EnableTrigger(GetTriggeringTrigger())
    endif
    call RemoveUnit(AntiMagicShellDummy)
    set AntiMagicShellDummy=null
    call DestroyTimer(AntiMagicShell_CD)
    call RemoveLocation(udg_GDD_DamagedUnit_Loc)
endfunction

function InitTrig_AntiMagicShell takes nothing returns nothing
    set gg_trg_AntiMagicShell=CreateTrigger()
    call TriggerRegisterVariableEvent(gg_trg_AntiMagicShell,"udg_GDD_Event",EQUAL,0)
    call TriggerAddCondition(gg_trg_AntiMagicShell,Condition(function AntiMagicShell_Conditions))
    call TriggerAddAction(gg_trg_AntiMagicShell,function AntiMagicShell_Actions)
endfunction

 

[Chaosy]

Ew..

I suggest you read this: http://www.hiveworkshop.com/forums/...80/jpag-jass-proper-application-guide-204383/
Because your code is pretty much unreadable at the moment.

 

[laserdemon]

You feel it too compact? But i feel comfortable reading this way

I made the code looks better now

 

[Chaosy]

Okay there are quite a few small changes you could make, I can point those out if you want to.

But the main problem is that you do not understand how to use a timer properly.
If you use plain jass, you need a GUI variable for the dummy unit, or if vjass is fine you simply declare a global variable in a global block instead.

Try this (You need a GUI unit variable named "myGuiVariable" to prevent errors):

function AntiMagicShell_Conditions takes nothing returns boolean
    return(GetUnitTypeId(udg_GDD_DamagedUnit)=='U001')or(GetUnitTypeId(udg_GDD_DamagedUnit)=='U002')or(GetUnitTypeId(udg_GDD_DamagedUnit)=='U003')
endfunction

function timerIsNowGone takes nothing returns nothing
    call EnableTrigger(gg_trg_AntiMagicShell)
    call RemoveUnit(udg_myGuiVariable)
endfunction

function AntiMagicShell_Actions takes nothing returns nothing
    local location udg_GDD_DamagedUnit_Loc=GetUnitLoc(udg_GDD_DamagedUnit)
    set udg_myGuiVariable =CreateUnitAtLoc(Player(10),'h00P',udg_GDD_DamagedUnit_Loc,270.)
    call DisableTrigger(gg_trg_AntiMagicShell)
    call UnitAddAbility(udg_myGuiVariable,'A000')
    call IssueTargetOrder(udg_myGuiVariable,"antimagicshell",udg_GDD_DamagedUnit)
    call TimerStart(CreateTimer(),GetRandomInt(10,20),false, function timerIsNowGone)
    call RemoveLocation(udg_GDD_DamagedUnit_Loc)
endfunction

function InitTrig_AntiMagicShell takes nothing returns nothing
    set gg_trg_AntiMagicShell=CreateTrigger()
    call TriggerRegisterVariableEvent(gg_trg_AntiMagicShell,"udg_GDD_Event",EQUAL,0)
    call TriggerAddCondition(gg_trg_AntiMagicShell,Condition(function AntiMagicShell_Conditions))
    call TriggerAddAction(gg_trg_AntiMagicShell,function AntiMagicShell_Actions)
endfunction

This example is not MUI, I am too lazy to create that to the honest.

 

[laserdemon]

So that's how I use timer? I convert from BJ to native where I see BJ set handlerFunc to null. I shall try it now to see whether it works or not.

 

[Chaosy]

You CAN use a timer by using null, but that is just more difficult. You'd need to create a new trigger with the event "yourtimer" expires.

 

[laserdemon]

So what is the purpose of

TimerGetRemaining

 

[Chaosy]

There is no common usage of the function as far as I know.

 

[laserdemon]

Unfortunately, still the same result after I made the changed you mentioned. This is how it looks like now:

function AntiMagicShell_Conditions takes nothing returns boolean
    return(GetUnitTypeId(udg_GDD_DamagedUnit)=='U001')or(GetUnitTypeId(udg_GDD_DamagedUnit)=='U002')or(GetUnitTypeId(udg_GDD_DamagedUnit)=='U003')
endfunction

function AMS_CD_End takes nothing returns nothing
    call EnableTrigger(gg_trg_AntiMagicShell)
endfunction

function AntiMagicShell_Actions takes nothing returns nothing
    local location udg_GDD_DamagedUnit_Loc=GetUnitLoc(udg_GDD_DamagedUnit)
    local unit AntiMagicShellDummy=CreateUnitAtLoc(Player(12),'h00P',udg_GDD_DamagedUnit_Loc,270.)
    local timer AntiMagicShell_CD=CreateTimer()
    call DisableTrigger(GetTriggeringTrigger())
    call UnitAddAbility(AntiMagicShellDummy,'A000')
    call IssueTargetOrder(AntiMagicShellDummy,"antimagicshell",udg_GDD_DamagedUnit)
    call TimerStart(AntiMagicShell_CD,GetRandomInt(10,20),false,function AMS_CD_End)
    call RemoveLocation(udg_GDD_DamagedUnit_Loc)
    call RemoveUnit(AntiMagicShellDummy)
    call DestroyTimer(AntiMagicShell_CD)
endfunction

function InitTrig_AntiMagicShell takes nothing returns nothing
    set gg_trg_AntiMagicShell=CreateTrigger()
    call TriggerRegisterVariableEvent(gg_trg_AntiMagicShell,"udg_GDD_Event",EQUAL,0)
    call TriggerAddCondition(gg_trg_AntiMagicShell,Condition(function AntiMagicShell_Conditions))
    call TriggerAddAction(gg_trg_AntiMagicShell,function AntiMagicShell_Actions)
endfunction

 

[Chaosy]

Since you destory the timer after it's created it obviously can't expire after 10-20 seconds.

 

[laserdemon]

I did notice the problem and fixed it before you reply, and yet, with no luck, it still doesn't work.

 

[Xonok]

You destroy the dummy before it gets to cast the ability.

 

[KILLCIDE]

Unless your dummy has 0 cast backswing, then this line will be a problem. call RemoveUnit(AntiMagicShellDummy)

Could also be object editor error. Does the anti magic shell ability have no mana cost, max cast range, and the correct Allowed targets field?

 

[laserdemon]

Is it necessary for me to destroy the dummy? I set the HP regeneration to -1 and HP to 2

 

[Xonok]

When you set it to die it will remove by itself eventually. You can make it disappear faster by setting the death option in object editor to "can't raise, does not decay"