Does KillUnit(GetTriggerUnit()) Leak?

[Zeatherann]

function KillTriggerUnit takes nothing returns nothing
    local unit U=GetTriggerUnit()
    call KillUnit(U)
    set U=null
endfunction

Do I have to set unit U to null at the end of the function? I'm pretty sure I do. Also, do I even have to have the local variable or will only using call KillUnit(GetTriggerUnit()) work as well without leaking?

This function is used in a trigger's condition if it matters.

 

[Xonok]

Units leak a tiny amount of memory no matter what you do.
You can null the unit variable though. If nothing else, then it doesn't hurt at least.

 

[BPower]

1.) If you use the local, you have to null it.
2.) call KillUnit(GetTriggerUnit()) doesn't leak.

 

[TriggerHappy]

For any handle that's destroyed you have to null all references (locals, globals) to it or else it will leak.

Also, killing the unit doesn't remove it so yeah it does leak.

EDIT: I ran some more tests and apparently when the unit decays it's removed, however there's still that leak you can't get rid of.

My previous tests were invalid because I was checking the handle id of a killed unit.

//So basically
local unit u = CreateUnit(Player(0), 'hfoo', 0, 0, 0)
call BJDebugMsg(I2S(GetHandleId(u)))
call BJDebugMsg(I2S(GetUnitTypeId(u)))
call RemoveUnit(u)
call TriggerSleepAction(0)
call BJDebugMsg(I2S(GetUnitTypeId(u))) // displays 0
call BJDebugMsg(I2S(GetHandleId(u))) // should display same thing no matter how much time has passed

 

[Zeatherann]

Units leak a little, how little? Also, I've gotten answers to 'yes it leaks' and 'no it doesn"t'.

 

[BPower]

To summarize it for you
a) declared local and global unit variables should be nulled once you are done with them.
b) call KillUnit(GetTriggerUnit()) does not leak per se and can be used savely.
c) however every removed (decayed or removed) unit leaves a very small leak behind, send complains to blizzard.

Aslong as you are not spamming tousands of units it shouldn't be a problem at all.

 

[Zeatherann]

So this function doesn't leak either?

function A takes nothing returns nothing
    call RemoveDestructable(GetTriggerDestructable())
endfunction

Or call DestroyTimer(GetExpiredTimer()).

 

[TriggerHappy]

So this function doesn't leak either?

Right, unless you have a reference to the handle somewhere that you haven't nulled.

 

[Zeatherann]

Cool. It might have been a stupid question, but knowing how Blizzard made JASS... Thanks TriggerHappy.