Disconnecing from custom scripts

[Forgotten_Warlord]

so this custom script is disconnecting people

Custom script: if GetLocalPlayer() == GetOwningPlayer(GetTriggerUnit()) then
Custom script: endif


is there a way to use this where it doesn't do that?

 

[Teelo]

What are you doing between those custom scripts.

 

[Forgotten_Warlord]

well cinematic fades or special effects.
just creating or showing

 

[Teelo]

Post everything between the custom scripts.

 

[Forgotten_Warlord]

• Zoomin
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to (==) Zoom (Neutral Hostile 1)
  • Actions
    • Set PN = (Player number of (Owner of (Triggering unit)))
    • Custom script: if GetLocalPlayer() == GetOwningPlayer(GetTriggerUnit()) then
      • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • Zoomed[PN] Equal to (==) False
        • Then - Actions
          • Set Zoomed[PN] = True
          • Set shootpoint = ((Position of PlayerHero[PN]) offset by 1500.00 towards (Facing of PlayerHero[PN]) degrees)
          • Unit - Create 1 Dummy Bullet for (Player(PN)) at shootpoint facing (Facing of PlayerHero[PN]) degrees
          • Animation - Change (Last created unit)'s vertex coloring to (100.00%, 100.00%, 100.00%) with 100.00% transparency
          • Set Shot[PN] = (Last created unit)
          • Custom script: call RemoveLocation(udg_shootpoint)
          • Custom script: call SetCameraUnit(GetLastCreatedUnit())
          • Custom script: call SetMovementUnit(GetLastCreatedUnit(),GetOwningPlayer(GetLastCreatedUnit()),5)
          • Cinematic - Fade out and back in over 1.00 seconds using texture Black Mask and color (0.00%, 0.00%, 0.00%) with 0.00% transparency
          • Cinematic - Apply a filter over 0.00 seconds using Normal blending on texture war3mapImported\ScopeFilter.blp, starting with color (100.00%, 100.00%, 100.00%) and 100.00% transparency and ending with color (0.00%, 0.00%, 0.00%) and 0.00% transparency
        • Else - Actions
          • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • Zoomed[PN] Equal to (==) True
            • Then - Actions
              • Set Zoomed[PN] = False
              • Unit - Remove Shot[PN] from the game
              • Custom script: call SetCameraUnit(GetTriggerUnit())
              • Custom script: call SetMovementUnit(GetTriggerUnit(),GetOwningPlayer(GetTriggerUnit()),5)
              • Cinematic - Fade out and back in over 1.00 seconds using texture Black Mask and color (0.00%, 0.00%, 0.00%) with 0.00% transparency
              • Cinematic - Hide filter
            • Else - Actions
    • Custom script: endif

 

[Teelo]

• Set Zoomed[PN] = True

That right there will be causing your disconnect. I didn't even look past that.
You cannot do anything that will be broadcasted and confirmed with the other clients in a multiplayer game, within a GetLocalPlayer() block.

 

[Forgotten_Warlord]

oh ok thanks +rep

 

[Teelo]

Just looked over the code, if you use locals instead of globals it should work. I'm not 100% on whether modifying a local will cause a desync though.

Since Blizzard changed it a while back, so we can't override a global anymore, you would need to convert that trigger to JASS and change the globals PN, Zoomed, PlayerHero, and Shot to locals.

 

[Forgotten_Warlord]

yeah.. I dont know much about that lol

 

[PurgeandFire]

• Set Zoomed[PN] = True

That right there will be causing your disconnect. I didn't even look past that.
You cannot do anything that will be broadcasted and confirmed with the other clients in a multiplayer game, within a GetLocalPlayer() block.

This is not necessarily true. It doesn't disconnect for modifying variables. (Except in specific cases) Creating handles, random seeds, using a string for the first time, etc. causes disconnections in the map. =)

There are a few things that'd cause your disconnect in the code.

• Unit - Create 1 Dummy Bullet for (Player(PN)) at shootpoint facing (Facing of PlayerHero[PN]) degrees

First and foremost, creating normally allocated handles (eg: unit) causes disconnects in maps. So, you'd need to find a workaround to that^.

• Cinematic - Fade out and back in over 1.00 seconds using texture Black Mask and color (0.00%, 0.00%, 0.00%) with 0.00% transparency
• Cinematic - Apply a filter over 0.00 seconds using Normal blending on texture war3mapImported\ScopeFilter.blp, starting with color (100.00%, 100.00%, 100.00%) and 100.00% transparency and ending with color (0.00%, 0.00%, 0.00%) and 0.00% transparency

These disconnect because they destroy timers (and some of the functions create new timers). This is a problem since they are normally allocated handles. You'd need to find a work around to this as well. =(

Generally, doing things in large blocks for a local player is like a "Disconnect Me" sign. Here is a tutorial that might shine some light on GetLocalPlayer() for those curious:
GetLocalPlayer() Tutorial

Basically, you have to use a series of hide/show usages, and modifications of arguments to make things actually work for a single player. Usually it is pretty dangerous, especially when dealing with things like units.