[Spell] DDS attempt need opionions

[Chaosy]

Hey, I decided to learn how a DDS works so I took a look from the weeps DDS and and converted it to as much GUI as possible. So I want opionions on what you think should be changed/improved.

triggers

• init
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • Custom script: if GetUnitAbilityLevel(GetEnumUnit(), 'Aloc') == 0 then
        • Custom script: set udg_GDDS_trigger [GetUnitUserData(GetEnumUnit())] = CreateTrigger()
        • Trigger - Add to GDDS_trigger[GDDS_integer] the event (Unit - (Picked unit) Takes damage)
        • Custom script: call TriggerAddCondition(udg_GDDS_trigger [GetUnitUserData(GetEnumUnit())], Condition(function GDDS_store))
        • Custom script: endif

• init
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
      • Loop - Actions
        • Custom script: if GetUnitAbilityLevel(GetEnumUnit(), 'Aloc') == 0 then
        • Custom script: set udg_GDDS_trigger [GetUnitUserData(GetEnumUnit())] = CreateTrigger()
        • Trigger - Add to GDDS_trigger[GDDS_integer] the event (Unit - (Picked unit) Takes damage)
        • Custom script: call TriggerAddCondition(udg_GDDS_trigger [GetUnitUserData(GetEnumUnit())], Condition(function GDDS_store))
        • Custom script: endif

• add
  • Events
    • Unit - A unit enters (Playable map area)
  • Conditions
  • Actions
    • Custom script: if GetUnitAbilityLevel(GetTriggerUnit(), 'Aloc') == 0 then
    • Custom script: set udg_GDDS_trigger [GetUnitUserData(GetTriggerUnit())] = CreateTrigger()
    • Trigger - Add to GDDS_trigger[GDDS_integer] the event (Unit - (Triggering unit) Takes damage)
    • Custom script: call TriggerAddCondition(udg_GDDS_trigger [GetUnitUserData(GetTriggerUnit())], Condition(function GDDS_store))
    • Custom script: endif

• remove
  • Events
    • Unit - A unit leaves (Playable map area)
  • Conditions
  • Actions
    • Custom script: if GetUnitAbilityLevel(GetTriggerUnit(), 'Aloc') == 0 then
    • Custom script: call DestroyTrigger(udg_GDDS_trigger [GetUnitUserData(GetTriggerUnit())])
    • Custom script: endif

• store
  • Events
  • Conditions
  • Actions
    • Custom script: endfunction
    • Custom script: function GDDS_store takes nothing returns boolean
    • Set GDDS_Damage = (Damage taken)
    • Set GDDS_Damaging_Unit = (Damage source)
    • Set GDDS_Damaged_Unit = (Triggering unit)
    • Set GDDS_event = 1.00
    • Set GDDS_event = 0.00
    • Custom script: return false

 

[Maker]

Unit leaves region isn't a good way to destroy the triggers. When units die and decay, exiting the game, the event won't trigger.

 

[Chaosy]

what do you suggest then?

I am thinking of adding a second event, a unit dies but that wont check when removed from the game

 

[Xonok]

what do you suggest then?

I am thinking of adding a second event, a unit dies but that wont check when removed from the game

Unit decays.

But that won't work for things that don't decay(skeletons)

 

[Maker]

Unit decays triggers when units start decaying. Units can be revived.

Unit indexers detect the moment of units being removed from the map by giving them custom defend ability and detecting the undefend order.