Desync

[biridius]

My map desyncs but the only places using GetLocalPlayer:

1. change unit transparency
2. change texttag text
3. show/hide multiboards
4. set camera distance, target, etc.
5. create and show a fade filter

Which one of these could it be?

The map triggers are here, they are in cjass (ignore the "character data" folder)
Trigger Viewer | HIVE

Personally I suspect either the multiboards or the fade filters.

 

[Illidan(Evil)X]

if IAbsBJ(View[GetPlayerId(GetLocalPlayer())].battle_index) != a {text=""}

if IAbsBJ(View[GetPlayerId(GetLocalPlayer())].battle_index) == index
{
    CinematicFadeCommonBJ(33, 67, 67, 0.5 * 0.5, "ReplaceableTextures\\CameraMasks\\White_mask.blp", 75, 75)
    FinishCinematicFadeAfterBJ(0.5)
}

Using string literals or concatenations in local blocks has been known to cause desyncs if the string doesn't already exist in the string table.
The function FinishCinematicFadeAfterBJ creates a timer handle, which is obviously very bad.

function FinishCinematicFadeAfterBJ takes real duration returns nothing
    // Create a timer to end the cinematic fade.
    set bj_cineFadeFinishTimer = CreateTimer()
    call TimerStart(bj_cineFadeFinishTimer, duration, false, function FinishCinematicFadeBJ)
endfunction

 

[~El]

Using string literals or concatenations in local blocks has been known to cause desyncs if the string doesn't already exist in the string table.

Source? I use local string manipulation extensively in my code, but it never caused any issues.

 

[biridius]

The function FinishCinematicFadeAfterBJ creates a timer handle, which is obviously very bad.

function FinishCinematicFadeAfterBJ takes real duration returns nothing
    // Create a timer to end the cinematic fade.
    set bj_cineFadeFinishTimer = CreateTimer()
    call TimerStart(bj_cineFadeFinishTimer, duration, false, function FinishCinematicFadeBJ)
endfunction

Right, this must be it, how did I overlook it?
Thanks!

Not sure about the strings but will put them somewhere in initialization to add to string table, just in case.

 

[biridius]

I put the "finish" functions outside the local code, and initialised the "" and " " strings. Hope it will work.

 

[IcemanBo]

5. create and show a fade filter

This could be the dangerous point. Have a look at @WaterKnight 's script to use filters properly for one player.

Using string literals or concatenations in local blocks has been known to cause desyncs if the string doesn't already exist in the string table.

I believe same as:

Source? I use local string manipulation extensively in my code, but it never caused any issues.

.. it should be a common tequnique for local usage, so string table seems does not need to be synced. @DracoL1ch made a thread about this topic.