Delayed Action 1.5a

[Chaosy]

Interesting, I am actually surprised over the fact that this did not exist already.

 

[Veritas 117]

I agree with Chaosy. This is a good idea and is super useful in boss fights.

 

[Tasyen]

Thanks for your Feedback.
I uploaded a newer Version (V1.2) cause of some fatal design Misstakes:

• DE now try to Refill old Unused Indexes first before using new ones, the old behaviour could together with unlimted Duration reach Max Arrazsize pretty Easy.
• Negative Reloads won't countdown anymore, cause the are there to be unlimited.
• Removed an unneeded Line in a Demo.
• Added an Helper Folder containing two Triggers to pause/unpause all current DE.
• Added a new Vari udg_DE_Index_Entered, Representing the Index in which you DE was created.

 

[zv27]

Interesting, I am actually surprised over the fact that this did not exist already.

A few years ago there was such a system only much more advanced(Jass and vJass version)
system is actually supported everything concerning the special effects(static non-static,periodic,delayed etc.)
but then I suddenly decided to remove all my resources.
So this is nothing new.

A few ideas from my system.
- the possibility to change the model during the execution.
- the possibility of combining several models during the execution.(
For example, at the same time apply a fire, ice, poison etc.)
- the possibility that the system recognizes whether the effect is static or not static.
- the possibility that the system selects a random effect from the list or database of effects.
- the possibility that the system defines the location where the effect will be applied(For example, hand head, weapons, etc.)For this I use integers, eg: left hand = 1,right hand =2,weapon=3 etc.

 

[Tasyen]

A few years ago there was such a system only much more advanced(Jass and vJass version)
system is actually supported everything concerning the special effects(static non-static,periodic,delayed etc.)
but then I suddenly decided to remove all my resources.
So this is nothing new.

A few ideas from my system.
- the possibility to change the model during the execution.
- the possibility of combining several models during the execution.(
For example, at the same time apply a fire, ice, poison etc.)
- the possibility that the system recognizes whether the effect is static or not static.
- the possibility that the system selects a random effect from the list or database of effects.
- the possibility that the system defines the location where the effect will be applied(For example, hand head, weapons, etc.)For this I use integers, eg: left hand = 1,right hand =2,weapon=3 etc.

Quite Some nice ideas, i'll overthink how to add some of them as optional features.

 

[zv27]

Quite Some nice ideas, i'll overthink how to add some of them as optional features.

Some of the ideas are not easy to do, especially the second and third.
So, I hope you succeed.

 

[Tasyen]

Updated to Version 1.3.
This Update added the Features:

• Delayed Effects can start Frequently own Delayed Effects, which can be setuped like normal ones. (@zv27 I had that idea as i was creating your suggestion of spawing Grafical effects.)
  
• You can Terminate Delayed Effects from outside.

• P_Variables gained the Prefix "DE___"

Updated/Added new Demos showing this Features.

 

[KILLCIDE]

Wietlol's system and Almia's system is pretty superior to yours, Tasyen. Have you compared your system to theirs? If so, I'd like for you to let me know why yours is different and or better. If I see some good points, I can give this system a review and possibly approve it.

 

[Tasyen]

No haven't done that before. But i did after you mentioned them.
->They are pretty different than mine and indeed use more advanced techniques:

Almia's "Timed Effect":
Has not much to do with "DE" (this system), cause "TE" is about placing grafical effects for a duration.

Wietlol's "Effect over Time":
Is overlapping with "Delayed Effect" indeed. But EoT is focusing on Buffs & Units and allows custom Code beeing triggered by using Custom Events. It requiers costum script in every trigger using EoT (you can copy paste the needed Lines in most cases, so this is fine). Indeed EoT is powerful and the better choice, if you plan to create unique Unit-Effects like Buffs or Curses.

Mine "Delayed Effect":
Allows you to execute Triggers after a delay/frequently. DE does not need custom script to be used and can hold any Array-Variable connected to a running DE. Supports from itself location based Actions which EoT does not ( with this i mean without the use of custom script). Additional i have the cool Feature of predfined DE starting a DE which is needed for intervalic Traps dealing DpS or Vulcans shooting multiple rocks over time. DE are not unique allows you to spam them.

TE and EoT might be much better as i say, only checked out what thy do in general.

Renaming this System (Delayed Effect) might be a good idea maybe: "Delayed Action" to stop that confuse with "Timed Effect", what you think about that.

 

[IcemanBo]

I also thought first it has to do something with gariphical effects ( have not read code), maybe your alternative name would be better.
From the description I'm not very sure yet how it exactly will achieve something that one normal can't easily achieve, but I'm curious
to check it out (some later though).

By the way, I see that you don't use an english editor. You can always PM me with onUpdate for example and semd me the map, so I can easily copy and paste english triggers for you.

 

[KILLCIDE]

Delayed Action would be more appropriate. Some of the resources I linked aren't really relevant, but Wietlol's system is very similar. Maybe we can make an exception for yours being GUI friendly. I will take a look at the API for Wiet's system sometime this weekend.

 

[Tasyen]

Renamed and updated to Delayed Action 1.3a.

 

[zv27]

This system is different from the above system and should be approved.It has a totally different approach.
After all, to me it all looks like Rising Dusk's system from 2007.
Unfortunately, originality is gone all copy each other constantly repeating the same things.

Edit:
It seems that the spell section slowly becomes boring.

 

[Pyrogasm]

After reading the threads and looking at them in the WE my understanding is that this system isn't really fundamentally different from Weitlol's. Yours executes the triggers directly and his relies on "variable becomes equal to..." events for the triggers, while his requires a few minor JASS calls in custom script lines (that any GUI user can figure out/undestand IMO). They both do approximately the same things:

• Catch some regular event
• Store these sorts of things: caster, target (unit/point), 1 real, 1 integer
• Allow creation/automatic cleanup of 1 effect per instance
• Run another trigger after a delay

Ultimately both are just systems for the automated storage/retrieval of data you would ideally save locally (if you were writing JASS) or in a struct (if you were using vJASS) but are forced to store globally because GUI can't do either. Unless I fundamentally misunderstand the code, both are effectively 'general-purpose spell struct that loops through all instances every X seconds' done in GUI.

Convince me there's a reason I would use yours over Weitlol's.

 

[Tasyen]

After reading the threads and looking at them in the WE my understanding is that this system isn't really fundamentally different from Weitlol's. Yours executes the triggers directly and his relies on "variable becomes equal to..." events for the triggers, while his requires a few minor JASS calls in custom script lines (that any GUI user can figure out/undestand IMO). They both do approximately the same things:

• Catch some regular event
• Store these sorts of things: caster, target (unit/point), 1 real, 1 integer
• Allow creation/automatic cleanup of 1 effect per instance
• Run another trigger after a delay

Ultimately both are just systems for the automated storage/retrieval of data you would ideally save locally (if you were writing JASS) or in a struct (if you were using vJASS) but are forced to store globally because GUI can't do either. Unless I fundamentally misunderstand the code, both are effectively 'general-purpose spell struct that loops through all instances every X seconds' done in GUI.

Convince me there's a reason I would use yours over Weitlol's.

You understood the full purpose of this System.

Don't need to convince you as you are able to use advanced WE scripting -> you are not the target group of this Uploaded System at all.

As i said before Weitlol's EOT focuses on Units and Buffs the result is Unique Unit to Unit orientated effects, good if you want such a behaviour, but nasty if you don't want it.

Mine does not support Buffs at all resulting in a easier creation of not Unique Effects/not Unit-Unit orientated effects and allows to stack them as seperated instances.

 

[Devalut]

Is it possible to return to a previous delayed action and increase or decrease it's effects?

Like taking stormhammer and simply increasing the damage and furthering the delay before it strikes instead of stacking it?

 

[Tasyen]

It is possible to manipulate any Data, including time and the Action-Trigger itself, of running Delayed Actions from outside of the Action-Trigger, but there is no easy function. You have to directly manipulate the data inside the Array, at the Position inside the Table which a DA_Pointer points to.
For Stormhammer do it that way:
First you have to change the Storm-Action Trigger, to support Custom Data.

• stormhammer
  • Events
  • Conditions
    • (DA__Action_Target is alive)
  • Actions
    • Spezialeffekt - Create a special effect attached to the origin of DA__Action_Target using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
    • Spezialeffekt - Destroy (Last created special effect)
    • Unit - Cause DA__Action_Source to damage DA__Action_Target, dealing (50.00 + DA__Action_Real) damage of attack type Spell and damage type Magic

Second you need to change the Stormhammer Trigger.
I assumed For each Stormhammer user an own Action will be used.

• Stormhammer attack powerup
  • Events
    • Unit - A unit was attacked
  • Conditions
    • (Level of Sturmhammer for (Attacking unit)) Unequal 0
  • Actions
    • -------- Check if this allready Exists --------
    • For each (Integer A) from DA_First to DA_Last, do (Actions)
      • Schleifen - Aktionen
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • IF - Conditions
            • DA_Sources[DA_Pointer[(Integer A)]] Equal (Attacking unit)
            • DA_Targets[DA_Pointer[(Integer A)]] Equal (Attacked unit)
            • DA_Trigger[DA_Pointer[(Integer A)]] Equal stormhammer <gen>
          • Then - Actions
            • Set DA_Remainig_Dur[DA_Pointer[(Integer A)]] = 3.00
            • Set DA_Data2[DA_Pointer[(Integer A)]] = (DA_Data2[DA_Pointer[(Integer A)]] + 50.00)
            • Skip remaining actions
          • Else - Actions
    • -------- If not was hit, Continue with normal --------
    • -------- Delay in Seconds --------
    • Set DA___P_Delay = 3.00
    • -------- Units --------
    • Set DA___P_Source = (Attacking unit)
    • Set DA___P_Target = (Attacked unit)
    • -------- Effect beeing Called --------
    • Set DA___P_Trigger = stormhammer <gen>
    • -------- Grafical Indikator --------
    • Spezialeffekt - Create a special effect attached to the chest of DA___P_Target using Abilities\Weapons\FarseerMissile\FarseerMissile.mdl
    • Set DA___P_Grafic = (Last created special effect)
    • -------- Create/Start DE --------
    • Trigger - Run Delayed Action add <gen> (ignoring conditions)

Edit: Be aware that Running Delayed Actions-Data-Array have to be accessed over a DA_Pointer outside a Action-trigger.

 

[Devalut]

I'm getting some issues with a delayed action it seems almost random
sometimes the unit stops taking damage all together despite graphic effect remaining (which I took out)
The reload duration starts getting faster and faster

Spoiler

• Venom Attack Copy
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Level of Venom for (Attacking unit)) Not equal to 0
  • Actions
    • For each (Integer A) from DA_First to DA_Last, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DA_Sources[DA_Pointer[(Integer A)]] Equal to (Attacking unit)
            • DA_Targets[DA_Pointer[(Integer A)]] Equal to (Attacked unit)
            • DA_Trigger[DA_Pointer[(Integer A)]] Equal to Venom <gen>
          • Then - Actions
            • Set DA_ReLoad_Dur[DA_Pointer[(Integer A)]] = 1.00
            • Set DA_ReLoads[DA_Pointer[(Integer A)]] = 8
            • Set DA_Data[DA_Pointer[(Integer A)]] = (Level of Venom for (Attacking unit))
            • Skip remaining actions
          • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
      • Then - Actions
        • Set DA___P_Data = (Level of Venom for (Attacking unit))
        • Set DA___P_Delay = 0.05
        • Set DA___P_Reload_Dur = 1.00
        • Set DA___P_Reloads = 8
        • Set DA___P_Source = (Attacking unit)
        • Set DA___P_Target = (Attacked unit)
        • Set DA___P_Trigger = Venom <gen>
        • Trigger - Run Delayed Action add <gen> (ignoring conditions)
      • Else - Actions

• Venom
  • Events
  • Conditions
    • (DA__Action_Target is alive) Equal to True
    • (DA__Action_Target has buff Venom ) Equal to True
  • Actions
    • Unit - Cause DA__Action_Source to damage DA__Action_Target, dealing ((4.00 x (Real((Level of Venom for DA__Action_Source)))) + (((Max life of DA__Action_Target) - (Life of DA__Action_Target)) x ((0.04 + (0.01 x (Real((Level of Venom for DA__Action_Source))))) / 4.00))) damage of attack type Spells and damage type Magic
    • Special Effect - Create a special effect attached to the chest of DA__Action_Target using Abilities\Spells\Undead\DeathandDecay\DeathandDecayDamage.mdl
    • Special Effect - Destroy (Last created special effect)

Edit

Thanks works perfect now, lovely system

 

[Tasyen]

Which Version of Delayed Action you use?
Stands at the First Line of Docu.

Edit: If it is not Version 1.4a I Recomment updating.
After Rereading your Comment, comparing it with my Memory (Bugs in Version 1.4) and finding no Logical error in your posted Trigger, i'm sure you use Version 1.4 which has a critical system Bug.

Advice: Following is no error but unneeded

• A Delay equal or below the Systems Intervall has no need to be set, default 0.05.
• The Reload Duration Resetting is not needed.

 

[Tank-Commander]

Thanks for the submission, not much to say about changes needed on this one the code seems generally clean and fine
Your indexing method is rather convoluted, it could be simplified into this form of linked list [Trigger] - Why dynamic indexing is flawed and people should use linked list instead rather than the one your using right now (will reduce allocation and recycling lines) though I'll note that in the example Spell_Last can be substituted with Spell_Prev[0]. This is the only thing that needs to be changed that I can see for now

Also can you use a longer prefix? (3-4 characters minimum) it's a relatively new regulation we're using, it won't stop it from being approved but it'll better help avoid system/spell collisions
It'd be helpful it you could come up with a specific list of reason why people should use this over the more advanced equivalents (simpler but easier to use, that kind of thing) just to make judgement on this one more clear

 

[Tasyen]

Thanks for your Feedback.
I updated the Prefix, right now.

Edit: Dynamic Pointer -> Linked list Data access is done.

Added "Why use Delayed Action" in Description.​

 

[Tank-Commander]

As I mentioned before Spell_Last can be replaced with Spell_Prev[0], this will always reference the last node without the need of another variable to identify it or in this case DelayA_Link_Previous[0] can replace Set DelayA_Last (and then you can get rid of the IF statement for it in the recycling and the "Set DelayA_Last = DelayA_Index_Entered" line, as an aside I'm not sure what "Reduces Connections inside the Action code from 1 <> n -> 1 <> 1." means in your description - at any rate I'll discuss the merits of the system over the other similar ones with KILLCIDE, from a code perspective this is approvable now and probably will be in a little bit

Edit: It's a decent GUI-Friendly equivalent for some of the more advanced systems we have on the hive, containing the core features without excess could also be considered a plus, approved
You could make it so you can place effects on both the source and target at the same time

 

[Devalut]

Does the edit to the stormhammer still work?

Spoiler

• Stormhammer attack
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Level of Storm Hammers for (Attacking unit)) Not equal to 0
  • Actions
    • For each (Integer A) from DelayA_First to DelayA_Last, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DelayA_Sources[DelayA_Pointer[(Integer A)]] Equal to (Attacking unit)
            • DelayA_Targets[DelayA_Pointer[(Integer A)]] Equal to (Attacked unit)
            • DelayA_Trigger[DelayA_Pointer[(Integer A)]] Equal to stormhammer <gen>
          • Then - Actions
            • Set DelayA_Remainig_Dur[DelayA_Pointer[(Integer A)]] = 3.00
            • Set DelayA_Data2[DelayA_Pointer[(Integer A)]] = (DelayA_Data2[DelayA_Pointer[(Integer A)]] + 50.00)
            • Skip remaining actions
          • Else - Actions
            • -------- Delay in Seconds --------
            • Set DelayA___P_Delay = 3.00
            • -------- Units --------
            • Set DelayA___P_Source = (Attacking unit)
            • Set DelayA___P_Target = (Attacked unit)
            • -------- Effect beeing Called --------
            • Set DelayA___P_Trigger = stormhammer <gen>
            • -------- Grafical Indikator --------
            • Special Effect - Create a special effect attached to the chest of DelayA___P_Target using Abilities\Weapons\FarseerMissile\FarseerMissile.mdl
            • Set DelayA___P_Grafic = (Last created special effect)
            • -------- Create/Start DE --------
            • Trigger - Run DelayA_CONS_CREATE (ignoring conditions)

As well as the addition to the ending trigger of delayA_Action_Real + 50.00

 

[Tasyen]

The Delayed Action-Trigger don't have to be changed from what i said last time.
The Stormhammer Attack has to be changed to this:
Cause of the Change of Data Access.

This way.

• Stormhammer attack
  • Events
    • Unit - Unit is attacked
  • Conditions
    • (Level of Sturmhammer for (Attacking unit)) not equal 0
  • Actions
    • Set DelayA_Index = 0
    • For each (Integer A) from 1 to DelayA_Count, do (Actions)
      • Schleifen - Aktionen
        • Set DelayA_Index = DelayA_Link_Next[DelayA_Index]
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DelayA_Sources[DelayA_Index] Equal (Attacking unit)
            • DelayA_Targets[DelayA_Index] Equal (Attacked unit)
            • DelayA_Trigger[DelayA_Index] Equal Stormhammer dmg <gen>
          • Then - Actions
            • Set DelayA_Remainig_Dur[DelayA_Index] = 3.00
            • Set DelayA_Data2[DelayA_Index] = (DelayA_Data2[DelayA_Index] + 50.00)
            • Skip remaining actions
          • Else - Actions
    • -------- Delay in Seconds --------
    • Set DelayA___P_Delay = 3.00
    • -------- Units --------
    • Set DelayA___P_Source = (Attacking unit)
    • Set DelayA___P_Target = (Attacked unit)
    • -------- Effect beeing Called --------
    • Set DelayA___P_Trigger = Stormhammer dmg <gen>
    • -------- Grafical Indikator --------
    • Spezialeffekt - Create a special effect attached to the chest of DelayA___P_Target using Abilities\Weapons\FarseerMissile\FarseerMissile.mdl
    • Set DelayA___P_Grafic = (Last created special effect)
    • -------- Create/Start DE --------
    • Trigger - Run DelayA_CONS_CREATE (ignoring conditions)

 

[Devalut]

Danke, Gotta say I really love this system

 

[jonbon29]

Looks really handy for me Thanks!

 

[Devalut]

I have this Poison trigger that activates when I unit dies, the intended effect is to make it last 4 seconds longer to all units afflicted with the Poison, however the damage immediately stops when the unit dies and the graphic remains.

Am I doing something wrong?

Spoiler

• DOT unit Death
  • Events
    • Unit - A unit Dies
  • Conditions
    • LF_Boolean[(Custom value of (Dying unit))] Equal to True
  • Actions
    • -------- Heal and show healing Grafic --------
    • Set TempPoint = (Position of (Dying unit))
    • Set TempGroup = (Units within 450.00 of TempPoint)
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) is A structure) Equal to False
            • ((Picked unit) is dead) Equal to False
            • ((Picked unit) belongs to an enemy of (Owner of LF_Caster[(Custom value of (Dying unit))])) Equal to True
            • LF_Boolean[(Custom value of (Picked unit))] Equal to True
          • Then - Actions
            • Set DelayA_Index = 0
            • For each (Integer A) from 1 to DelayA_Count, do (Actions)
              • Loop - Actions
                • Set DelayA_Index = DelayA_Link_Next[DelayA_Index]
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • DelayA_Targets[DelayA_Index] Equal to (Picked unit)
                    • DelayA_Sources[DelayA_Index] Equal to LF_Caster[(Custom value of (Dying unit))]
                    • DelayA_Trigger[DelayA_Index] Equal to DOT damage <gen>
                  • Then - Actions
                    • Set DelayA_ReLoads[DelayA_Index] = (DelayA_ReLoads[DelayA_Index] + 4)
                  • Else - Actions
          • Else - Actions
    • Custom script: call RemoveLocation(udg_TempPoint)
    • Custom script: call DestroyGroup(udg_TempGroup)

 

[Tasyen]

This can seen as a bugg of the system.
Its not safe to write onto "DelayA_Index" when this trigger is the consequence/result of an delayed Action dealing damage.
Delayed Action uses DelayA_Index to loop all active actions, if it is written while it is used to loop it will cause wierd behavoiur.

 

[Devalut]

Is there a better way to get that result?

 

[Tasyen]

Depending on how many delayed Actions are inside your map, it might be better to only once loop the Delayed Action, one could still do the same behaviour without saving data for units by using an group variable and ask if the current tested target of delayed Action is inside the group.

Hidden

• Stormhammer Boost
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions
    • Set loc = (Position of (Triggering unit))
    • Set Group = (Units within 512.00 of loc)
    • Unit Group - Pick every unit in Group and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • ((Picked unit) is A structure) Equal to True
                • ((Picked unit) is dead) Equal to True
                • ((Picked unit) belongs to an ally of Player 1 (Red)) Equal to True
          • Then - Actions
            • -------- Remove Unwanted Unit, which is Building, dead or ally of Player Red --------
            • Unit Group - Remove (Picked unit) from Group
          • Else - Actions
    • -------- Use an independent variable and Loop the Delayed Action Loop, Don't use DelayA_Index to prevent errors --------
    • Set Index = 0
    • For each (Integer A) from 1 to DelayA_Count, do (Actions)
      • Loop - Actions
        • Set Index = DelayA_Link_Next[Index]
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DelayA_Trigger[Index] Equal to stormhammer <gen>
            • (DelayA_Targets[Index] is in Group) Equal to True
          • Then - Actions
            • Set DelayA_ReLoads[Index] = (DelayA_ReLoads[Index] + 1)
          • Else - Actions
    • Custom script: call DestroyGroup(udg_Group)
    • Custom script: call RemoveLocation(udg_loc)

 

[Devalut]

Wonderful!
The system has been a real treat to use!

 

[Tipou]

One of the most useful library I got to use while mapmaking!

 

[P3in]

Hi, is this still ok for today patches?

 

[Pyrogasm]

Probably. It’s post-1.24b so no return bug fuckery to worry about. Try it and see.

 

[Bribe]

Hi, is this still ok for today patches?

I would recommend GUI Spell System, or Lua's PreciseWait if you can successfully switch your map to Lua.

 

[P3in]

Oh..damn, forgot i can do that with Spell System, i am using it for some spells, but forgot about the wait it come's with

Thanks for reminding!

I would recommend GUI Spell System, or Lua's PreciseWait if you can successfully switch your map to Lua.