Death Stomp V1.4

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Death Stomp V1.2 | Reviewed by Maker | 29th Sep 2013

NEEDS FIX

There is a location leak You are setting/removing the same location may times The caster should deal the damage, not the dummies You could limit the number of units created by making the projectile unit cast the War Stomp ability The unit dies trigger should be turned off when it is not needed You could use variables for the unit types and abilities

[tr]

 

[FUJI]

Post triggers anyway I have WE so that I'll download it to review....

This is NOT needed a hashtable BECAUSE it is INSTANT SPELL. Too Simple Spell, It is like all are made with OE. Store triggering unit into the variable. You not needed dummy unit removal trigger. Your trigger is inefficient. Users do not need gameplay text message in angles so it must remove. Use your own integer variable in the integer loop. Must have configuration. You must store it to the variable all that you used twice 1.8/5 ( Nice Idea )
and vote for Needs Fix

EDIT:
MUST NEEDED IMPORT INSTRUCTION tho that you created soo many dummy ability and dummy units in this spell.
Rating Changed:
1.5/5 ( Nice Idea )

 

[Destination9747]

Post triggers anyway I have WE so that I'll download it to review....

This is NOT needed a hashtable BECAUSE it is INSTANT SPELL. Too Simple Spell, It is like all are made with OE. Store triggering unit into the variable. You not needed dummy unit removal trigger. Your trigger is inefficient. Users do not need gameplay text message in angles so it must remove. Use your own integer variable in the integer loop. Must have configuration. You must store it to the variable all that you used twice 1.8/5 ( Nice Idea )
and vote for Needs Fix

EDIT:
MUST NEEDED IMPORT INSTRUCTION tho that you created soo many dummy ability and dummy units in this spell.
Rating Changed:
1.5/5 ( Nice Idea )

Thanks for commenting i forgot to remove the text message, i will update it soon as possible. and again thanks

Edit: I added more creativity to the spell... increased stunning duration per level, damage and also number of orbs

 

[Rheiko]

-Unit - Create 1 Dummy Mover for (Owner of (Triggering unit)) at DeathStomp_PointDummy facing DeathStomp_Angle degrees
change owner of triggering unit => owner of DeathStomp_Caster or triggering player
-Set DeathStomp_PointDummy = ((Position of (Last created unit)) offset by 500.00 towards DeathStomp_Angle degrees)
store the (Position of (Last created unit) into a variable first
-Set DeathStomp_PointDummy = (Position of (Triggering unit))
position of DeathStomp_Dummy

i suggest you make this configurable

 

[FUJI]

Store last create unit in the variable. Use your own integer variable like this:

• For each (Integer MyOwnIntegerVariable) from 1 to 10, do (Actions)
  • Loop - Actions

Store owner of triggering unit into the unit variable.

Death_Stomp_Count must be below in the Death_Stomp_Level so that you can use this:

• Set Death_Stomp_Count = ( Death_Stomp_Level x 3 )

It must have configuration trigger ^^!

• Set DeathStomp_Dummy = (Triggering unit)
• Set DeathStomp_PointDummy = (Position of (Triggering unit))
• -------- It is must be like this: --------
• Set DeathStomp_Dummy = (Triggering unit)
• Set DeathStomp_PointDummy = (Position of DeathStomp_Dummy)

EDIT: Rating Changed ( Due to Update )

2.5/5
Still Needs Fix

 

[Maker]

-You have a location leak in there
-Under no circumstance can a spell edit a units custom value. Only unit indexer systems are allowed to edit custom values

 

[Ofel]

QUICK REVIEW|Death Stomp|v1.1

Resource Status: Needs Fix Rating: 2/5

GENERAL	After creating Dummy Mover, store it in a variable and use that variable Store (Position of (Last created unit)) in a variable and use it Make the effect and something like that to be configurable in another trigger Store the owner of the caster and use it in the cast trigger Use custom integer instead of using Integer A on looping actions
PROS	MUI Support levels
CONS	Changing unit custom values without using Unit Indexer system Have leaks Inefficient
SUGGESTIONS	Read this Store everything that you used twice or more, like (Triggering unit) and (Last created unit)

[/TD][/tr] If you have any question about this review, PM or VM me Review template by Doomlord

Edit
Rating changed... ^^
Cuz i think someone will angry...

Review updated

 

[Maker]

Setting this to Needs Fix. The locations are not removed correctly.
The color setting thing should be removed. You could store the values into a hashtable or something, a long if/then/else is not cool. Use variables or the abilities and unit types.