Death Grip 1.06b | Reviewed by Maker | 23rd Jul 2013
APPROVED
A useful spell Instead of destroying/recreating the effect, don't destroy the effect and don't create an new one Don't set temp point in the looping trigger if you don't need it You don't need four point variables for the spell, only two Create the hashtable in DG Configuration and delete Create HashGrip The ability is missing disabled version of the icon

[tr]

Old reviews Death Grip (Hero Ability) 1.05a | Reviewed by Maker | 30th Jun 2013 NEEDS FIX You leak the offset point when you move a unit You set a point and instantly remove it in the looping trigger without doing anything with the point Don't set variables if you don't need them, in the looping Store the damage in the cast trigger trigger [tr] [/tr]

[/tr]

 

Any bugs, leaks, improvement tips and any kind of feedback is very welcome...

 

I love it *_*

 

-It is not MUI, if you cast the spell on the same unit, the effect leaks and stays there forever
-You leak a location in the looping trigger
-Turn the trigger off when the unit group is empty, don't turn it on in the looping trigger

 

I want vJASS
If you can [

+ REPT

 

to learn how to do MUI u can use the method i use called indexed arrays. check out my tutorial things a GUIer should know. the chapter called how to index.

 

Thank you, but I'm not the first to make one, I just made a version with three levels for myself, to use as a hero ability (not ultimate)...

It may be a bit (or a lot) different from the WoW death grip, but I think it will suffice...

-The effect does not leak anymore
-Moved the custom script down to remove the location after moving the unit and then set the second location to be removed as well (if it is wrong, tell me)
-Now the loop trigger turns off when unit group is empty

Let me know if I'm missing something yet...

Thank you...

Sorry, I'm a GUI user, I have not yet learned vJass ;P

But thanks anyway

Whoa, I just readed your post after the 1.03 update, but thanks anyway...
I know the indexing and I know that it is a lot easier to use (I'm talking about bribe's) arrays, but I just wanted to do it the hard way ;P

Thank you, I'll read your tutorial now (or maybe later, you know, its 1:05 am here )

 

-Only check if the group is empty when removing a unit from it
-You don't need a variable for the special effect, Destroy load 3... and you can save last created special effect
-The proper way to destroy the effect is first to check if it exists, Boolean - Hashtable value exists. 3 is saved as a handle

 

Changes made... Thank you...

 

this isnt needed.

• Set DGTempPoint = (Position of DGTempUnit)
• Custom script: call RemoveLocation(udg_DGTempPoint)

this leaks change it to the variable u set right above it.

• Unit - Move DGTempUnit instantly to ((Position of DGTempUnit) offset by DG_CurrentDist towards DG_Angle degrees)

 

Whoa, I haven't noticed that... I'll change it... Thank you...

 

np lol

 

Replaced

 

Set DGTempPoint = (Position of DGTempUnit)
Unit - Move DGTempUnit instantly to (DGTempPoint offset by DG_CurrentDist towards DG_Angle degrees)


Here you need to set another point for the polar offset, because this leaks

 

That position is destroyed with each loop, as the position of the unit (the point you are speaking of) is set before the movement and is destroyed with each loop (every 0.03 seconds) . I think the leak in this point does not exists, but thanks anyway...

 

no he is correct. this specifically leaks.

• (DGTempPoint offset by DG_CurrentDist towards DG_Angle degrees)

whenever u offset it creates a new point/location which leaks.

 

At first I removed both locations inside the loop, and that was like removing the same location twice (the first time being as the offset location and the second time as the first location), them you came and said it was not necessary, that made sense to me, since the unit location was removed with each loop.

Now what would really make sense is to remove the position of the unit in the "Else" actions of the loop...

As I see now, I am removing the current position/location of the unit and, as that action creates a second location (the offset location), that second location is removed when the trigger "loops" and, when the spell is done, the final location is removed too.

But as I am learning how to make spells, I may be wrong tough... Let me now if I am (or if you did not understand what I said above)

 

ur storing picked unit in the wrong way.

change this

• DG Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in DG_Group and do (Actions)
      • Loop - Actions
        • -------- Load values from the Hashtable --------
        • Set DG_Angle = (Load 0 of (Key (Picked unit)) from HashGrip)
        • Set DG_CurrentDist = (Load 1 of (Key (Picked unit)) from HashGrip)
        • Set DG_Timer = (Load 2 of (Key (Picked unit)) from HashGrip)
        • Set DG_Life = (Load 4 of (Key (Picked unit)) from HashGrip)
        • -------- ----------------------- --------
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DG_Timer Greater than 0.00
            • (Life of DG_Caster) Greater than 0.00
          • Then - Actions
            • -------- Moving unit --------
            • Set DGTempUnit = (Picked unit)
            • Set DGTempPoint = (Position of DGTempUnit)
            • Unit - Move DGTempUnit instantly to (DGTempPoint offset by DG_CurrentDist towards DG_Angle degrees)
            • Custom script: call RemoveLocation(udg_DGTempPoint)
            • -------- Decrease Timer for the movement of the unit --------
            • Hashtable - Save (DG_Timer - 0.03) as 2 of (Key (Picked unit)) in HashGrip
            • -------- Apply the damage on the unit --------
            • Unit - Set life of DGTempUnit to ((Life of DGTempUnit) - ((DG_Life x DG_Damage[(Level of Death Grip for DG_Caster)]) / (DG_CastingTime / 0.03)))
          • Else - Actions
            • -------- When the spell is done, clear the values... --------
            • Set DGTempPoint = (Position of (Picked unit))
            • Custom script: call RemoveLocation(udg_DGTempPoint)
            • Set DG_Target_Effect = (Load 3 of (Key (Picked unit)) in HashGrip)
            • Special Effect - Destroy DG_Target_Effect
            • Hashtable - Clear all child hashtables of child (Key (Picked unit)) in HashGrip
            • Unit Group - Remove (Picked unit) from DG_Group
            • -------- This actions checks if the unit group is empty and turns off the trigger if that case --------
            • If ((DG_Group is empty) Equal to True) then do (Trigger - Turn off (This trigger)) else do (-------- Do Nothing :) --------)

to this and change every picked unit to the temp unit variable

• DG Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in DG_Group and do (Actions)
      • Loop - Actions
        • Set DGTempUnit = (Picked unit)
        • Set DGTempPoint = (Position of DGTempUnit)
        • -------- Load values from the Hashtable --------
        • Set DG_Angle = (Load 0 of (Key (Picked unit)) from HashGrip)
        • Set DG_CurrentDist = (Load 1 of (Key (Picked unit)) from HashGrip)
        • Set DG_Timer = (Load 2 of (Key (Picked unit)) from HashGrip)
        • Set DG_Life = (Load 4 of (Key (Picked unit)) from HashGrip)
        • -------- ----------------------- --------
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • DG_Timer Greater than 0.00
            • (Life of DG_Caster) Greater than 0.00
          • Then - Actions
            • -------- Moving unit --------
            • -------- fix the line under this --------
            • Unit - Move DGTempUnit instantly to (DGTempPoint offset by DG_CurrentDist towards DG_Angle degrees)
            • -------- Decrease Timer for the movement of the unit --------
            • Hashtable - Save (DG_Timer - 0.03) as 2 of (Key (Picked unit)) in HashGrip
            • -------- Apply the damage on the unit --------
            • Unit - Set life of DGTempUnit to ((Life of DGTempUnit) - ((DG_Life x DG_Damage[(Level of Death Grip for DG_Caster)]) / (DG_CastingTime / 0.03)))
          • Else - Actions
            • -------- When the spell is done, clear the values... --------
            • Set DG_Target_Effect = (Load 3 of (Key (Picked unit)) in HashGrip)
            • Special Effect - Destroy DG_Target_Effect
            • Hashtable - Clear all child hashtables of child (Key (Picked unit)) in HashGrip
            • Unit Group - Remove (Picked unit) from DG_Group
            • -------- This actions checks if the unit group is empty and turns off the trigger if that case --------
            • If ((DG_Group is empty) Equal to True) then do (Trigger - Turn off (This trigger)) else do (-------- Do Nothing :) --------)
        • Custom script: call RemoveLocation(udg_DGTempPoint)

also use the variable u have set above these. and use that variable

• Hashtable - Save DG_Angle as 0 of (Key (Target unit of ability being cast)) in HashGrip
• Hashtable - Save DG_CurrentDist as 1 of (Key (Target unit of ability being cast)) in HashGrip
• Hashtable - Save DG_Timer as 2 of (Key (Target unit of ability being cast)) in HashGrip
• Hashtable - Save Handle Of(Last created special effect) as 3 of (Key (Target unit of ability being cast)) in HashGrip
• Hashtable - Save DG_Life as 4 of (Key (Target unit of ability being cast)) in HashGrip