Demon's Grip v0.2

[Moderator]

23:31, 30th Nov 2012
Magtheridon96: Approved.
This deserves a 4/5 because of your use of comments and the cleanliness of the code. The configuration is wonderful too.

There are tiny improvements that could be done here and there.
Check out Radamantus' last posts for more information.

 

[BUP]

Hmmm

 

[Almia]

Make the spell effect array.
[jass=] if UnitAddAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf') then
call UnitRemoveAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf')
endif[/code]
To this.
[jass=]if UnitAddAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf') and UnitRemoveAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf') then
endif[/code]

You dont need a script to pause a unit.
Use stun instead of pause,because pause is bad.
I suggest using an arc method will do.

 

[doomhammer99]

Make the spell effect array.
[jass=] if UnitAddAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf') then
call UnitRemoveAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf')
endif[/code]
To this.
[jass=]if UnitAddAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf') and UnitRemoveAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf') then
endif[/code]

You dont need a script to pause a unit.
Use stun instead of pause,because pause is bad.
I suggest using an arc method will do.

That ain't spell effect.
It's a Script for adding and removing Ability.

 

[BUP]

Yeah i was wondering too.....
But i feel like i shouldn't refuse to Pros

 

[doomhammer99]

Yeah you should do what Radamantus' just said

 

[Almia]

Uhmmm,you dont understand.
All of the suggestions above are differet.
The spell effect or SFX should be array instead of using so many variables.

 

[BUP]

The spell effect or SFX should be array instead of using so many variables.

I did what u said.Thanks!

 

[Almia]

I told you to fix this:

• :
  • Custom script:if UnitAddAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf') then
  • Custom script: call UnitRemoveAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf')
  • Custom script: endif

to this:

• Custom script:if UnitAddAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf') and UnitRemoveAbility(udg_DeGr_Target[udg_DeGr_Current_Index],'Amrf') then
• Custom script: endif

this trigger:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• DeGr_Angle[DeGr_Current_Index] Greater than or equal to 360.00
• Then - Actions
• -------- ------------------------------------------------------------ --------
• -------- Sets it back to 0 to make it smooth --------
• -------- ------------------------------------------------------------ --------
• Set DeGr_Angle[DeGr_Current_Index] = 0.00
• Else - Actions

Isnt needed,because the degrees are currently recycled automatically by the world editor.So if the angle is -90,then the world editor will recycle it then the result would be 270.

• -------- ------------------------------------------------------------ --------
• -------- Creates and Removes the [DeGr_Target_Effect_Model_1] on the attachment [DeGr_Target_Attachment_1] --------
• -------- ------------------------------------------------------------ --------
• Custom script: call DestroyEffect(AddSpecialEffectTarget(udg_DeGr_Target_Effect_Model[1], udg_DeGr_Target[udg_DeGr_Current_Index],udg_DeGr_Target_Attachment[1]))
• -------- ------------------------------------------------------------ --------
• -------- Creates and Removes the [DeGr_Target_Effect_Model_2] on the attachment [DeGr_Target_Attachment_2] --------
• -------- ------------------------------------------------------------ --------
• Custom script: call DestroyEffect(AddSpecialEffectTarget(udg_DeGr_Target_Effect_Model[2], udg_DeGr_Target[udg_DeGr_Current_Index],udg_DeGr_Target_Attachment[2]))

Put the actions on a integer loop,because you are using arrays.

Use an arc method so that it doesnt use any height reset

 

[hemmedo]

if it would be a channeling spell, would be much more logical but still nice