HyperStomp V0.2

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

13:18, 17th Jul 2012
Magtheridon96:

Comments

• You should use a loop when creating the special effects in both triggers.
• You're leaking locations because you aren't removing them with the RemoveLocation native.
• When you overwrite a location variable without destroying the location, you're leaking it.
• The wait is totally unneeded.

 

[kodok_rebus]

I apologize if there is a spell like this, because I have never seen such a spell over me join in hiveworkshop

 

[Tank-Commander]

All of those special effects could be in a loop reducing the amount of times you call that function in the script to once instead of a million times, (this applies for both the creation and removal of sfx) both of these are AOE Sfx spam spells with extremely simple functioning, basically warstomp with a bit of graphic overkill, I'd suggest trying something with a bit more dynamics to it other than this block damage warstomp also remove that wait, it makes the spell not Mui (graphically)

Edit: Oh 800th post

 

[kodok_rebus]

I used the wait to get in tune with the meteor.
if I remove the wait
so how can it be consistent with the meteor?
(im still noob at Spell because this my first spell)

 

[Magtheridon96]

A timer.
Waits are not accurate at all especially when you have low wait-times.
0.27 is the lowest wait-time possible with the normal Wc3 sleep function (Wait X.XX seconds).

Also, the wait function randomly adds 0.1, 0.125, 0.15, 0.175 or 0.2 seconds randomly to the wait time.

Timers are incredibly accurate.
You can get as low as 0.0001 seconds with them.

 

[eubz]

None_MUI.

 

[Almia]

Lotsa lotsa leaks

 

[zv27]

This reminds me of spells that were made before some 5-6 years.A bunch of special effects.

 

[Magtheridon96]

(Position of (Triggering unit)) leaks.

What this means is that whenever you're doing this, the computer is creating 0.3KB of memory and throwing it away, never to be destroyed every again throughout the game.

Yes, this sounds like a little, but when the memory leaks accumulate, you're going to have several hundreds of MBs that weren't cleared.

You're already storing the position of this the triggering unit in a variable in the first trigger, so instead of using (Position of (Triggering unit)), just use that StompLocation variable.

And instead of putting all the actions like that, you could do them in a loop.

Bad trigger

• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 360.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 330.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 300.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 270.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 240.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 210.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 180.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 150.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 120.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 90.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 60.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at ((Position of (Triggering unit)) offset by 360.00 towards 30.00 degrees) using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)

->

Fixed trigger

• Set Angle = 360
• For each (Integer A) from 1 to 12, do (Actions)
  • Loop - Actions
    • Special Effect - Create a special effect at StompLocation offset by 360.00 towards Angle degrees) using Units\Demon\Infernal\InfernalBirth.mdl
    • Special Effect - Destroy (Last created special effect)
    • Set Angle = (Angle - 30.00)

This is MUCH shorter.

 

[Shadowleaves]

Magtheridon, u also leak a location in polar projection

 

[Magtheridon96]

Right, I didn't notice that.

• Set TempLoc = (StompLocation offset by 360.00 towards Angle degrees)
• Special Effect - Create a special effect at TempLoc using Units\Demon\Infernal\InfernalBirth.mdl
• Special Effect - Destroy (Last created special effect)
• Custom script: call RemoveLocation(udg_TempLoc)

 

[Lazy R]

Obviously not MUI due to uses wait
It's better to use looping to make a simplier kind of spell
Also it depending on too much object spell

But well pretty good of spell from a first post

 

[Magtheridon96]

You can still make a spell MUI even while using waits.
It takes a bit of complexity.

• Example
  • Events
  • Conditions
  • Actions
    • Set BufferWriteIndex = BufferReadIndex + 1
    • Set myUnit[BufferWriteIndex] = GetTriggerUnit()
    • Wait 0.5 seconds
    • Set BufferReadIndex = BufferReadIndex + 1
    • // Use myUnit[BufferReadIndex] over here.
    • Custom script: if udg_BufferReadIndex == BufferWriteIndex then
    • Custom script: set udg_BufferReadIndex = 0
    • Custom script: set udg_BufferWriteIndex = 0
    • Custom script: endif

 

[TheFrozen]

To : kodok_rebus

Do you from Indonesia...?

 

[Magtheridon96]

I think it would be more appropriate to ask such questions on his profile.

 

[EyeCandy]

Thor is extremely disappointed!