Dark Wave v1.4

[Moderator]

18:03, 30th Jan 2015
Maker: The spell is a nice variant of a charge spell.
The effects are good but triggering could be improved a bit.
Not using move unit instantly action could give you more flexibility
and fluidity. Also consider using Channel as the base ability in the future.

 

[Map Designer]

is this not the same as warcraft swarm thing?

 

[Elprede]

There are at least 2 differences. The unit moves along with ability and knockbacks enemies.
I love the dash because it reminds me of a map that I enjoyed.

 

[GywGod133]

maybe you need to null the local h...

btw, please use INGAME Screenshot instead

 

[Vinz]

A little like Morphling's Waveform.

 

[JC Helas]

Update!!

 

[JC Helas]

Lol forget the knockback put action trigger stopper.

• If (All Condition are True) then do (Then Actions) else do ( Else Actions)
  • If - Conditions
    • (Knockback_Group is empty) Equal True
  • Then - Actions
    • Trigger - Turn off Knockback_Trigger
  • Else - Actions

 

[Kazeon]

• You don't need variable for these triggers
  
  • Set Dark_Wave_Triggers[1] = DW Cast <gen>
  • Set Dark_Wave_Triggers[2] = DW Loop <gen>
• These are not necessary to be done
  
  • Then - Actions
    • Custom script: set h = 0
    • Custom script: set udg_Dark_Wave_Ability_Level = 0
    • Custom script: set udg_Dark_Wave_Angle = 0.00
    • Custom script: set udg_Dark_Wave_Distance = 0.00
• This is not mandatory but using dynamic indexing is better. Consider this:
  
  • Hashtable - Save ((Load 1 of Dark_Wave_HandleID from Dark_Wave_Hash) - (Load 2 of Dark_Wave_HandleID from Dark_Wave_Hash)) as 1 of Dark_Wave_HandleID in Dark_Wave_Hash
  vs
  
  • set Distance[index] = Distance[index] - Speed[index]
• Try to load things only for once. This is one example:
  
  • Unit - Move Dark_Wave_Caster instantly to Dark_Wave_TempLoc2, facing (Load 0 of Dark_Wave_HandleID from Dark_Wave_Hash) degrees
  You have already loaded 0 (angle) from hashtable here:
  
  • Set Dark_Wave_TempLoc2 = (Dark_Wave_TempLoc1 offset by (Load 2 of Dark_Wave_HandleID from Dark_Wave_Hash) towards (Load 0 of Dark_Wave_HandleID from Dark_Wave_Hash) degrees)
  Try to avoid those.
• "Harvester" and "Tree" are way too generic for variable name and "KB" is too generic for a trigger name. Change those.
• You don't use TempLoc3 if the condition isn't met.
  
  • Unit Group - Pick every unit in Dark_Wave_Search_Target and do (Actions)
    • Loop - Actions
      • Set Dark_Wave_Knockback_Unit = (Picked unit)
      • Set Dark_Wave_TempLoc3 = (Position of Dark_Wave_Knockback_Unit)
      • ...
      • Custom script: call RemoveLocation(udg_Dark_Wave_TempLoc3)
• I think the damage better be done when caster collide with targets, not after they are KB'ed.
• You forgot to remove this group leak:
  
  • Set Dark_Wave_Search_Target = (Units within (Load 3 of Dark_Wave_HandleID from Dark_Wave_Hash) of Dark_Wave_TempLoc1)
• You don't need to remove TempLoc3 here:
  
  • Else - Actions
    • Unit - Turn collision for Dark_Wave_Caster On
    • Custom script: call RemoveLocation(udg_Dark_Wave_TempLoc1)
    • Custom script: call RemoveLocation(udg_Dark_Wave_TempLoc2)
    • Custom script: call RemoveLocation(udg_Dark_Wave_TempLoc3)
    • Unit Group - Remove Dark_Wave_Caster from Dark_Wave_CasterG
  And you can move
  
  • Custom script: call RemoveLocation(udg_Dark_Wave_TempLoc1)
  • Custom script: call RemoveLocation(udg_Dark_Wave_TempLoc2)
  after the ITE (if then else) block and remove the same actions inside the "Then - action" block.

Those are minor improvements aside from those variable & trigger names problem and a single unit group leak. And I didn't see any problem with Object Editor data.

 

[Maker]

• Unit group is empty -> trigger is off
• You remove the locations in THEN and ELSE. Take them out of the IF/THEN/ELSE
• Remove the else custom script, there is no code to execute there
• Flying units?
• No need for knockback location variables, use the dark wave location variables
• No need to set variables to 0 in the cast trigger

EDIT: Just noticed Dalvengyr's post. Fix those issues

 

[Tal'Rarity]

How did this get approved without an in-game screenshot?

 

[Maker]

You are right, didn't notice it is missing.

 

[JC Helas]

wew cant change the screenshot