Custom Script Crash

[Yours Truly]

Okay,I was doing something with Custom Scripts to make a custom build system.However,it crashes without any fatal error report.Here are the triggers that causes the crash:

• Triggers
  • Events
    • Unit - A unit Is issued an order targeting a point
  • Conditions
  • Actions
    • Custom script: if (GetIssuedOrderId() == 1747988529) then
    • Unit - Order BuildSys_Builder(Don't mind this variable.It works in real) to build a building at BuildSys_TempLoc[2](this as well)
    • Custom script: elseif (GetIssuedOrderId() == 1747988533) then
    • Set BuildingID = (Integer(h005))
    • Custom script: endif

Any help would be greatly appreciated.Thanks in advanced.

 

[PurgeandFire]

I don't know what order 1747988529 is, but chances are that you are producing an infinite loop. The trigger responds to the event "a unit is issued an order targeting a point", and you order him to do something targeting a point. If that order ID is equal to 1747988529, then it will just cycle infinitely.

The solution is to disable the trigger before the order and enable it after the order:

• Trigger - Disable Triggers <gen>
• Unit - Order BuildSys_Builder to build a building at BuildSys_TempLoc[2]
• Trigger - Enable Triggers <gen>

If it still crashes, then try to look at any other triggers that respond to order events (using the same logic as above).

 

[bear_369]

And by disable,you mean Turn Off and On?

Yes. Turn off the trigger when it starts and Turn on when it ends.

 

[Meatmuffin]

Why do you specifically want it to be done in custom script?

 

[bear_369]

Okay,another question.How do I make an or condition GUI custom script?

• Actions
  • Custom script: if (boolean) then
  • Custom script: return true
  • Custom script: endif
  • Custom script: if (boolean2) then
  • Custom script: return true
  • Custom script: endif

You can make "And" conditions in "Or" condition with the use of "Elseif"

Why do you specifically want it to be done in custom script?

He's probably isn't familiar with actual coding so he use the custom script if he wants to use something that cannot be done through "BJ_Actions"

 

[Gismo359]

Actions shouldnt return booleans. If you want an or condition just put an or between the conditions. Same thing goes for and

if Condition1 or Condition2 then
    ...
elseif Condition3 and Condition4 then
    ...
endif

 

[bear_369]

Actions shouldnt return booleans. If you want an or condition just put an or between the conditions. Same thing goes for and

if Condition1 or Condition2 then
    ...
elseif Condition3 and Condition4 then
    ...
endif

My bad
I didn't noticed the "or" at Jass.

 

[Meatmuffin]

You could store the order ID into an integer variable that you use -> null afterwards.