Cruelty v1.2

[Moderator]

8.36 PM, 20th Jun 2009
Eccho: Seems to be quite alright now. I don't know if it is a 4 or a 5 though, so, lets say it will be rounded up by hvo's rating

old

01:16 PM, 20th Jun 2009
Eccho: I don't know how I should illustrate it well enough, but this is still not working, just like it wasn't in the contest D:

There is clearly some issues in your looping trigger as it only works mui for player red but not for any other player. Beware, set bj_wantDestroyGroup tend to not work in small interval loops. I can't explain it, only you can verify it yourself by adding a blue hero and share the control, and order it to cast.

Further notes, it would have been better if you use carrion swarm instead of basing it on shockwave, because shockwave tend to lag the game up sometimes due to the terrain height changing specifically where it is moving.

17:27, 18th Jun 2009
hvo-busterkomo:

Review

A nice effect, although I think Carrion Swarm would've looked better than shockwave.
It leaks leak free and MUI, and no one has said otherwise. Approved with a 5/5 rating.

 

[Deuterium]

Before I start reading the triggers, you need to adjust the unit's abilities in the object editor, as the hero has a wrong ability...

And the spell is laggy...

 

[Squiggy]

Crap, exactly.. I fixed that one now.. was due to a false ability which I had to exchange.

To lessen the (possible) lag, increase the missilespeed - will look fine either, just not so bloomy

 

[Deuterium]

• CTpre
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set CT_temppt = (Position of CT_dummy2 0126 <gen>)
    • Unit - Add Cruelty to CT_dummy2 0126 <gen>
    • Unit - Order CT_dummy2 0126 <gen> to Neutral Dark Ranger - Silence CT_temppt
    • Unit - Add a 0.20 second Generic expiration timer to CT_dummy2 0126 <gen>
    • Custom script: call RemoveLocation(udg_CT_temppt)

Instead of placing a unit in your map, create the dummy you use in your spell and then do all the preload and remove it and remove the point leak...

Why do you use custom values? Can't you use a variable instead?

 

[Squiggy]

• Custom script: call RemoveLocation(udg_CT_temppt)

I'm pretty sure that the point leak is already removed.

Also for the CV, they're independant and accessible whenever I need them.
Plus they can serve as quite anything which needs a value (size, flying height, damage etc etc.)

 

[Deuterium]

Ohh sorry you misunderstood me, or to be more realistic, I wasn't clear... when I said remove the leak i was just counting out the preload steps and not saying you didn't remove the leaks

And yes now I understand the whole CV issue. Since they're independent dummies then there wouldn't be any other spell using that specific CV, so there's no prob using it... right?

 

[aaron]

if there is lag there is leaks so there must be a hidden one somewhere

 

[Squiggy]

And yes now I understand the whole CV issue. Since they're independent dummies then there wouldn't be any other spell using that specific CV, so there's no prob using it... right?

Exactly, since the spell applies the cv only to the dummies which are used by the spell (if any) and thus, no other unit's CV gets changed/removed/nulled/whatever.

if there is lag there is leaks so there must be a hidden one somewhere

noez, all leaks are dealt with.
The lag occurs when too many sfx are 'active', means if you expierience the lag, increase the missile speed to get rid of the high amount

 

[Rmx]

if there is lag there is leaks so there must be a hidden one somewhere

Who told you that ?

Anyway Custom values are better not to be used, they may have a chance to Damage something, but indexing is more safer, tought i don't really care

 

[f0rsAk3n]

ooooooh shiiiinnnnyyyyyyy.

lol seems leakless,mui and really usefull.

4/5 for meh.

 

[baassee]

preload effects ...

in the end you destroy your trigger also use this line in the prelaod trigger

• Custom script: call PreloadStart()

Learned by Kingz

 

[Deuterium]

if there is lag there is leaks so there must be a hidden one somewhere

Leaks lead to lagging later in the game for the memory would be jammed with memory and there's barely any space for the new information...
This wouldn't happen in a advance computer prepared for gaming, but would definetly happen on some of those old computers during long games

So leaking does not lead to lag if you're testing the spell for like 5 minutes


EDIT:

preload effects ...

in the end you destroy your trigger also use this line in the prelaod trigger

• Custom script: call PreloadStart()

Learned by Kingz

There already is a preload option in GUI to preload special effects too 8)

• Game - Preload BLABLA

 

[Kingz]

I can only suggest making this more user friendly.
When i say that i mean that you should add variables for those effects you are using so the users could with ease change the look of the spell
No complains about this spell, the spell looks fine.
EDIT:
The thing that is causing the fps drop is the number of dummies spawned

 

[Squiggy]

Meh there's still something wrong with it, the dummies are supposed to stay on the map for .2 seconds, which is correct - therefore the maximum amount of dummies is five which shouldn't affect the gameplay.
Well it doesn't have a dropdown of fps for me (only from 64 to 59), in any case I'm going to rework it a bit

 

[Kingz]

Try adding this trigger:

• Dummy Removal
  • Events
    • Unit - A unit Dies
  • Conditions
    • Multiple ConditionsOr - Any (Conditions) are true
      • Conditions
        • (Unit-type of (Triggering unit)) Equal to (==) CT_dummy
        • (Unit-type of (Triggering unit)) Equal to (==) CT_dummy2
  • Actions
    • Unit - Remove (Triggering unit) from the game

I don't know if you know but when a unit dies it stays in the game for ~2-3 seconds.
Removing them instantly is always better than killing a dummy unit.
This should improve any fps drop.

 

[Eccho]

Have you ever thought of that using the preload function is pointless unless you know exactly what it does. (told by me from Hanky). He started using it, but guess what, he used it wrong and it did nothing

 

[Kingz]

I always use preload like this:

call Preload(*effect string*)
call PreloadStart()

For abilities i create a dummy, add the ability and remove the unit.
Don't know if this is wrong but it never lags my spell for the first time
I also heard that some people create a special effect and destroy it and that makes a preload?
I say use the built in preload functions...

 

[Eccho]

As far as I recall it, strings doesnt need to be preloaded
Lag spikes are given by handles, thus, abilities and units, and even special effects I guess, once they're created/used for the first time.

 

[Deuterium]

Kingz, if PreloadStart iisn't used, it doesn't work?
I mean isn't the call Preload () supposed to preload directly once called?


EDIT:

As far as I recall it, strings doesnt need to be preloaded

The string is the file path to the special effect so that the function can find the file to preload... 8)

 

[Eccho]

Sure, nevertheless it usually goes fast enough without a nimble.

 

[Kingz]

Uhm, preloading effects uses their string(model)...
So the effect's model is preloaded
And i really don't know if the Preload Start is necesary, but it can't harm to be sure that the file will get preloaded
Maybe it's needed if the preload has ended but you want a new file to be preloaded?
Confusing, strange how there is no tutorial about preloading...

 

[Deuterium]

Well Kingz... maybe I'll do it after I'm done with exams No I'm serious

 

[Squiggy]

Huh?

 

[Kingz]

We gone too much offtopic...
We got Squiggy confused

 

[I3lackAce]

?

 

[calex3]

wow i like effects....and spell is too good...MUI, leakless.....amazing

 

[breebree123]

hey squig, was this the spell you were working on?

 

[Squiggy]

Yes, it was ^^

 

[The_Grapist]

This spell is great i check it an it works flawless...
Very nice...
5/5...

You deserved it!

 

[breebree123]

lol. .ok ^^

 

[Squiggy]

//Update - v1.2 is out