Comradeship v1.03 [Deuterium]

[Moderator]

22:50, 6th Jun 2009
hvo-busterkomo: A fairly advanced GUI spell. The scripting and effect both look fine, approved.

 

[Deuterium]

This is the first time I ever make a spell MUI using anything other than Local Variables, so there might be mistakes considering that.

@ Rmx:
My test-map beats you new one! (btw Credits to LebaneseSoul who worked on the terrain of our original map from which I took the test-map)

@ Septimus:
See, a creative, original and simple spell!
And don't start bugging me with submission rules

EDIT: Spell slightly lags! I'm gonna fix that whenever possible as I mentioned...

 

[Dark_Dragon]

i checked the spell and i can say i am very impressed on how fast did you learn so much!
spell idea is really good and test map is awesome, very creative from u!

spell by itself seems leakless, MUI, GUI and usefull.
the only thing which is currently my problem, is that i dont have too fast computer so i have a little lag but only little xD

anyway from when i remember u where total beginner and from now what i can see: is i cant beleve u became so good, but wait ur a new one Deuterium now xD

all in all once again: spell seems to be MUI, leakless, bugfree, usefull, good documented and ofc idea alone is quite good + coding is impressive since you learned this all in a short amount of time.

i can see you will not currently have some time to work on spells but thats ofc understandable, make sure to study for school first if u have exams xD

well it would be 4/5 for now and +rep for great work!

Greets!
~Dark Dragon

 

[hell gate]

a great spell 5/5. nice effects, easy to understand...
but plz add a variable to change the number of the picked units.

 

[Deuterium]

the only thing which is currently my problem, is that i dont have too fast computer so i have a little lag but only little xD

Yeah i forgot to mention the slight lag but i mentioned the method of fixing it in the "To be fixed in future versions"
thanks for the review!

a great spell 5/5. nice effects, easy to understand...
but plz add a variable to change the number of the picked units.

What picked units!? I don't use groups in all the triggers

 

[aaron]

impressive.

 

[Aspard]

Wow! Very impressive! Really creative and unique! Seems that there are a bit many special effects, cause after second casting I had some lags. (But only after the second ) But it's really brilliant! I think, you deserved 5/5 now!

What picked units!? I don't use groups in all the triggers

He means, if you can add a possibility to target more than one comrade to organise this commune

 

[Deuterium]

Yeah the first second is very laggy because I didn't preload anything...

 

[Rmx]

Downloading WOHOOO !!!

 

[Deuterium]

He means, if you can add a possibility to target more than one comrade to organise this commune

I understand now... I'll have to think about that

 

[Rmx]

Review

REVIEW RULES

Rating System :

0 - 15 = Shame on U
16 - 25 = Unacceptable
26 - 35 = Lacking
36 - 45 = Useful
46 - 55 = Recommended - Highly Recommended
56 - 60 = Directors Cut

Recommended to read the How to improve on every review.

Review

Idea and Creativity - 10/10.
Spell Description and In game Balance - 9/10.
Triggering and Scripting - 6/10.
Special effects *Eye Candy* - 7/10.
User Friendly *Documentation* - 9/10.
Efficiency - 7/10.

Is it Multi Instanceable - [YES].

Final Rating - [48].

Status - ***Highly Recommended***.

How to improve

Well you leak 3 Point every 0.20 seconds the three points are

• [ CO_CenterLoc ext.. -- CO_trigUnitLoc -- CO_TargUnitLoc ]

Fix them and make it more efficient like not spamming this blue special effect make it like two Axes spinning around the location and fire on them it will be much more Lovely ...anyway fix the Leaks and make it more efficient .......

My View of the Spell

My view is that this spell IS AWESOME AND VERY FUCKEN COOL .... Thunder STRIKE .. Thumbs UP ext. ext.. .But the problem is read the HOW TO IMPROVE this is what sad.

EDIT : Forgot one thing +REP !!!!!!!!!!!!!!!!!!!!!!!!!!

 

[Septimus]

@ Septimus:
See, a creative, original and simple spell!
And don't start bugging me with submission rules

I won't bug a user if they follow the submission rules.

But I could still bug you to code it in JASS/VJASS

 

[Deuterium]

Well you leak 3 Point every 0.20 seconds the three points are
[ CO_CenterLoc ext.. -- CO_trigUnitLoc -- CO_TargUnitLoc ]
Fix them and make it more efficient like not spamming this blue special effect make it like two Axes spinning around the location and fire on them it will be much more Lovely ...anyway fix the Leaks and make it more efficient ......

Ohh haha yeah I knew I forgot something! that's easy to fix... I'll do that later I tried fixing that quickly now but I'm too sleepy to place the custom scripts in the right places
& although it's not excuse... i mentioned that it still needs fixing in the description

But I could still bug you to code it in JASS/VJASS

Hehe as I said, I wont rush up into scripting Jass

 

[Rmx]

Originally Posted by Septimus
But I could still bug you to code it in JASS/VJASS

Originally Posted by Deuterium
But I could still bug you to code it in JASS/VJASS

I think u are too much sleepy GO TO BED ! looool.

Originally Posted by DARK_DRAGON LOL
spell by itself seems leakless, MUI, GUI and usefull.

Well MUI GUI yes ... Leakless i don't think so loooooooool

 

[Dark_Dragon]

Well MUI GUI yes ... Leakless i don't think so loooooooool

sry i did not really look too well in the GUI code and well i missed this xD but ur right sry! it was a quick look at GUI since when i see GUI its kind a... dono how to say but y my mistake since it leaks but i said "seems" xD

EDIT: lals he even stored in vars but not removed xD well i did not expect that since when someone stores them he removes them as well now i know why i missed it :/

anyway thanks for pointing my mistake Rmx!

 

[Deuterium]

lals he even stored in vars but not removed xD well i did not expect that since when someone stores them he removes them as well now i know why i missed it :/

Well no the thing is that I removed the leak only once when the spell ends and forgot that in that case it'll be leaking every 0.20 seconds... if the purpose wasn't to remove leaks i wouldnt have stored them in variables

 

[Dark_Dragon]

Well no the thing is that I removed the leak only once when the spell ends and forgot that in that case it'll be leaking every 0.20 seconds... if the purpose wasn't to remove leaks i wouldnt have stored them in variables

yeah i know xD its coz u stored but removed at wrong place so actually there is still this leaks... and ofc as i quickly looked i was not injecting ur algorithms in my head xD and thats why i said seems leakless :O but anyway this is piece of cake for u to fix!

 

[Rmx]

Well there is another LEAK .........

The trigger VARIBLE ... Damage thingy ... forgot it's name ..

Anyway it makes ( Damage_? ) ( Level of ability for CAting unit [2] WOW NOT MUI -1 ) x4

Fix the array .... also ... change the special effects to something more lovely and less laggy ... i casted it twice and BAM LAG !

Also i spammed it like 8 TIMES ... and then the special effect on the hand of the unit did not go when it has finished LOOL.

 

[Arman]

THanks +rep

 

[Deuterium]

not spamming this blue special effect make it like two Axes spinning around the location and fire on them it will be much more Lovely

Well, the idea of the circle wasn't only eye candy. The circle act as a boundary to the maximum distance allowed before having the bond broken. That's why the idea of two spinning axes might not be suitable.

I fixed the leaks, and decreased the minor lag a bit (not updated yet).

However, to make it more efficient, I would like to know if anyone has any advice on what special effects would be suitable for this spell!

I was thinking of using a dummy with an aura model to act as the boundary circle, but that would become annoying to adjust (trial-and-error Scaling Value) and wouldn't be nice special effect.

Thanks!

EDIT:
Updated!

 

[-Berz-]

Wow, nice idea.

User friendly, that's good =)

Could use some better special effects, i have an idea that would look good but that would ruin the idea of "comradeship" (green + purple effects, evul ;..

It's really good for RPG maps, lots of teamwork and sth, and this spell would get handy =)

 

[Deuterium]

Could use some better special effects, i have an idea that would look good but that would ruin the idea of "comradeship" (green + purple effects, evul ;..

Well, if you've got an idea that's worth working on, I'll definetly like to hear it
It was a really hard job picking special effects that are nice and not annoying in the same time
And I barely know what each special effect looks like in-game, so I'm usually picking the special effects through trial-and-error rather than having something in mind and doing it :s

It's really good for RPG maps, lots of teamwork and sth, and this spell would get handy =)

Exactly! You know how I do care about whether spells get handy or not

 

[-Berz-]

Try something small and "light" like half visible, try to apply vertex coloring to dummies.

I would go with something blue/light yellow, or combination blue+red(if you have 6 dummies, every second dummy is blue others would be red).

Dunno just a couple of ideas

 

[Rmx]

Fixed

EDIT :

The Spell bugs ... so I fixed it ...... had to help coz ur from lebanon..

Have fun with the new fixed one LOOL ...

 

[Deuterium]

Try something small and "light" like half visible, try to apply vertex coloring to dummies.

I would go with something blue/light yellow, or combination blue+red(if you have 6 dummies, every second dummy is blue others would be red).

Dunno just a couple of ideas

Nice ideasss there haha... I'm gonna see what I can do about it any special effect model in mind??

The Spell bugs ... so I fixed it

Thanks but before I update it, shouldn't the group be destroyed before turning off the periodic trigger? wouldn't it leak otherwise?
And question, I can't understand what this does:

• Set CO_Off[CO_Index[2]] = True

 

[Rmx]

No u shouldn't destroy that group coz it didn't Create it ... or set it ...
I had a long chat me and Dark_Dragon about it loool..

Also it will not leak like i told u it is SET or Create

About Set CO_Off[CO_Index[2]] = True

Well look in Comandership Loop... at first ... and see when it turns off ..
The Loop will do nothing ... it like to prevent bugs

Glad to help .. now it is FULLY MUI without any bugs ..

 

[-Berz-]

any special effect model in mind??

Hmm, Faerie Dragon, IlidanEvil(green) + AbsorbMana(blue) together, and then you attach one effect on caster and the second one on the target =)

Or maybe try out SpiritLink/AvatarOfVengeance

i would really like to see that green+blue one with vertex coloring, I think it would look sweet

 

[Dark_Dragon]

No u shouldn't destroy that group coz it didn't Create it ... or set it ...
I had a long chat me and Dark_Dragon about it loool..

Also it will not leak like i told u it is SET or Create

About Set CO_Off[CO_Index[2]] = True

Well look in Comandership Loop... at first ... and see when it turns off ..
The Loop will do nothing ... it like to prevent bugs

Glad to help .. now it is FULLY MUI without any bugs ..

lol xD was not long at all
anyway i checked ur spell as u wanted Deuterium + i checked Rmx one...

k thats what i wanted to tell u it was not MUI until Rmx added that boolean (true / false) thing...

this is coz you always loop to max possible counter but i suggest u to decrease counter and use actaually one one. however that would require some 'smart swap algorithms' so ill leave u at this as is coz its cool

k Rmx now its my turn to blame u for not founding leaks xD

• Unit - Create 1 SFXDummy_CO for (Owner of (Triggering unit)) at (CO_CenterLoc[CO_Index[2]] offset by (CO_MaxDistance[CO_Index[2]] / 2.00) towards 60.00 degrees) facing 150.00 degrees

... already 6 point leaks
this is in main trigger

... but forget 6 leaks xD
this is in loop trigger

• Unit - Move CO_SFXDummy1[CO_Index[3]] instantly to (CO_CenterLoc[CO_Index[3]] offset by (CO_MaxDistance[CO_Index[3]] / 2.00) towards (CO_EffectOffsetCounter[CO_Index[3]] + 60.00) degrees), facing (CO_EffectOffsetCounter[CO_Index[3]] + 150.00) degrees

:O thats too much
so lets see how much points does he leak per cast:

the spell lasts 30 secs.

so its: 6*(30/0.03+1) =
= 6 *(100+1)
= 606 //

:O thats way tooo much xD
so as u can see everyone makes mistakes but must say gj on making it fully MUI for Deuterium since this is his first spell lol! and its quite good

so Deuterium ill suggest u to use Rmx version and fix this leaks i pointed + if u really want u can do that what -BZK- said, then it'll be great

EDIT: Actually to explain groups!
what GUI does when u create global 'Unit Group' variable is that it generates function which is executed on map init before everything else and it sets that variables to this:

set udg_MyGroupVar = CreateGroup()

the creategroup is the only way to create group. when you set the group vars GUI does not have CreateGroup but it has advanced functions which use CreateGroup functions such as Pick every unit matching... or any of this will generate a new group. so if you are not changing the group but only removing and adding units there is no need to remove that group since you did not lost sight of it and you will again use it. but points well once you use them you cant move them and use again so thats why we remove the points. groups dont need to be destroyed if you will use it again (the same one).

Hope it helps!

Greets all!
~Dark Dragon

 

[Rmx]

Well didn't say that it does not contain leaks ...... LOOOOL....

But still i wasn't checking for leaks i was making it 100% MUI LOOl ...

 

[Aspard]

Why do you always write LOOOL after each sentence?

Back to topic:
About special effects, why not using whisps?

 

[Deuterium]

k thats what i wanted to tell u it was not MUI until Rmx added that boolean (true / false) thing...

Now i understand how this functions

this is coz you always loop to max possible counter but i suggest u to decrease counter and use actaually one one. however that would require some 'smart swap algorithms' so ill leave u at this as is coz its cool

Are you talking about the WaitCounter and the EffectOffsetCounter? and haha don't worry, im good at algorithms but I just need to understand what u mean by this

k Rmx now its my turn to blame u for not founding leaks xD

I totally forgot about Polar projections leaking two points... gotta fix that

Hmm, Faerie Dragon, IlidanEvil(green) + AbsorbMana(blue) together, and then you attach one effect on caster and the second one on the target =)

Or maybe try out SpiritLink/AvatarOfVengeance

i would really like to see that green+blue one with vertex coloring, I think it would look sweet

if u really want u can do that what -BZK- said, then it'll be great

I'll be giving his ideas a try tonight and update it

Actually to explain groups!
what GUI does when u create global 'Unit Group' variable is that it generates function which is executed on map init before everything else and it sets that variables to this:

set udg_MyGroupVar = CreateGroup()

the creategroup is the only way to create group. when you set the group vars GUI does not have CreateGroup but it has advanced functions which use CreateGroup functions such as Pick every unit matching... or any of this will generate a new group. so if you are not changing the group but only removing and adding units there is no need to remove that group since you did not lost sight of it and you will again use it. but points well once you use them you cant move them and use again so thats why we remove the points. groups dont need to be destroyed if you will use it again (the same one).

Umm yes i get your point. I just thought it'll be more efficient if the group was removed when not in use and then created when needed, but i guess it would barely make any difference right...

Why do you always write LOOOL after each sentence?

Haha! LOL?

About special effects, why not using whisps?

I'll give that a try too...


Thank you all guys for you efforts and help
As I always say: Appreciated!

 

[Dark_Dragon]

Well didn't say that it does not contain leaks ...... LOOOOL....
But still i wasn't checking for leaks i was making it 100% MUI LOOl ...
Why do you always write LOOOL after each sentence?

lool well i just said it leaks and was ofc kidding! like the hell ill blame u, it was my mistake to say it was MUI and leakless :O

Are you talking about the WaitCounter and the EffectOffsetCounter? and haha don't worry, im good at algorithms but I just need to understand what u mean by this

no no i was just talking that when spell is casted multiple times and if some ends you should decrease that max counter, the same u do with current spell casts counter

but as said is not needed coz it rockzzzz this way toooo !!!

I totally forgot about Polar projections leaking two points... gotta fix that

np its ur first spell!

I'll be giving his ideas a try tonight and update it

well since its ur spell do what u want, its already cool but might be even more if u try that effects -BZK- suggested

Umm yes i get your point. I just thought it'll be more efficient if the group was removed when not in use and then created when needed, but i guess it would barely make any difference right...

:O lol thats actually called 'dynamic object works' and thats my fav and ofc best way of coding spells. but anyway if paladon did not work on that, then well maybe its k for u not to try. but do what u want

Thank you all guys for you efforts and help
As I always say: Appreciated!

np and greets all!
~Dark Dragon

 

[Deuterium]

UPDATED! Hopefully flawless now

no no i was just talking that when spell is casted multiple times and if some ends you should decrease that max counter, the same u do with current spell casts counter

I'll leave that for later... I'm happy enough that I finally came to understand how the indexing system functions so until I make a new spell using some dynamic system like the one you're talking about, I wont adjust this...
you understand what i mean eh?

Anyways, I took BerZeKeR's advice and adjusted the special effects to what he said... I'm still at a confusion of which of the two are better (Phoenix or the Green/Blue/White) but decided to post this one...

I hope there's nothing more to fix! Believe me, I already didn't like GUI, now i came to hate it! but as i said, I won't be going fully going into vJass until I'm good with GUI

EDIT:
DarkDragon i have one question to know whether I gotta fix that or not...
In Jass, let's say I wanted to create the group, I'd insert:

if udg_CO_Debug == null then
    set udg_CO_Debug = CreateGroup()
        endif

That would be done in order not to create the group if it's already created, right?
Because when I do it in my spell, once the last instance of the spell ends, it give the message in-game about double-freeing the group...

 

[Rmx]

Well i cheked it out ......... one flaw ... try not to remove the units add an EXPIRATION time like 0.01 seconds to them.... they will create their death effect when they expire...
Then also remove the Special effects ... coz when they expire they will create those effects ...

This will help ur Trigger speed better

 

[Dark_Dragon]

wooot nice effects!
thats when u listen to -BZK- he is quite creative
and np thats good coding really.

That would be done in order not to create the group if it's already created, right?
Because when I do it in my spell, once the last instance of the spell ends, it give the message in-game about double-freeing the group...

well the problem in jass is that when u destroy the group that variable which was pointing to group is not cleared. thats why we null them in order to free them coz if they are not! then that "if then else" you posted will never trigger coz even if group is destroyed its not cleared... which means its not null

so you have to do that this way:

call DestroyGroup(<whichGroup>)
set <whichGroup> = null // -> note this is a must

// and now
if <whichGroup> == null then
    set <whichGroup> = CreateGroup()
endif

thats the correct way of doing it

hope it helps!
~Dark Dragon

 

[Deuterium]

Well i cheked it out ......... one flaw ... try not to remove the units add an EXPIRATION time like 0.01 seconds to them.... they will create their death effect when they expire...
Then also remove the Special effects ... coz when they expire they will create those effects ...

This will help ur Trigger speed better

Well I'll sure do fix that but not before a few days from now... I'm a bit exhausted of triggering

wooot nice effects!
thats when u listen to -BZK- he is quite creative
and np thats good coding really.

Yupp BZK's idea with my spiral touch ended up being amazingg

well the problem in jass is that when u destroy the group that variable which was pointing to group is not cleared. thats why we null them in order to free them coz if they are not! then that "if then else" you posted will never trigger coz even if group is destroyed its not cleared... which means its not null

so you have to do that this way:

call DestroyGroup(<whichGroup>)
set <whichGroup> = null // -> note this is a must

// and now
if <whichGroup> == null then
    set <whichGroup> = CreateGroup()
endif

thats the correct way of doing it

Yupp I totally understand that would make the trigger a bit "custom script-y" but that's only for the sake of better efficiency!

 

[-Berz-]

So you used the effects =)

Looks nice, still dunno if it works with projectile models, try to apply transparency(vertex coloring) to about 50-70, that would make dummies less visible and it would look even better

 

[Deuterium]

So you used the effects =)

Looks nice, still dunno if it works with projectile models, try to apply transparency(vertex coloring) to about 50-70, that would make dummies less visible and it would look even better

Yup used them and added the spiral, & VOILA! Oh & added you to the credits ;D
Anyways, vertex coloring isn't an option because only the missile would change color but the projectile particles won't...

 

[LebaneseSoul]

keep it up!

 

[Deuterium]

Updated to v1.03!

 

[calex3]

i like this ......i wish to be back on hive...but i have too much school to work......very nice spell 5/5

 

[f0rsAk3n]

WoW ! dude this is really awesome! I LOVE the idea!

Keep up the good work!

5/5!!!!

Forgot 1 thing:

LOOOOOOOOOOOOOOOL

 

[Deuterium]

WoW ! dude this is really awesome! I LOVE the idea!

Keep up the good work!

5/5!!!!

Glad to know you like it!

 

[gunggang777]

Nice one dude
good spell

 

[Teldrassil]

I implemented this ability into my map, and I must say, the biggest problem is the lag, I've tried greatly reducing the visuals and it still lags if 4 or more instances of the ability is running, which is bad since it's a custom hero game so every player can choose it. I'm working on ways to reduce it but if you've got any suggestions I'd love to try em.

-Teld

 

[aider]

nice idea. Fits my support hero

 

[Kam]

Great spell. It still lags on cast though (in your test map too).

 

[SadOnix]

such a unique spell. a shame he made such fantastic work and then never proceed to do more spells