Electric Whirlwind v1.03

[Moderator]

00:31, 10th Dec 2012
Magtheridon96: Approved.

A tip:
You can store the dummy that does the orders into a unit variable so that you don't have to repeat (Last Created Unit) multiple times (It's in the Loop code of a group enumeration, so it gets repeated many, many times.)

I don't know what to rate this exactly :/

Another tip

Some of your comments are outdated ;D

 

[Wrda]

Few details:
1.

Hidden

• -------- Group for target selection --------
• Set CL_Group1 = (Units within 750.00 of CL_Loc1 matching ((((Matching unit) belongs to an enemy of CL_Player[Temp]) Equal to True) and (((Matching unit) is alive) Equal to True)))
• -------- Unlucky bastard getting shocked --------
• Set CL_Target[Temp] = (Random unit from CL_Group1)

You save a unit into a variable, and you don't nullify it, it will be overwritten more times and will cause a small leak.

2.

• Set CL_Player[Temp] = (Owner of (Triggering unit))

• Unit - Create 1 Dummy for CL_Player[Temp] at CL_Loc3 facing Default building facing degrees

The variable CL_Player isn't needed for the spell as you can do this:

• Unit - Create 1 Dummy for (Owner of CL_Caster[Temp]) at CL_Loc3 facing Default building facing degrees

3.

Hidden

• Set CL_Group2 = (Units within (Real(CL_PurgeAOE[Temp])) of CL_Loc2 matching ((((Matching unit) belongs to an enemy of CL_Player[Temp]) Equal to True) and (((Matching unit) is alive) Equal to True)))
• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in CL_Group2 and do (Actions)

->

Hidden

• Set CL_Group2 = (Units within (Real(CL_PurgeAOE[Temp])) of CL_Loc2 matching ((((Matching unit) belongs to an enemy of CL_Player[Temp]) Equal to True) and (((Matching unit) is alive) Equal to True)))
• Unit Group - Pick every unit in CL_Group2 and do (Actions)
• etc...
• Custom script: call DestroyGroup(udg_CL_Group2)

You're trying to destroy the group by 2 ways, the pick every unit function is destroyed but the group variable isnt destroyed , just do what i did above.

The rest of triggering, is pretty readable and solid for GUIers, and i like the spell too.
This is 4.9/5 for me, that means 5/5 keep the good work and fix those details

 

[f0rsAk3n]

Thanks for the input. I'm really rusty :>

Just 1 quick question. How do i nullify it? Should I do this:

Reveal

• Set CL_Target[Temp] = No unit

 

[Wrda]

Exactly + rep for u

 

[xorkatoss]

awesome spell gj! 5/5

 

[f0rsAk3n]

It's strange how every mod has their own way of doing things :>

You need to have a trigger that runs on map initialization for the purpose of spell constant configuration. It makes it easier for users to modify spells without having to mess with the actual code. (Special effects, damage, range, duration, etc...).

Fixed. :>

In the Start trigger, you can use CL_Caster[Temp] instead of repeating Triggering unit again in the next 2 lines.

Fixed :>

(Owner of (Triggering unit)) == (Triggering player), but (triggering player) is faster.

Fixed :>

This next suggestion is totally optional, and it has a con, but it will increase your code's performance considerably: Instead of using (Random unit in (group)), you can set the unit using custom scripts to FirstOfGroup(udg_group). The only con that this has is that this will always pick the unit with the greatest Y-coordinate according to most people I know. In a real map, this shouldn't be much of a problem. I'd only suggest using it if it's not giving you weird results while you're testing.

Fixed :>. Tested and the results seemed fine since the lightnings spreads anyway.

Adding an expiration timer to a unit doesn't finish the job. You need to have a trigger that runs upon the death of a unit. If this unit is a dummy, remove it from the game.

Fixed :>

You shouldn't be creating a dummy /inside/ the enumeration code for every single unit in the group you're picking inside your loop trigger because that would create too many unneeded dummies. One dummy is plenty. It would just need to have animation backswing times of 0. Create it before you pick all the units, give it the expiration timer and the ability, and inside the enumeration code, all you would do is order it.

Fixed :>

 

[Almia]

seems to be approvable to me.

 

[doomhammer99]

Approve

 

[Imadori]

Spoiler

Cool spell, rated 5/5.

 

[Losam]

Nice spell. Well done.
5/5