Command Earth v1.0

[Moderator]

10:40, 3rd Aug 2012
Magtheridon96:

Awww come on, where's Mag

Nananananananananananananananana Approved.

Here's a fundamental rule for Warcraft III.
When you have a variable holding a value that doesn't leak, if it is only being referenced once, you don't need it. You can use it's value directly.

You can use this to shorten your code a bit in this resource.

 

[defskull]

Reserved.

 

[defskull]

Awww come on, where's Mag

 

[Tank-Commander]

Be patient, eitherway from the way you're doing this I so, so strongly believe you should be using dynamic indexing, this whole code would be many times shorter if you did, on the cast trigger you could save a lot of the values directly into the hashtable to save a bit of processing instead of setting all those variables, all use one or two (depending on amount of types) array variables to store all of them in get rid of the redundant ones, using it as a cache.

Though I will say I don't see the need for two loops, since both running at the same time is half as efficient as them both being in the same, and one of them running at a time is almost the same, since if one was empty then you could skip the actions by putting them in the else section and it'd be just generally more efficient, While I understand that the delay will be different, might I suggest a MUI wait delay method to be applied? wouldn't be very difficult and would cater to both needs within the same trigger.

 

[defskull]

Always with the indexing, you're discriminating Hashtable user :/

About the loops, well I used 2 loops to handle 2 Unit Group, you suggest that I should merge those 2 Pick Unit Group Action in one trigger ?
And create an artificial wait either to one of the interval ?
And the trigger should be turned off when both Unit Group are empty ?

If I use your method, imagine how long the code would be ;p
Deal with it, there are pros and cons.
Also, to my eyes, the processing is fast enough.

Also, stop discriminating Hashtable.
You're like saying that Hashtable has no place for Spells..... and Systems.

 

[mckill2009]

Be warned that Terrain Deformation returns a handle and cannot be removed, so it always leaks no matter what...

 

[defskull]

I might remove the terrain deformation, I don't know, it looks cooler :/
And indicates the AOE size.

 

[Tank-Commander]

Always with the indexing, you're discriminating Hashtable user :/

I constantly say it because your method of doing these things is always half-way there. I personally used hashtables all the time up to the last two spells I used myself, so I can't exactly discriminate against my own method.

About the loops, well I used 2 loops to handle 2 Unit Group, you suggest that I should merge those 2 Pick Unit Group Action in one trigger ?
And create an artificial wait either to one of the interval ?
And the trigger should be turned off when both Unit Group are empty ?

Yes because it would be more efficient and result in fewer triggers as well.

If I use your method, imagine how long the code would be ;p
Deal with it, there are pros and cons.
Also, to my eyes, the processing is fast enough.

Still shorter than most of my spells XD
Also, what are the pros? I personally can't think of any
For the record, though, how fast the processing is - what's good enough is up to the moderator who reviews it.

Anyway I'm not /attempting/ to discriminate at all, and do not think hashtables have no place, but rather think you're good enough to not since it'd cut off roughly 20+ lines of your code due to the way you're doing it, which actually bar having arrayed variables is almost there

On another note which I think got a bit left behind: As I said - since you set things into variables initially instead of directly to your hashtables, it's actually half as efficient (not literally but you get the idea) since it uses twice as many lines to do the same thing, which is why I say it's close to dyanmic indexing since if you just made those variables arrays and indexed them, you'd be done, - My point on using caches instead of a lot of different variables also got left behind, which is the typical method of using variables when loading from a hashtable, since there's not much point having individually named variables to load from each hashtable instead of having one or two arrayed variables able to store all the values.

 

[Magtheridon96]

@Tank-Commander, this could be faster by a ton, but here at THW, we can accept spells that use the group enumeration method.

Personally, I always use dynamic indexing for my spells and arrays only because it's the most efficient and cleanest way to write a spell, but if I made my personal standards a requirement on this site, the only resources that would be approved are some of yours that use dynamic indexing, mine, Nestharus' resources, iAyanami's resources, Bribe's, and a couple more.

I don't want to be oppressive :C

 

[defskull]

When you have a variable holding a value that doesn't leak, if it is only being referenced once, you don't need it. You can use it's value directly.

I don't get this one, can you give me a short trigger about this ? (doesn't have to be from my trigger)

the only resources that would be approved are some of yours that use dynamic indexing, mine, Nestharus' resources, iAyanami's resources, Bribe's...

Ouch.

 

[Kingz]

Also, stop discriminating Hashtable.

No he isn't, it's a common fact indexing was and is better in almost all situations.
There are situations where hashtables help but they are rare and most of the time indexing does it better.

I did tell you to try to remove the deformation :>

PS: Mag, My only left GUI resource uses dynamic indexing also

 

[Magtheridon96]

@defskull:

Trigger

• Trigger
  • Events
  • Conditions
  • Actions
    • Set TempUnit = (Triggering unit)
    • Unit - Kill TempUnit

That trigger is less efficient than the below one:

Trigger

• Trigger
  • Events
  • Conditions
  • Actions
    • Unit - Kill (Triggering unit)

 

[defskull]

So you're saying about my loading data from a Hashtable and the data gets to be used once in the trigger ?
So, it's the same situation with the previous spell ?

 

[Magtheridon96]

It's the same situation whenever you have a variable only being referenced once.

There are other instances in which you are using a variable and referencing it only once.

For example:

• Special Effect - Create a special effect attached to the origin of TempUnit using CE_EntanglePathSFX
• Set CE_EntangleSFX = (Last created special effect)
• Hashtable - Save Handle OfCE_EntangleSFX as 9 of CE_Key in CE_Hashtable

 

[mckill2009]

Thanks to structs!, it's indexing method is the best there is...But I have to admit that I love hashtables even though they are around 70% slower than indexing...

 

[Losam]

This Spell is Powerful Man!