Raigor Stonehoof the Earth Shaker spells v1.0

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

17:54, 19th Jul 2012
Magtheridon96:

Comments

• udg_FissurePoint2 doesn't need to be an array
• In the Echo Slam spell, you shouldn't use that if block to deal damage, use a formula.
• Try not to repeat function calls over and over again, use variables to store the data instead.
• Use Bribe's Damage Engine to detect damage events rather than making your own form of damage detection.
• You have no configuration at all here. Damage should be configurable, effects should be configurable, etc...
• Some of these spells are way too simple and your "Enchant Totem" spell registers events to a trigger more than once for the same unit.

Needs fix.

 

[GIMLI_2]

i didnt rly look at the triggers, but in echo slam trigger, instead of doing this:
if level equal 1 = 160 dmg
if level equal 2 = 210 dmg

you could do this:
damage 110 + level of ability x 50

 

[Dr. Boom]

Moin moin =)

Well another DotA-copy - I thought we got away from this but hey never mind:

Fissure:
- Just wondering why you use in the loop "Integer FissureLoop". For me it works without use that variable here.

Enchant Totem Group:
- You need to destroy the group you using there
- Also the point you use for the group pick need to be stored into a variable and destroy after.

Echo Slam:
- Already said: You don't need to use the actions for every level, just use the formula GIMLI_2 gave you.

Note:
You should store the caster (triggering unit) into a variable and refer to it, if you use in all of your actions of the spell more then once (triggering unit). Because (triggering unit) always calls a function.

This is all I can see so far. Since I'm not a friend of just copy some spells which already exists, you code them well, even if you would like them better in Jass.

Greetings and Peace
Dr. Boom

 

[HammerFist132]

I really do not like your dota work. U know to dota is very popular and u know to others will dl your map just because it has small part of it. If someone requested u this ok, but do something original. Nothing else to add

 

[Storm_hih]

you could do this:
damage 110 + level of ability x 50[/QUOTE]

Yes but the problem if the level is 3 it will deal 270 but if i used 110 + 50 x level on level 3 will be like 260 damage.

 

[Storm_hih]

I really do not like your dota work. U know to dota is very popular and u know to others will dl your map just because it has small part of it. If someone requested u this ok, but do something original. Nothing else to add

I don't need anything for them really, i just do them for my self for fun, and if i liked them i post them here and any one can take it.

 

[Almia]

Bad idea for Echo Slam
* uses variables arrays for the damage like this:
[trigger=]Set ES_Damage[1] = 160[/trigger]
then
[trigger=]Damage Unit by ES_Damage[Level of Echo Slam for (The Caster)][/trigger]

 

[Pod]

Good spell 5/5
I cast my request skill?.
You find model of this?.

 

[Iconer]

Here! Ter alot of RIP model! Also 5 + Rep! Sand King please

btw, i lik ratletrap war becaus it hok then cog den batery! ah i se! cool! ter wil be roket!

 

[Adiktuz]

@above - off-topic dude...

@Dr Boom: because integer A/B loops sometimes cause random bugs, they just suddenly stop sometimes, which is why it is preferred to use custom variable loop

@hammer - I totally agree

@storm:

again, don't DP

Hmmm... where's the echo of the echo slam? I believe echo slam is like this:

an FoK based spell (which also acts as the spell that ES casts) deals the initial damage (the huge shockwaves), then the echoes (the little shockwaves) are done via triggers (another FoK based ability, a dummy caster is created for every unit that will cause an echo)...

and oh, your enchant totem is inefficient... it will produce lots of unneeded events [once the unit dies, the event stays]...

And you should seriously learn how to make a configuration setting for your resources... its not a good idea for a user to go into the core of the triggers just to modify a basic part like damage...

I know its based from DotA, but since you uploaded it as a public resource you should put into consideration that someone will be using it in a different map, so make sure that everything that needs to be configurable is as easily configurable as possible... like the damages and the length of fissure...

The thing lacking from your spell packs was their applicability on non-DotA maps... the way you structured the triggers make it harder for the user to modify it than it should be... if you just want to recreate DotA spells, then do so, but don't upload the spells as public resource unless you make them as public friendly as possible...

I suggest you learn how to make your spells configurable first and user-friendly and update them all before uploading another one...

 

[Storm_hih]

I suggest you learn how to make your spells configurable first and user-friendly and update them all before uploading another one...

What is the unfriendly as you say in the trigger just tell me?

 

[Adiktuz]

They aren't configurable enough so they are not user friendly...

 

[Storm_hih]

Tell me an example of what i must do then?

 

[hieu2525]

I think you need to make DotA Spell Pack All in 1, and update it every day. Not about these Dota spell's threads.

 

[Adiktuz]

have you ever tried looking at the other spells here and see their configuration set-up?

and I agree with the above post... its a much better idea...

 

[Storm_hih]

have you ever tried looking at the other spells here and see their configuration set-up?

and I agree with the above post... its a much better idea...

You mean that i should write comments in the trigger to make the user know what is this?

 

[KnnO]

You mean that i should write comments in the trigger to make the user know what is this?

No, You should set up a trigger to config variables such as damage for each level etc

for example a trigger:
where the event is map initialization
and the actions are:
set Damage[1] = 200;
set Damage[2] = 250;
set Damage[3] = 300;
1,2,3 for the level number

and comments if there is anything that can be changed by the user

 

[Iconer]

Go storm hihh!

 

[zv27]

If you already want to post something here from dota, then try to start to look a little dota war3map.j file,It can be very useful for you. I am a big fan of dota, and because of this reason I have a lot of open version of dota.From 6.12 up to latest version.So it was for my eyes, this horror film.