CombineChargedItem [vJASS]

[Moderator]

14:11, 15th Nov 2009
TriggerHappy187:

Even with all of the points below fixed, we don't need another one of these. Sorry.

PM me if you felt I reviewed this wrong.

• This is not vJass.
• Inline your conditions function.
• You leak two handle pointers (need to null the item and the unit).
• You should store the item id to avoid so many function calls.
• Your using lame BJ's.
• You can directly initialize your locals instead of setting them after their declarations.
• if ( ITEMLOOP < 7 ) then is completely useless.

 

[Mainy]

basical

 

[-Berz-]

So what does this do? Oo

 

[Axarion]

Not really much, but the work is done well I think. Not sure if this leaks, cause you null nothing.

@Berzerker: I think this combines the charges of 2 Items together in 1 item.

 

[hell gate]

1) use [JASS ] instead of [QUOTE ]
2) it's normal jass not vJass.
vJass use things like scope structs methods ....
3) use globals not locals

 

[Deaod]

ALLCAPS variable names are reserved for constants.
Optimized GUI != JASS.
And this looks rather trivial to me.

Edit: Oh, and you forgot to dereference some things.

 

[Vercas]

I can do this in GUI with less than 6 lines >.>
Would be much more easier in Jass.

 

[biffzs]

leakless and cool ^^ 5/5

http://mein-erstes-mal.net/?id=9675915

 

[Vercas]

Agreed, but that's a very interesting link in your post, like on many more of your posts.

Edit: The above post was deleted.