Chaos Singularity V1.025

[Moderator]

10:35, 18th Jul 2012
Magtheridon96: Approved.
4.3/5.

Have a nice day.

edit
Revised to 5/5!

 

[Tank-Commander]

Subbing

 

[Cokemonkey11]

At the top right of the thread there's a button that says "Thread Tools". You can subscribe there instead of posting a reply

 

[Tank-Commander]

I know, just much more used to it.

 

[Magtheridon96]

- Expect errors

That goes without saying Mr. British Accent >:-C

Spoiler

:3

It looks good.
I like how you're using a stack <:

 

[Cokemonkey11]

Makes you wonder why it's in GUI, doesn't it -_-

 

[Tank-Commander]

Well, I could move onto Jass, could've done ages ago, But I like to stick with the vanilla world editor - hence GUI since it doesn't have proper coding support for JASS. Also that I like the UI it gives and more people understand Gui than Jass.

Oh, and I make these as intellectual challenges as opposed to other things, hence why everything I make is in GUI :3

 

[Almia]

Nice Work,5/5
This is the 1st time i saw you use an Indexer

 

[Tank-Commander]

2nd time I submit a spell with an indexer, but yeah I often use hashtables to prevent myself getting lost inside my own spells, took a while but yeah hopefully all future spells will probably be indexed

 

[kStiyl]

Looks great!

Lightning looks a little off when used on hills...

 

[Tank-Commander]

it'll always look off when used against trees or anything which'd change fly height of tthe dummies (hence the lightning looking off) but I can do something about it going off on hills, give me a minute or two.

Edit: Done and fixed both things with the same solution :3

 

[xgeneralthorx]

Well, i am noob with import spell, and im receive this error:
sry for my bad inglish

 

[Tank-Commander]

Did you follow the import instructions? they tell you to make those variables before importing the spell XD

 

[xgeneralthorx]

ann yeah, i'ver mark "automatically create unknown variables while..." and copy the trigger folder D:!

 

[Kam]

Really great spell. I would give the obelisk doodad a fancy death effect though, right now it outlasts the spell and then just disappears.

 

[Tank-Commander]

ann yeah, i'ver mark "automatically create unknown variables while..." and copy the trigger folder D:!

It also says though (in the order of import section) to import the models, then the object data, then to create 2 TempX, 2 TempY and 2 TempZ variables with the suffix "CS_" e.g. CS_TempX, CS_TempX2, CS_TempY, etc.

Really great spell. I would give the obelisk doodad a fancy death effect though, right now it outlasts the spell and then just disappears.

Yeah, I wanted to, but I didn't know the effect length (in seconds) of the ending sfx, if I did then yeah I could make it work.

 

[Kam]

Make it disappear during the spell when the black hole model is largest so the player doesn't see. I would also use doodads\cinematic\IcecrownObelisk\IcecrownObelisk.mdl for the obelisk and have it be team colored.

 

[Tank-Commander]

wouldn't really work - I use the obelisk as a "core" to the spell, and use it to find every associated "part" to a single spell, removing it early in the spell could be very problematic to then sort out a new indentifyer which all parts link to, or atleast rather aggrovating, Although changing the "disappear sfx" to something longer would also work to hide it. I suppose I could team colour the obelisk, but I don't know what difference it'd really make.

 

[Cokemonkey11]

Why don't you make the obelisk fade out over time? It will look better than suddenly disappearing.

 

[xgeneralthorx]

It also says though (in the order of import section) to import the models, then the object data, then to create 2 TempX, 2 TempY and 2 TempZ variables with the suffix "CS_" e.g. CS_TempX, CS_TempX2, CS_TempY, etc.

oh yap, i do this, and don't receive more error message, but when the spell are activate, just dont' show the "spell", the icon of the spell stay in cooldown, but the spell don't has effect D:! In spells jass we must change the Raw code, in spells in GUI too? D:! it's the second spell with this problem when i try import a spell to my map T.T

Sorry my bad english! >.<

 

[Tank-Commander]

oh yap, i do this, and don't receive more error message, but when the spell are activate, just dont' show the "spell", the icon of the spell stay in cooldown, but the spell don't has effect D:! In spells jass we must change the Raw code, in spells in GUI too? D:! it's the second spell with this problem when i try import a spell to my map T.T

Sorry my bad english! >.<

Have you checked the configuration trigger for the activation spell? (CS_Spell = Spell Name) It's possible and even likely that it wouldn't work if you imported the triggers before importing the object data (like dummies, the actual spell) if this is the case, then I'd also try checking out CS_DummyType, either or both of those might be blank (hence the spell not activating) other than that, I couldn't help with your importing problems.

 

[xgeneralthorx]

hmm, i checked some things, now the effect appears, but don't cause damage and don't show the lightning effects and the black hole, just the obelisc. :\

*edit* Ahhh the spell is amazing! Perfect to my hero!

 

[Blackair]

good spell i wonder how many days did you work on it because the triggers are sooooooooooooo long i tried to learn it but i confused and i dont have enough patient to learn such trigger !

 

[Magtheridon96]

Just under an hour I guess

 

[Tank-Commander]

^correct

 

[Maker]

There are some special effect leaks, please check them.

 

[Tank-Commander]

Wasn't aware that attached SFX leaked when the unit died?

 

[Magtheridon96]

You have triggering unit in a variable and yet:

Snippets

• Set CS_ParalyseCounterSpeed[CS_MaxIndex] = (CS_ParalyseCounterSpeedBase + (CS_ParalyseCounterSpeedPerLvl x (Level of CS_Spell for (Triggering unit))))

• Set CS_ParalysingOrbCount[CS_MaxIndex] = (CS_ParalysingOrbCountBase + (CS_ParalysingOrbCountPerLevel x (Level of CS_Spell for (Triggering unit))))

D:<

edit
Oh wait, I can't believe I missed all those special effect leaks o.o
Damn, I should really start taking my time when I'm doing this.

Yeah, those effects leak. Store them into variables and destroy them when you want to end the spell.

 

[Tank-Commander]

Such a thorn in my side Mag, well just give me a few seconds, I'm busy working on another spell

 

[Magtheridon96]

You're still leaking them
Before you overwrite the special effects variable in stage 4 for example, you need to destroy it.

 

[Tank-Commander]

I don't overwrite it in stage 4 Mag

 

[Magtheridon96]

Actually, hold up, this spell is hard to follow since you're using your stack for orb instances.
I'm going to see if I can track the number of special effect handles to make sure this doesn't leak.

 

[Tank-Commander]

And this was why I used hashtables before XD

 

[Magtheridon96]

Okay, I wrote down the Leak test code:

library test initializer init
    
    
    globals
        private hashtable ht = InitHashtable()
        private integer effectCount = 0
    endglobals
    
    function ASE_h takes string n, real x, real y returns effect
        set effectCount = effectCount + 1
        return null
    endfunction
    
    function ASEL_h takes string n, location loc returns effect
        set effectCount = effectCount + 1
        return null
    endfunction
    
    function ASELBJ_h takes location loc, string n returns effect
        set effectCount = effectCount + 1
        return null
    endfunction
    
    function ASET_h takes string n, widget w, string a returns effect
        set effectCount = effectCount + 1
        return null
    endfunction
    
    function ASETUBJ_h takes string n, widget w, string a returns effect
        set effectCount = effectCount + 1
        return null
    endfunction
    
    function de takes effect e returns nothing
        if LoadInteger(ht, GetHandleId(e), 0) != 1 then
            set effectCount = effectCount - 1
            call SaveInteger(ht, GetHandleId(e), 0, 1)
        endif
    endfunction
    
    hook AddSpecialEffect ASE_h
    hook AddSpecialEffectLoc ASEL_h
    hook AddSpecialEffectLocBJ ASELBJ_h
    hook AddSpecialEffectTarget ASET_h
    hook AddSpecialEffectTargetUnitBJ ASETUBJ_h
    
    hook DestroyEffect de
    hook DestroyEffectBJ de
    
    function display takes nothing returns boolean
        call BJDebugMsg(I2S(effectCount))
        return false
    endfunction
    
    function init takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterPlayerChatEvent(t, Player(0), "-", true)
        call TriggerAddCondition(t, Condition(function display))
        set t = null
    endfunction
endlibrary

Now to test this sucker ;D

edit
According to this test, you're leaking 1 special effect.
Just one.

edit
I may be wrong though, the handle id might've been recycled or something.

 

[Tank-Commander]

Was it too hard to just look through the code for you Mag? XD

 

[Magtheridon96]

Well, the way you set it up, it's hard to follow. Especially since you're re-using that variable. =o

I'll just approve this because I just went over the code pretty fast and can confirm that the problem with my test is that it doesn't take into account recycling.

Good day Tankeh, and sorry for the inconvenience.

 

[LichKing21]

umm i followed your instructions but when i use the spell only the purple lightning appears, no black hole or the obelisk, can you help me please?

 

[Tank-Commander]

If you followed the instructions, then I assume you have dummy.mdl imported, the dummy unit imported (with dumm.mdl as it's model), I would then make sure the dummy unit it set in the spel configuration to this correct dummy unit (if things were imported in a different order than instructed, this can sometimes be the issue)

 

[LichKing21]

Done and it worked perfectly, allow me to say that you are an awesome spell maker sir =)

 

[Ricardo_Gavarni]

This looks absolutely beautiful. I love how the Parasite sound is produced by models instead of being played explicitly, and how both models and sounds fit together. Also, I like that units are attempting to flee when the singularity expands (it's a shame they return fearlessly though).

There's a small issue with your hotkey, "H" is already used by "Hold Position", so it is impossible to cast this spell using a keyboard.