Button stacking *patched* ?

[mietek]

Seems like importing CommandFunc.txt with negative values doesn't work anymore?

Tryed also in local files and MPQ.

How to stack standart buttons (remove Patrol, Hold Position, etc)

Can someone check this out for me?

edit.
here is my prove screenshot

Before patch

After patch(buttons are back)

Scanning out MPQ right now maybe they changed something.

 

[DracoL1ch]

mpq have nothing to do with that, unless they renamed/locked basic layout params (which I doubt)

 

[wc3neverdies]

I can confirm this, i used a map where i changed the button position of patrol attack and move to 0,-11 and doesn't work anymore. I tried with other numbers like 0,-2148463648 and 0,-268435456 that used to work in the past, still not working.

 

[PurgeandFire]

Thanks for the report! I'll add this as soon as possible.

 

[Pyrogasm]

Laaaaaame. Was this patched because it was exploitable for malicious code in some way?

 

[Emm-A-]

Oh shit, this is very bad! This breaks my current project right away ...

This is horrible ...

thank you a lot for reporting . I guess, a hot fix is pretty unlikely? ...

 

[Wareditor]

Laaaaaame. Was this patched because it was exploitable for malicious code in some way?

No, it was patched without any reason.

 

[PurgeandFire]

Laaaaaame. Was this patched because it was exploitable for malicious code in some way?

I don't think so. I bet they were adding some bounds checking for stuff as they were revising/reorganizing the code.

Oh shit, this is very bad! This breaks my current project right away ...

This is horrible ...

thank you a lot for reporting . I guess, a hot fix is pretty unlikely? ...

I think a hotfix is likely. Blizz has been adamant about not breaking existing shit, and they've been faithful in that regard. We'll definitely try to send them this bug since a decent number of maps exploit that bug.

 

[Dr Super Good]

Laaaaaame. Was this patched because it was exploitable for malicious code in some way?

It almost certainly was unsafe. Maybe not exploitable but people were likely using it without knowing all possible consequences. Just because an offset does not cause an immediate crash, does not mean it is harmless and not breaking or causing a crash later on in the session.

I think a hotfix is likely. Blizz has been adamant about not breaking existing shit, and they've been faithful in that regard. We'll definitely try to send them this bug since a decent number of maps exploit that bug.

They still need to implement it in a safe way. It is a new feature that has to be added as it never existed before. Before people were relying on broken mechanics to do what they wanted without any regard of side effects.

 

[A Void]

Button stacking and hiding was patched out because it caused crashes on Mac. They should fix it properly without disabling. Disabling is not an option, it was a really useful feature.

 

[Dr Super Good]

Disabling is not an option, it was a really useful feature.

It was not a feature though. It was an exploit.

This is why I avoid recommending people use exploits as they can end up being fixed.

 

[Kakerate]

Any functionality that they remove needs to be AT THE SAME TIME replaced with a solution. This is silly. They should just break spellbooks hiding abilities now because it's "unsafe".

Perhaos JASS needs to be removed because using it can cause crashes.

 

[Dr Super Good]

They should just break spellbooks hiding abilities now because it's "unsafe".

Hidden spellbook is almost certainly safe. It does not try to manipulate random memory addresses.

Perhaos JASS needs to be removed because using it can cause crashes.

JASS should be fixed so as not to crash by making the unsafe natives safe. For example Player(16) or any other invalid player number should return null instead of trying to access arbitrary memory addresses.

 

[DracoL1ch]

Hidden spellbook is almost certainly safe. It does not try to manipulate random memory addresses.

did u ever tried to read the exploit? there's bug with counter which allowed button pos to become 0,0, regardless any condition. nothing like memory corruption or so

 

[Dr Super Good]

did u ever tried to read the exploit? there's bug with counter which allowed button pos to become 0,0, regardless any condition. nothing like memory corruption or so

Then why did it crash macs? And some people reported other values caused crashes. Crashes mean something unsafe is happening.

 

[DracoL1ch]

Then why did it crash macs? And some people reported other values caused crashes. Crashes mean something unsafe is happening.

because it macs. on top of innate crashes there's macs, its been like that whole time. wanna crash-proof stuff? pick linux, build it up. pick windows 7, set it up. dont pick mac/win10 if you wanna play oldschool games, is htat simple?
most likely game tried to render button somewhere out of screen and that turned out to be bad idea. thing is, it worked 100% flawlessly with some given x/y values.

 

[Dr Super Good]

wanna crash-proof stuff? pick linux

...

dont pick mac/win10 if you wanna play oldschool games

Windows 10 works well for most well written old school games. It even ran WC3 before all the patches, just with gamma control disabled and some performance problems as a result of the deprecated graphic pipeline used.

It is mostly games which relied on DRM that Windows 10 has problems with.