Berserker Rage 1.1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Berserker Rage 1.1 | Reviewed by Maker | 18th Feb 2013

Needs Fix

Required changes Abilities must support levels Delete the "And - All (Conditions) are true". Put the conditions directly under "If - conditions" Triggering unit is in group condition is not needed If the unit is dead, remove it from the group Check (BerserkerRage_UnitGRP is empty) Equal to True only after you remove a unit from the group If the unit gains permanent strength bonus while the spell is active, it will lose the gained strength when the spell is over Suggested changes The loop could update a bit less often

[td]
[/td]

Old review

02:32, 9th Feb 2013
Magtheridon96:

• Constant values like the strength bonus max should be configurable in the Init trigger so users don't have to modify your spell code directly. This will also make the modification of the spell much easier.
• (Last created hashtable) should be changed. Use BerserkerRage_Hash instead.
• In the Start trigger, you should only attempt to turn on the trigger if a unit was added successfully to the group.
• Casting unit -> Triggering unit
• In the loop trigger, you should store the picked unit into a variable at the top of the Loop - Actions of the Unit Group picker. Repeating it is inefficient. To get rid of Key((Picked unit)), what you would need to do is use an integer variable and set it as follows:
  
  Action

  • Custom script: set udg_TempInteger = GetHandleId(udg_TempUnit)
  This is assuming TempUnit is a unit variable set to (Picked unit) just above that line of code.
  TempInteger is, you guessed it, an integer variable.
• You can use proper, relevant durations here. Instead of using 100 and 30, and subtracting 1, you can subtract 0.1. This will make it easier for you because when you put the duration up for configuration in the Init trigger, you won't have to instruct the user to multiply it by 10.

 

[Tank-Commander]

You reference "Last created hashtable" needs a configuration setup for strength boost/subtraction (and duration) You also should cache (triggering unit) and (picked unit) you also reference "casting unit" don't bother go straight with your cached (triggering unit)

Really simple, prehaps when strength is increased, you can store the amount that's increased in your hashtable, then simply subtract that value rather than a block amount? would make it easier to configure and control

 

[Rasha92]

Ok, i will try fixing that.

 

[Chaosy]

quite simple but I guess it's good enough I don't find anything wrong with the code.

 

[Doomlord]

What if the unit dies while having the bonuses? You don't seem to have a function to cover that.

 

[Rasha92]

What if the unit dies while having the bonuses? You don't seem to have a function to cover that.

That is something i didn't think of... I will try fixing it. Thanks for noticing.

 

[Wolf_Wing]

Rash92,they are right

 

[Rasha92]

Rash92,they are right

Didn't say they aren't.

 

[Wolf_Wing]

nah...... now is good i think i give you 3/5
but why you increase the strength of hero +1 every 0.03 not +70 every unit cast???

 

[Doomlord]

You still haven't covered the unit death event. Just add a secondary death-check condition under

• BerserkerRage_Duration Less than or equal to 0.00

 

[Rasha92]

Ahhh yes, forgot about that one. Fixing.

 

[Wolf_Wing]

Rasha92,but why you increase the strength of hero +1 every 0.03 not +70 every unit cast???

 

[Rasha92]

Rasha92,but why you increase the strength of hero +1 every 0.03 not +70 every unit cast???

What i want from spell is that it increace Strength periodicly, not to just give huge burst of strength. And its not fixed amount to 70 anymore, it can be modified now.

You still haven't covered the unit death event. Just add a secondary death-check condition under

• BerserkerRage_Duration Less than or equal to 0.00

I tryed puting that condition, but its being ignored.
And without that condition unit still get back to normal strength.

 

[Doomlord]

After being killed?

 

[Rasha92]

Yes... It still get bonus and back to normal strength while dead.

 

[Doomlord]

Interesting. Nice work then

 

[Rasha92]

Thanks.