Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
13:41, 1st Jun 2011
Maker:
Separate the visibility modifier actions from the hashtable creation trigger.
You don't have to null globals.
You could store the handle id's into integers and use the integer instead of calling Key(unit) function repeatedly.
You're overwriting the position stored in the hashtable, thus causing leaks.
Set the dummies to can't raise, does not decay.
The looping trigger should be initally off and turned off when no active instances of the spell are on.
IcemanBo: Too long as NeedsFix. Rejected.
Reviewed by Maker, Dragon Breath v1.1, 16th Jul 2012
Required changes
Suggested changes
- Add importing instructions
- You can get stuck in the middle of buildings and trees
after the dragon form ends
- Remove upgrades used from dummies
- Locust is enough making dummies invulnerable,
no need for separate invulnerability ability- Generally abilities have the same learn/use hotkey
- Check number of units in group only after you remove a unit
from the group, not during every loop
13:41, 1st Jun 2011
Maker:
Separate the visibility modifier actions from the hashtable creation trigger.
You don't have to null globals.
You could store the handle id's into integers and use the integer instead of calling Key(unit) function repeatedly.
You're overwriting the position stored in the hashtable, thus causing leaks.
Set the dummies to can't raise, does not decay.
The looping trigger should be initally off and turned off when no active instances of the spell are on.