Moderator
M
Moderator
12:10, 10th Jun 2011
-Kobas-:
Status: Approved
Fix memory leaks pls.
-Kobas-:
Status: Approved
Fix memory leaks pls.
(5 ratings)
I really dont want to sound underwhelming, trust me that is not my goal but this map has very simplified skills. Every skill does standard damage... bro this concept of standard damage is old... skills effects/damages etc should scale with stats is my opinion.
Everything looks too simple? the terrain? the heroes skins?
I didnt check any items cause heroes were enough for me to not care but from a quick look i didnt notice anything special that stands out.
yes, it might be a bit confusing, but the last time i played the map online i noticed that people bought the recipes without noticing that it does nothing, so they had the recipe in their inventory and wondered why they go no stats of it. With the scroll icon it should be clear that it is just an upgrade item.It's not a good idea for recipes to look like a scroll, especially if more look the same. It's confusing and annoying. I suggest changing the icon to the that of the final item.
Or just use item icons and write RECIPE somewhere in the item/recipe's title.With the scroll icon it should be clear that it is just an upgrade item.
Well Arohk, every time you make a unit group, make something at a point, or order something to move to a point, that creates a memory leak.i have seen the map crash because of memory leaks when wtii played it ,
but i dont know how i could possibly fix that
Well Arohk, every time you make a unit group, make something at a point, or order something to move to a point, that creates a memory leak.
This location/unit group does not get removed from the map's memory upon play.
Over time, and with more people playing, there will be more of these leaks happening. This in turn slows things down a lot, especially for people with older computers.
Here's a quick guide on how to remove these leaks from your triggers. It mostly involves using temporary variables and custom scripts:
Things That Leak
As for a fatal crash, well. That could be any number of other things. It's not necessarily related to leaks, but could be like, a divide-by-zero function or some random thing overlooked in your triggers. Hell, I once had a unit pick up a powerup item in my map which caused a fatal error.
Yes, that trigger would be an issue. For that, it's not hard to fix the leak.
For the groups, I use a unit group variable like "TempGroup" and a point variable like "TempPoint"
and do something like this:
i could always use the opinion from someone else, i keep overlooking stuff and then i have to upload the map again and again ^^The triggers are looking good now, Arohk. I haven't had a chance to try it recently between work and stuff. However, I'll review your map when I get the time.
ITEMS:
-Consumable items doesn't stack in 2017.
how many potions do you want to carry around? you already get 3 when you buy them
-The rate of selling items equals the rate of buying items. Intentional?
yes, i got a critique that if you buy the wrong recipe you can't sell it so i changed that, but upgraded items still give you less gold back than the original cost because of the items you required to upgrade.
-There are still grammar errors in the items' descriptions.
Yes, my apoligies, english is not my first language and a lot of tooltips are still old from when my english was worse,
there are a lot of tooltips and it is a lot go go through again, but everytime i change something i try to fix some of it.
-There are grammar errors in the shops's names.
probably.
-I see the project supports unique items then you should create a system which removes item and returns money if you bought 2nd unique item.
you can still sell it back for full cost. see above.
-No chests to keep items.
hire a worker, they can hold 6 items.
-"The non-percentage movement speed bonus does not stack" is not a correct remark. The system chooses the largest mov.speed caused by worn items.
yes they don't stack, the game takes the highes value obviously? i don't see the problem.
-What is the difference between the Lucky Charm bonus and any dodge bonus?
miss/dodge, same thing.
-The dodge bonuses aren't stack there is no remark about it.
that's just how warcraft works, game takes the highest value.
-The critical bonuses aren't stack. there is no remark about it
i am certain that critical hits stack just fine, if you wear several items with crit chance you see much more and higher crit numbers sometimes.
.
-Why the Footman Helmet and the Sobi Mask has a large description about hero's game constants? I thought you can see them just putting a cursor on the attribute picture.
you can not see these % values on hero stats, sorry for giving players this information? >.>
-Almost all items has standard-like bonuses and abilities with slightly changed values. The only non-standard is the Demonic Wings reducing armor.
i think you missed the Voodoo shop, there are items i called "cursed items" those are pretty special.
-Very simple recipes. There is only 1 recipe which requires 3 items. (Intentional?)
yes, back then the recipies were a lot more complicated , i simplified them down for convenience of the players.
-You can't wear more than 1 type of weapon but you can buy a lot of Spears. Do you hate spears? If yes then link me the site of the spear haters. i'd like to join there.
a spear only gives you damage but no other additional ability unlike the sword or mace, having 6 maces and stunlocking everyone with bash proccs would be terrible.
-What does the Holy Aura do? I mean i know but description doesn't say anything while I have the buff.
The Item 'Halo' explains what Holy aura does.
CAMERA SYSTEM:
-I think it's better to create commands where you type in the chat the camera height (or reset camera without swinging it). The current system seems pointless.
You can always use the "Zoom shop" with a worker/acolyte as well.
HEROES:
-Why not to make tavern system of a choosing heroes? At least you can repick heroes infinite number of times.
i stricly did not want a tavern system, everyone can do that.
-After repicking hero the items, it's level (all its progress in shorts) doesn't reseted. I can easily drop starting items from all heroes and it'll give me a giant advantage.
the starting items are mostly worthless, if you want to waste your time getting this rune from every hero , go ahead , it is not game breaking in my opinion.
Repicking a Hero will cost you one level every time.
-There are still grammar errors in the spells' descriptions.
i agree, as mentioned above, fixing it every now and then.
-The portals of the Black Mage upon the repicking don't removed.
yeah, maybe an oversight by me but doesn't realy matter because other heroes can't use them anyway, i can fix that in the future.
-The Orc-Warlock can't cast the Fire Chaplet on self. There is no remark in the spell description.
you're too picky ^-^, i think that was making the ability too strong.
-The Shieldwall ability gives me the ability which is set on wrong position.
it is at the wrong position only if you did not learn all other abilities at least once first, this is because of a space limitation, the game will push another ability out, believe me i broke my head about that a lot already.
-No hotkey for learning the Attribute bonus
you're too picky ^-^
TERRAIN:
Flying trees on cliffs look ugly.
I spend most of the time recently on fixing memory leaks and other smaller bugs, a terrain improvemnt could be done sure.
Prons:
-Interesting system of building base.
-I see here are triggered spells combined with standard ones.
-Intuitive system of combining items. Because of colouring names you can easily find that do you need.
Is it protected against ranged/blink?If you're afraid of losing your worker, you can move him to the resurrection stone, enemy players can not enter this area.
Yeah, your coloring text system is more convinient I'll take this idea for my project.i can see how people always struggle to find a certain item or shop.
But you can use damage detection system where you can use custom cleave.If you give a Cleave ability to an item it will work but the hero will always use the "slam" animation and that looks kinda crappy.
Imagine this cursed system in the popular AoS (like DoTA) where dickheads fighting against dickheads and everyone wishes death to each other.Killing someone else with the cursed item? what a dick move