7 November 2015
Bribe: Rejecting due to the status of this resource being "needs fix" for years.

20:03, 16th Jun 2010
Hanky:
Your spell is just too simple since the main job is doing the damage detection system by weep. Also you got some leaks in your triggers. Fix those issues. After you have fixed them message me or one of the other spell moderators.

Oh my bad, I forgot the triggers.

You don't need null a variable in gui.

Also i don't understand why 2 triggers, one to check when damage happen and other which check when attack happen.. why not just one?

EDIT: and use tags, not print screen

Well i think you saw wrongly. 1 is Open Wounds and the other is Feast. Two different skills.

i'm sorry, i don't dl the map and don't read the trigger name D:

but why one based on damage dealt and other based on attack?
you know the event "An unit is attacked" can be bugged if someone order unit to attack much times

Well, Feast is Lifesteal on attack while Open Wounds is Lifesteal on any form of damage dealt on the unit. That's why they are based off differently. If I were to base off Feast on damage, it would be hard to maintain using the GUI DDS system made by Weep as I have to add the attacking and attacked unit to a group; many units can be damaged at that point of time.

Well... i really don't like the an unit is attacked event, but is my opinion, you don't need to change it just because i say... but fix the leak, every second you leak 10 times an unit group.

<pick every (units in (played map area))>

and remove the null things in trigger, is total useless.

Also you don't need to use variable to every unit, but this ins't a problem

Ok thanks for telling me about the leak.

Don't use custom values, they can be buggy and are slower then a unit array (I think)

Don't triple post, please. ^^

custom values are very valuable and should be used for a really complex spell - not for something like that
the spell is extremely bad coded (very low efficiency, you null unit and real variables which don't leak, you leak groups, you pick all units in the map 10 times per second)

• Feast
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Level of Feast for (Attacking unit)) Greater than or equal to 1
  • Actions
    • Set Temp_U = (Attacking unit)
    • Set Temp_U2 = (Attacked unit)
    • -------- Below is a example condition. If you want to have conditions, just put all the remaining triggers at the bottom in the Then sections. --------
    • -------- Put the units that you want Feast to not affect as False. --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Temp_U2 is A structure) Equal to False
      • Then - Actions
      • Else - Actions
    • -------- Replace Lifesteal values here. Current formula: 3+1xLevel%, 4/5/6/7%. --------
    • Set Lifesteal = ((0.03 + (0.01 x (Real((Level of Feast for Temp_U))))) x (Life of Temp_U2))
    • Special Effect - Create a special effect attached to the origin of Temp_U using Abilities\Spells\Undead\VampiricAura\VampiricAuraTarget.mdl
    • Unit - Cause Temp_U to damage Temp_U2, dealing Lifesteal damage of attack type Spells and damage type Normal
    • Unit - Set life of Temp_U to ((Life of Temp_U) + Lifesteal)
    • Special Effect - Destroy (Last created special effect)
    • Custom script: set udg_Temp_U = null
    • Custom script: set udg_Temp_U2 = null
    • Custom script: set udg_Lifesteal = 0

the if does not make sense

all in all this spell can be done a lot better and easier

Do remember to see previous posts before you post as someone mentioned about the leak. Furthermore, the "if" was an example condition, if you would to spot the trigger comments. I was trying to people using my map that if they want conditions to add them as followed.

Hashtable > custom values, period.

Also don't use images for the code use trigger tags and paste the code.

Kuwagata said:

Do remember to see previous posts before you post as someone mentioned about the leak. Furthermore, the "if" was an example condition, if you would to spot the trigger comments. I was trying to people using my map that if they want conditions to add them as followed.

Click to expand...

that it was mentioned before was right but you still did not fix it

and your condition is senceless and slow

• Feast
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Attacked unit is A structure) Equal to False
    • (Level of Feast for (Attacking unit)) Greater than or equal to 1
  • Actions

and the event is not good either
it will trigger everytime a unit is ATTACKED
e.g. the attacking unit will leach life everytime you press "stop" or order a new attack which is very likely to be abusable

not to mention the idea....
can't you think of something new?

useless to me, its not like dotA's, i just spam the hold position without actually hits the target i already get the hit points.

Feast.... works on any unit\building 0_o. I hit tower and regenerate hp. Wtf?