Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
IcemanBo: Too long as NeedsFix. Rejected.
Reviewed by Maker, Dash Strikes v1.02, 11th Jan 2012
Required changes:
- You should check whether the effects are stored, and then not create new ones if they exist. Use boolean, Hashtable - value exists
- You're saving the handle id of TempUnit thrice
- Remove the lines where you clear child hashtables for keys left, right, origin, foot and chest. You're not storing anything with those parent keys
- You could store triggering unit/picked unit, Key(Triggering unit) and Key(Picked unit) into variables, and use the variables
- Delete the actions that have custom script functions in comments
- You don't need to store then handle of the unit for itself
- You don't need to save the handle of a group for a unit in the looping trigger, you have already saved it in the cast trigger
- Do the caster is dead check when you check TempInt
Reviewed by Maker, Dash Strikes, 3rd Jan 2012 |
|