Moderator
M
Moderator
14:11, 15th Nov 2009
TriggerHappy187:
Even with all of the points below fixed, we don't need another one of these. Sorry.
PM me if you felt I reviewed this wrong.
TriggerHappy187:
Even with all of the points below fixed, we don't need another one of these. Sorry.
PM me if you felt I reviewed this wrong.
- This is not vJass.
- Inline your conditions function.
- You leak two handle pointers (need to null the item and the unit).
- You should store the item id to avoid so many function calls.
- Your using lame BJ's.
- You can directly initialize your locals instead of setting them after their declarations.
if ( ITEMLOOP < 7 ) then
is completely useless.