Will this leak?

[sadvisor]

• Test
  • Events
    • Time - Every 0.60 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units of type Antonidas) and do (Unit - Order (Picked unit) to Human Archmage - Blizzard (Position of (Random unit from (Units in (Playable map area)))))

 

[-ALPHA-]

You should at least set a point variable before that action.

(I'm sure the better trigger folks will give you more/better answers.)

 

[Xarxos]

Well, I think that will not work the way you want to since Blizzard is a channeling spell, and if the casters are given a new order every 0.60 seconds, then they won't have time to use the spell at all. I'm not sure what you're trying to do, but if you want them to actually cast the spell you should use a bigger time interval.

Also, I'm not sure, but I think that using random units as targeting points might not work, though I don't know for sure.

 

[manstie]

I would make a condition that the picked unit isn't the spell caster.

• No more leaks
  • Events
    • Time - Every 0.6 seconds of game time.
  • Conditions
  • Actions
    • Set Group = Units of type Antonidas
    • Set Point = Position of (Random unit from (Units in (Playable map area))))
    • Unit Group - Pick every unit in Group and do (Unit - Order (Picked unit) to Human Archmage - Blizzard Point
    • Custom script: call DestroyGroup(udg_Group)
    • Custom script: call RemoveLocation(udg_Point)

 

[Squiggy]

• Set Group[0] = (Units of type Antonidas)
• Set Group[1] = (Units in (Playable map area))
• Set Point = (Position of (Random unit from Group[1]))
• Unit Group - Pick every unit in Group[0] and do (Unit - Order (Picked unit) to Human Archmage - Blizzard Point
• Custom script: call DestroyGroup(udg_Group[0])
• Custom script: call DestroyGroup(udg_Group[1])
• Custom script: call RemoveLocation(udg_Point)

^_^

 

[Reaper2008]

Why do all GUI spells use 1 array with 100 values? Just to avoid creating those variables? Is it worth making your code unreadable? Squiggy, you even used an array for like 5 lines of code.

 

[manstie]

Lol? Squiggy? Your Group[1] serves no purpose in that trigger, silly.

• Lol Squiggy (this way)
  • Events
    • Time - Every 0.60 seconds of game time.
  • Conditions
  • Actions
    • Set Group = Units of type Antonidas
    • Set Group2 = (Units in (Playable map area))
    • Set Point = Position of (Random 1 unit from (Group2))
    • Unit Group - Pick every unit in Group and do (Unit - Order (Picked unit) to Human Archmage - Blizzard Point
    • Custom script: call DestroyGroup(udg_Group)
    • Custom script: call DestroyGroup(udg_Group2)
    • Custom script: call RemoveLocation(udg_Point)

 

[Reaper2008]

That's exactly what he said.

PS @sadvisor: Avoid these orders, use IssuePointOrder (or whatever it is in GUI) instead.

 

[manstie]

No it isn't. Use your eyes.
Well, lol he bloody edited it now. -.-

 

[Squiggy]

One array is still better than having two variables - it saves 8 byte

Lol? Squiggy? Your Group[1] serves no purpose in that trigger, silly.

I have a mission for you, fellow knight.
Go outside, discover the world of coding and before you don't understand vJass well enough, don't talk to me until then

I wish you all the luck

 

[Hugget Sukker]

• Test
  • Events
    • Time - Every 0.60 seconds of game time
  • Conditions
  • Actions
    • Custom script - set bj_wantDestroyGroup = true
    • Set TempLoc = Position of (Random unit from (Units in (Playable map area)))
    • Unit Group - Pick every unit in (Units of type Antonidas) and do (Unit - Order (Picked unit) to Human Archmage - Blizzard (TempLoc)
    • Custom script - call RemoveLocation(udg_TempLoc)
    • Custom script - set bj_wantDestroyGroup = false

 

[baassee]

Squiggy is right, others wrong that's it. Period.

 

[Hugget Sukker]

But 1 variable and no leaks, wouldn't that be better than 3 variables? ^^

 

[baassee]

lesser variables doesnt make it better with BJs

 

[sadvisor]

thanks guys.

I've rep-ed you all.

 

[Vulcano]

• Test
  • Events
    • Time - Every 0.60 seconds of game time
  • Conditions
  • Actions
    • Custom script - set bj_wantDestroyGroup = true
    • Set TempLoc = Position of (Random unit from (Units in (Playable map area)))
    • Unit Group - Pick every unit in (Units of type Antonidas) and do (Unit - Order (Picked unit) to Human Archmage - Blizzard (TempLoc)
    • Custom script - call RemoveLocation(udg_TempLoc)
    • Custom script - set bj_wantDestroyGroup = false

bj_wantDestroyGroup is automatically set to false after doing a (GUI/BJ) group iteration.

You leak units in playable map area

 

[manstie]

One array is still better than having two variables - it saves 8 byte


I have a mission for you, fellow knight.
Go outside, discover the world of coding and before you don't understand vJass well enough, don't talk to me until then

I wish you all the luck

Dude, I know you edited that.

 

[Squiggy]

Your lack of win is disturbing

May the power of fail be with you