How do I remove the leaks in this trigger?

[Nordmar]

• Move to Hero
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units of type Inventory) and do (Actions)
      • Loop - Actions
        • Unit - Move (Picked unit) instantly to (Position of player_hero[((Player number of (Owner of (Picked unit))) - 1)])
    • Unit Group - Pick every unit in (Units of type Inventory [Potions]) and do (Actions)
      • Loop - Actions
        • Unit - Move (Picked unit) instantly to (Position of player_hero[((Player number of (Owner of (Picked unit))) - 1)])

I checked the thread about leaks but I am not sure how to delete array leaks like this one. Could someone help me here? Thanks

 

[13oot-Me]

You have to set the units into a group variable, loop through the variable, then add a custom script outside of the loop destroying the variable to prevent the leak. Also you are leaking locations, set the location of your hero to a variable inside the loop as well and also add a custom script at the end to remove the location.

For the group:

• Custom script: call DestroyGroup(udg_YourGroupVariable)

For the location:

• Custom script: call RemoveLocation(udg_YourLocationVariable)

 

[Nordmar]

so I NEED to use variables? can't I do it without?

 

[IcemanBo]

Read: https://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

 

[13oot-Me]

so I NEED to use variables? can't I do it without?

Think of it this way... If you set your hero to a variable with all its arrays, that's the only time you will have to do that, the rest you just call that variable instead. This also makes triggering much easier and much faster.

 

[Nordmar]

alright. Thank you.

• Move to Hero
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Set inventory_unitGroup = (Units of type Inventory)
    • Unit Group - Pick every unit in inventory_unitGroup and do (Actions)
      • Loop - Actions
        • Set inventory_heroLocation = (Position of player_hero[((Player number of (Owner of (Picked unit))) - 1)])
        • Unit - Move (Picked unit) instantly to inventory_heroLocation
    • Custom script: call DestroyGroup(udg_inventory_unitGroup)
    • Custom script: call RemoveLocation(udg_inventory_heroLocation)
    • Set inventory_unitGroup = (Units of type Inventory [Potions])
    • Unit Group - Pick every unit in inventory_unitGroup and do (Actions)
      • Loop - Actions
        • Set inventory_heroLocation = (Position of player_hero[((Player number of (Owner of (Picked unit))) - 1)])
        • Unit - Move (Picked unit) instantly to inventory_heroLocation
    • Custom script: call DestroyGroup(udg_inventory_unitGroup)
    • Custom script: call RemoveLocation(udg_inventory_heroLocation)

this should do the job

 

[13oot-Me]

alright. Thank you.

• Move to Hero
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Set inventory_unitGroup = (Units of type Inventory)
    • Unit Group - Pick every unit in inventory_unitGroup and do (Actions)
      • Loop - Actions
        • Set inventory_heroLocation = (Position of player_hero[((Player number of (Owner of (Picked unit))) - 1)])
        • Unit - Move (Picked unit) instantly to inventory_heroLocation
    • Custom script: call DestroyGroup(udg_inventory_unitGroup)
    • Custom script: call RemoveLocation(udg_inventory_heroLocation)
    • Set inventory_unitGroup = (Units of type Inventory [Potions])
    • Unit Group - Pick every unit in inventory_unitGroup and do (Actions)
      • Loop - Actions
        • Set inventory_heroLocation = (Position of player_hero[((Player number of (Owner of (Picked unit))) - 1)])
        • Unit - Move (Picked unit) instantly to inventory_heroLocation
    • Custom script: call DestroyGroup(udg_inventory_unitGroup)
    • Custom script: call RemoveLocation(udg_inventory_heroLocation)

this should do the job

Looks good, just put the remove location script right after you move the unit, otherwise you only remove one location leak.

 

[Nordmar]

Ah, you are right. Thank you