[Trigger] what the hell, i see no logic why its not creating the unit??

[Slaydon]

Okay, tell me what i do wrong? the effect works excellent, but the units NOT spawning....

• Call from the Death
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Call from the Death
  • Actions
    • Custom script: local effect udg_TempFX
    • Custom script: local group udg_TempGroup
    • Custom script: local location udg_TempLoc
    • Custom script: local unit udg_TempCaster
    • Set TempCaster = (Triggering unit)
    • Set TempLoc = (Target point of ability being cast)
    • Special Effect - Create a special effect at TempLoc using war3mapImported\GrudgeAura.mdx
    • Set TempFX = (Last created special effect)
    • Set TempGroup = (Units within 200.00 of TempLoc)
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) belongs to an enemy of (Owner of TempCaster)) Equal to True
            • ((Picked unit) is Magic Immune) Not equal to True
            • ((Picked unit) has buff Invulnerable) Not equal to True
          • Then - Actions
            • Unit - Create 1 Ghoul for (Owner of TempCaster) at (Position of (Picked unit)) facing (Facing of (Picked unit)) degrees
            • Set Dummy = (Last created unit)
            • Unit - Add a 3.00 second Generic expiration timer to Dummy
            • Unit - Order Dummy to Attack (Picked unit)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Level of Call from the Death for TempCaster) Equal to CallfromtheDeadLevels[2]
              • Then - Actions
                • Unit - Create 1 Ghoul for (Owner of TempCaster) at (Position of (Picked unit)) facing (Facing of (Picked unit)) degrees
                • Set Dummy = (Last created unit)
                • Unit - Add a 3.00 second Generic expiration timer to Dummy
                • Unit - Order Dummy to Attack (Picked unit)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Level of Call from the Death for TempCaster) Equal to CallfromtheDeadLevels[3]
              • Then - Actions
                • Unit - Create 1 Ghoul for (Owner of TempCaster) at (Position of (Picked unit)) facing (Facing of (Picked unit)) degrees
                • Set Dummy = (Last created unit)
                • Unit - Add a 3.00 second Generic expiration timer to Dummy
                • Unit - Order Dummy to Attack (Picked unit)
              • Else - Actions
          • Else - Actions
    • Wait 3.00 seconds
    • Special Effect - Destroy TempFX
    • Custom script: call RemoveLocation(udg_TempLoc)
    • Custom script: call DestroyGroup(udg_TempGroup)

 

[Maker]

Local and udg_ don't mix with the 1.24 patch.

Shadowing globals with locals shouldn't be possible. Just replace all udg_something with...something else, don't use a global variable name.

For example:

local group udg_TempGroup

->

local group g

This is assuming you don't have a global group named g created.

Also

• Unit - Create 1 Ghoul for (Owner of TempCaster) at (Position of (Picked unit)) facing (Facing of (Picked unit)) degrees

Doesn't this leak the position?

 

[RaiN.]

He wont have any use if he does that. He is doing the shadowing in the first place so he can use locals in GUI and not just to have a local variable sittin there lookin pretty at the top.

 

[Maker]

And I quote:

Patch 1.24b

FIXES

- “Shadowing” global variables with local variables no longer is possible.

 

[PurplePoot]

And you may want to do some testing rather than quoting Blizzard, who are not famous for extensively testing their work.

 

[Slaydon]

well, the loc leak, ill fix that in a min

and the locals works

EDIT:

• Call from the Death
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Call from the Death
  • Actions
    • Custom script: local effect udg_TempFX
    • Custom script: local group udg_TempGroup
    • Custom script: local location udg_TempLoc
    • Custom script: local unit udg_TempCaster
    • Set TempCaster = (Triggering unit)
    • Set TempLoc = (Target point of ability being cast)
    • Special Effect - Create a special effect at TempLoc using war3mapImported\GrudgeAura.mdx
    • Set TempFX = (Last created special effect)
    • Set TempGroup = (Units within 200.00 of TempLoc)
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • For each (Integer A) from 1 to 3, do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) belongs to an enemy of (Owner of TempCaster)) Equal to True
                • ((Picked unit) is Magic Immune) Not equal to True
                • ((Picked unit) has buff Invulnerable) Not equal to True
                • (Level of Call from the Death for TempCaster) Equal to CallfromtheDeadLevels[(Integer A)]
              • Then - Actions
                • Set Loc2 = (Position of (Picked unit))
                • Unit - Create 1 CallFromTheDeadUnits[(Integer A)] for (Owner of TempCaster) at (Position of (Picked unit)) facing (Facing of (Picked unit)) degrees
                • Set Dummy = (Last created unit)
                • Unit - Add a 5.00 second Generic expiration timer to Dummy
                • Unit - Order Dummy to Attack (Picked unit)
                • Custom script: call RemoveLocation(udg_Loc2)
              • Else - Actions
    • Wait 3.00 seconds
    • Special Effect - Destroy TempFX
    • Custom script: call RemoveLocation(udg_TempLoc)
    • Custom script: call DestroyGroup(udg_TempGroup)

Still not working


EDIT: I dont know why, but it was because i Local'ed Tempcaster...

 

[Reaper2008]

Shadow only the effect, and do loc + group cleanup before the wait. Don't leave them till then for no good reason.

 

[Slaydon]

omg, how stupid can i be xD