[Trigger] Volcanic Attack need feedback

[Slaydon]

Hi, ive made my first "spell" i think it looks pwnd and could be usefull, but its so simple. So i need some feedback first.

Code

• Spell
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Volcanic Attack
  • Actions
    • -------- - --------
    • -------- Setting Variables --------
    • Set TempCaster = (Triggering unit)
    • Set TempLoc = (Target point of ability being cast)
    • Set TempGroup = (Units within 200.00 of TempLoc)
    • -------- - --------
    • -------- Some Fx --------
    • Special Effect - Create a special effect at TempLoc using Abilities\Spells\Other\Volcano\VolcanoDeath.mdl
    • Set TempFX = (Last created special effect)
    • Special Effect - Destroy TempFX
    • -------- - --------
    • -------- Unit Group --------
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) belongs to an enemy of (Owner of TempCaster)) Equal to True
            • ((Picked unit) is Magic Immune) Not equal to True
            • ((Picked unit) has buff Invulnerable) Not equal to True
          • Then - Actions
            • -------- - --------
            • -------- FX --------
            • Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Weapons\SearingArrow\SearingArrowMissile.mdl
            • Set TempFX = (Last created special effect)
            • Special Effect - Destroy TempFX
            • -------- - --------
            • -------- Edit Damage --------
            • Unit - Cause TempCaster to damage (Picked unit), dealing (Random real number between ((Real((Level of (Ability being cast) for TempCaster))) x 30.00) and ((Real((Level of (Ability being cast) for TempCaster))) x 31.00)) damage of attack type Spells and damage type Normal
            • -------- - --------
          • Else - Actions
    • -------- - --------
    • -------- REMOVING LEAKS --------
    • Custom script: call DestroyGroup(udg_TempGroup)
    • Custom script: call RemoveLocation(udg_TempLoc)
    • -------- - --------

 

[takakenji]

it's pretty good for your first spell, especially since it has no leaks. Good Job!

 

[Slaydon]

well thanks, i myelf find it very usefull

 

[Dr Super Good]

Efficency... is near 0. Try saving some values to globals instead of recalculating them each time.

 

[.Ragnaros]

What you mean with efficiency near 0? Anyway, give him a chance, its his first spell, maybe a happy critic from a spell moderator would make him happy ^^

 

[Slaydon]

well, maybe the test map could be better, but i dont know what to improve =/

 

[Maker]

What you mean with efficiency near 0? Anyway, give him a chance, its his first spell, maybe a happy critic from a spell moderator would make him happy ^^

trigger

• ...Random real number between ((Real((Level of (Ability being cast) for TempCaster))) x 30.00) and ((Real((Level of (Ability being cast) for TempCaster))) x 31.00))

He's calculating the ability level twice. It should be put to a variable I believe.

trigger

• Temp_Real = Real((Level of (Ability being cast) for TempCaster))
• ...Random real number between (Temp_Real) x 30.00) and (Temp_Real)) x 31.00))

Or perhaps even better to set the numbers to variables when you level up the skill.

That way you don't calculate them each time the spell is cast.

I would also question the randomizing between 30 and 31. The difference is only 3 (or ~3,5 %) damage at ability level 3.

Why not make the values further apart or just remove the randomizing altogether.

 

[wolfman]

You dont have to set the triggering unit to a variable!! You dont have to set the special effect to a variable!! Only do this if you have a wait function. You dont even have to set triggering unit if you have to wait, only if it must be used in a separate trigger.

 

[Dr Super Good]

Sigh, variable references are faster than native references, keep that in mind. This there is a point whereby setting a variable to a native and referencing that is better than calling the native each time.

 

[wolfman]

hmm i never knew that. I would have thought the opposite was true lol. i guess you learn new stuff every day
And yes, i will keep that in mind thanks!

 

[Slaydon]

Added another effect, + working on another spell, UNDER CONSTRUCTION.

New FX Code

• Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Human\Polymorph\PolyMorphTarget.mdl

 

[Maker]

The lamb sound effect doesn't fit the spell IMO.

 

[Slaydon]

hm, didnt have sound on xD, Any ideas on how to fix it? :/

 

[Maker]

I used the same special effect for a while, and always tested without sounds. It took me by surprise too.

I don't know a fix for it however, use another special effect is all I can think of.