Approved
- Joined
- May 26, 2009
- Messages
- 1,829
I can see a lot of effort went into making this map but frankly this isn't the section for it - this isn't a spell submission, it's an unfinished map submission
regardless after a quick skim thought I'd point out a few things as if this were the proper section
- The "A unit is attacked" event is abuse-able, use a damage detection system instead
- Use SetUnitX/Y instead of move unit instantly when possible
- None of your spells have any configuration
- I'd generally advise against utilizing floating text in spells as it can be seen through the fog of war
- Don't use custom values of units to index things, use either a unit indexer or do it with variables instead
- Store values referenced a lot (such as triggering unit) in temporary variables for faster access
- Don't use timer speeds like every 1 second or 0.02 -> the latter is too slow (has up to 0.99 second latency) and 0.02 is too fast (no need to have things run 40 times per second, you won't notice it) generally speaking we say use 0.03 (or 1/32)
- Dummy units should be owned by a neutral player as to not mess up scorescreens
- Damage source of abilities should be the caster, not dummy units
There is more but there's a lot of code to go through and it's kind of pointless since this isn't the section to be uploading unfinished work in anyway
regardless after a quick skim thought I'd point out a few things as if this were the proper section
- The "A unit is attacked" event is abuse-able, use a damage detection system instead
- Use SetUnitX/Y instead of move unit instantly when possible
- None of your spells have any configuration
- I'd generally advise against utilizing floating text in spells as it can be seen through the fog of war
- Don't use custom values of units to index things, use either a unit indexer or do it with variables instead
- Store values referenced a lot (such as triggering unit) in temporary variables for faster access
- Don't use timer speeds like every 1 second or 0.02 -> the latter is too slow (has up to 0.99 second latency) and 0.02 is too fast (no need to have things run 40 times per second, you won't notice it) generally speaking we say use 0.03 (or 1/32)
- Dummy units should be owned by a neutral player as to not mess up scorescreens
- Damage source of abilities should be the caster, not dummy units
There is more but there's a lot of code to go through and it's kind of pointless since this isn't the section to be uploading unfinished work in anyway
