Vast Plane

[Moderator]

14:45, 14th Sep 2009
PurplePoot: It was fine before; no reason to think it no longer is.

 

[Deuterium]

I'm too sleepy to focus on the code... but this does actually pick ONLY the units inside the triangle eh? I mean it's made by Hanky, so it should

 

[Hanky]

Yes it just pick the units in the triangle or whatever you setted with the constants...

 

[MortAr]

Remove the blue from the discription, I need to select the text with the mouse and read it... It burns my eyes :S

I will test it later, bb.

 

[Lambdadelta]

The Triangle Area, is a bit off, a Peasant standing just on the lightning itself isn't picked up.

Btw, escape-refresh for testmap please!

set gg_trg_Magical_Trap=CreateTrigger( )
Local trigger for easier importing please.

    loop
        call TriggerRegisterPlayerUnitEvent(gg_trg_Magical_Trap, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, MainFunctions_filter)

        set i = i + 1
        exitwhen i == 12
    endloop

12? I want a neutral passive player to cast it ?

 

[Hanky]

The spell is pretty old never thought of rescripting it. I just updated it so that it work with 1.24...

The Triangle Area, is a bit off, a Peasant standing just on the lightning itself isn't picked up.

Didn't I said that?, Everthing inside the triangle and not everything what is standing on the line of the triangle... The unit have to be in the triangle to get recognized.

 

[Deuterium]

Well, great job anyways Hanky and let us see some new inventions rather then updates ! =)

 

[Anachron]

I have seen this before, I am pretty sure, why didn't you upload this earlier? This is atleast one year old, if I remember correctly.

 

[Paladon]

This spell is really around a year old, won the first place of a Spells and Systems Mini Contest and is generally quite awesome.
I agree with the local trigger thing, still

 

[Hanky]

I have seen this before, I am pretty sure, why didn't you upload this earlier? This is atleast one year old, if I remember correctly.

Since Im pretty busy during the week I had no time to fixing it for 1.24 so it took some more time to fix it.

I agree with the local trigger thing, still

Ya maybe I'll update the spell...

 

[Linaze]

I fixed so it uses local trigger t for you Hanky, to save you the trouble (yeah I was bored). The updated map is attached to this post.

Also, for your init function, couldn't you do the following instead of using a loop?

call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
call TriggerAddCondition(t,Condition(function SpellIdCondition))

And the condition would look a little something like this:

function SpellIdCondition takes nothing returns boolean
    return GetSpellAbilityId() == yourspellidhere
endfunction

(The attached map does not contain an edited init function apart from it using local trigger t)

 

[Hanky]

I fixed so it uses local trigger t for you Hanky, to save you the trouble (yeah I was bored). The updated map is attached to this post.

Also, for your init function, couldn't you do the following instead of using a loop?

call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
call TriggerAddCondition(t,Condition(function SpellIdCondition))

And the condition would look a little something like this:

function SpellIdCondition takes nothing returns boolean
    return GetSpellAbilityId() == yourspellidhere
endfunction

(The attached map does not contain an edited init function apart from it using local trigger t)

Thanks that you want to help me but there is some more stuff to improve. There a list:
- local trigger bla
- triggeraction could be replaced by boolexpr... since it's faster as we all know
- btw I don't see your point with the BJ thingy because the loop would execute it much faster than calling the bj function
- making really all functions private
- some small parts could be maybe improved (hasn't looked at the script for ages, just made this little hotfix so it's working with 1.24)
...

Well you see there are some things to improve and I know them but how I already said in the spellpack thread I got currently less time. Just wait till weekend or maybe the weekend after till I updated the script...

 

[Linaze]

I am not a good Jasser at all, it's just that like every spell uses the BJ, so I assumed it was better, somehow.

 

[Hanky]

Sure there's no problem with using the BJ since it's just called once during the map init but there's no difference of using the loop or the bj

 

[hapykiller999999]

Will this replace some of my older spells?