1. Are you planning to upload your awesome spell or system to Hive? Please review the rules here.
    Dismiss Notice
  2. Icon Contest #17 - Results are out! Step by to congratulate our winners!
    Dismiss Notice
  3. Melee Mapping Contest #2 - Results are out! Step by to congratulate the winners!
    Dismiss Notice
  4. C'thun has spoken! Texturing Contest #29 - Results are published - check 'em out!
    Dismiss Notice
  5. Join Terraining Contest #19 and witness the aftermath!
    Dismiss Notice

Vast Plane

Submitted by Hanky
This bundle is marked as approved. It works and satisfies the submission rules.
MUI: Yes
vJASS: Yes

To use this spell you need the JassNewGenPack

[​IMG]

Vast Plane

Establishes 3 wards, which bind themselves up to a plain. The plain constantly moves upwards until it reaches it max powerlevel and drops down to zero. Deals various damage on falling units and decreases their movementspeed by 40% during the unit is on the plain.


Thanks to Clan NgO as always and of course special greetz to:
- JonNny
- Darkt3mpl3r
- WaRadius

Keywords:
Hanky, NgO, TDG
Contents

Vast Plane (Map)

Reviews
Moderator
14:45, 14th Sep 2009 PurplePoot: It was fine before; no reason to think it no longer is.
  1. 14:45, 14th Sep 2009
    PurplePoot: It was fine before; no reason to think it no longer is.
     
  2. Deuterium

    Deuterium

    Joined:
    Mar 17, 2009
    Messages:
    1,301
    Resources:
    2
    Spells:
    1
    Tutorials:
    1
    Resources:
    2
    I'm too sleepy to focus on the code... but this does actually pick ONLY the units inside the triangle eh? I mean it's made by Hanky, so it should :p
     
  3. Hanky

    Hanky

    Joined:
    Jan 15, 2007
    Messages:
    353
    Resources:
    4
    Maps:
    1
    Spells:
    3
    Resources:
    4
    Yes it just pick the units in the triangle or whatever you setted with the constants...
     
  4. MortAr

    MortAr

    Joined:
    Feb 25, 2009
    Messages:
    1,771
    Resources:
    7
    Icons:
    6
    Packs:
    1
    Resources:
    7
    Remove the blue from the discription, I need to select the text with the mouse and read it... It burns my eyes :S

    I will test it later, bb.
     
  5. Lambdadelta

    Lambdadelta

    Joined:
    Jul 6, 2009
    Messages:
    730
    Resources:
    1
    Maps:
    1
    Resources:
    1
    The Triangle Area, is a bit off, a Peasant standing just on the lightning itself isn't picked up.

    Btw, escape-refresh for testmap please!

    set   gg_trg_Magical_Trap=CreateTrigger( )

    Local trigger for easier importing please.

    Code (vJASS):
        loop
            call TriggerRegisterPlayerUnitEvent(gg_trg_Magical_Trap, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, MainFunctions_filter)

            set i = i + 1
            exitwhen i == 12
        endloop

    12? I want a neutral passive player to cast it o_O?
     
  6. Hanky

    Hanky

    Joined:
    Jan 15, 2007
    Messages:
    353
    Resources:
    4
    Maps:
    1
    Spells:
    3
    Resources:
    4
    The spell is pretty old never thought of rescripting it. I just updated it so that it work with 1.24...

    Didn't I said that?, Everthing inside the triangle and not everything what is standing on the line of the triangle... The unit have to be in the triangle to get recognized.
     
  7. Deuterium

    Deuterium

    Joined:
    Mar 17, 2009
    Messages:
    1,301
    Resources:
    2
    Spells:
    1
    Tutorials:
    1
    Resources:
    2
    Well, great job anyways Hanky :) and let us see some new inventions rather then updates :p! =)
     
  8. Anachron

    Anachron

    Joined:
    Sep 9, 2007
    Messages:
    6,167
    Resources:
    66
    Icons:
    49
    Packs:
    2
    Tools:
    1
    Maps:
    3
    Spells:
    9
    Tutorials:
    1
    JASS:
    1
    Resources:
    66
    I have seen this before, I am pretty sure, why didn't you upload this earlier? This is atleast one year old, if I remember correctly.
     
  9. Paladon

    Paladon

    Joined:
    Dec 6, 2007
    Messages:
    2,083
    Resources:
    42
    Icons:
    28
    Packs:
    2
    Spells:
    12
    Resources:
    42
    This spell is really around a year old, won the first place of a Spells and Systems Mini Contest and is generally quite awesome.
    I agree with the local trigger thing, still :p
     
  10. Hanky

    Hanky

    Joined:
    Jan 15, 2007
    Messages:
    353
    Resources:
    4
    Maps:
    1
    Spells:
    3
    Resources:
    4
    Since Im pretty busy during the week I had no time to fixing it for 1.24 so it took some more time to fix it.

    Ya maybe I'll update the spell...
     
  11. Linaze

    Linaze

    Joined:
    Feb 28, 2007
    Messages:
    2,980
    Resources:
    2
    Models:
    1
    Tutorials:
    1
    Resources:
    2
    I fixed so it uses local trigger t for you Hanky, to save you the trouble (yeah I was bored). The updated map is attached to this post.

    Also, for your init function, couldn't you do the following instead of using a loop?
    Code (vJASS):
    call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(t,Condition(function SpellIdCondition))


    And the condition would look a little something like this:
    Code (vJASS):
    function SpellIdCondition takes nothing returns boolean
        return GetSpellAbilityId() == yourspellidhere
    endfunction


    (The attached map does not contain an edited init function apart from it using local trigger t)
     

    Attached Files:

    Last edited: Sep 7, 2009
  12. Hanky

    Hanky

    Joined:
    Jan 15, 2007
    Messages:
    353
    Resources:
    4
    Maps:
    1
    Spells:
    3
    Resources:
    4
    Thanks that you want to help me but there is some more stuff to improve. There a list:
    - local trigger bla
    - triggeraction could be replaced by boolexpr... since it's faster as we all know
    - btw I don't see your point with the BJ thingy because the loop would execute it much faster than calling the bj function
    - making really all functions private
    - some small parts could be maybe improved (hasn't looked at the script for ages, just made this little hotfix so it's working with 1.24)
    ...

    Well you see there are some things to improve and I know them but how I already said in the spellpack thread I got currently less time. Just wait till weekend or maybe the weekend after till I updated the script...
     
  13. Linaze

    Linaze

    Joined:
    Feb 28, 2007
    Messages:
    2,980
    Resources:
    2
    Models:
    1
    Tutorials:
    1
    Resources:
    2
    I am not a good Jasser at all, it's just that like every spell uses the BJ, so I assumed it was better, somehow.
     
  14. Hanky

    Hanky

    Joined:
    Jan 15, 2007
    Messages:
    353
    Resources:
    4
    Maps:
    1
    Spells:
    3
    Resources:
    4
    Sure there's no problem with using the BJ since it's just called once during the map init but there's no difference of using the loop or the bj ;)
     
  15. hapykiller999999

    hapykiller999999

    Joined:
    Sep 12, 2009
    Messages:
    77
    Resources:
    0
    Resources:
    0
    Will this replace some of my older spells? :D
     
    Last edited: Sep 19, 2009