Units don't get removed as expected

[Marshmalo]

• Arcane Nexus Dies
  • Events
    • Unit - Arcane Nexus 0429 <gen> Dies
  • Conditions
  • Actions
    • Set Crystals01 = (Units in Crystal Destroy 01 <gen> owned by Player 6 (Orange))
    • Unit Group - Pick every unit in Crystals01 and do (Actions)
      • Loop - Actions
        • Unit - Remove (Picked unit) from the game
    • Custom script: call DestroyGroup(udg_Crystals01)

It is supposed to remove all units in unit group Crystals01 when the Arcane Nexus unit dies, however nothing is happening at all.

 

[Drunken_Jackal]

Just a tip, you can make your trigger to this:

• Arcane Nexus Dies
  • Events
    • Unit - Arcane Nexus 0429 <gen> Dies
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in Crystal Destroy 01 <gen> owned by Player 6 (Orange)) and do Unit - Remove (Picked unit) from the game

Something like that for efficiency.
Not sure though.

 

[-Kobas-]

Upload map please.

 

[Mcasdf]

Check the region that it's correct.
Check if it's the correct player color.
Check that it's the correct unit that dies.

 

[Marshmalo]

Ahh its because the units I want removing have the locust ability! I did not realize this ability made units un-selectable via triggers?

These Crystal units still need to un-selectable by players and invulnerable, Does anyone know how I can get around this?

 

[kdh.]

You can't pick Locust units.Maybe you can remove Locust ability and use Selection actions to make it unselectable with new trigger

 

[-Kobas-]

Each time when you create unit with locust ability store it into variable.
Now dunno how much units you want to handle but array can do.

If you have like 5-6 players then do next.

set counter[PlayerNumber] = counter[PlayerNumber] + 1
set locust_unit[ PlayerNumber * 1000 + counter[PlayerNumber] ] = CreateUnit...

when you decide to remove units just do next

loop
exitwhen counter[PlayerNumber] == 0

call RemoveUnit( locust_unit[ PlayerNumber * 1000 + counter[PlayerNumber] ] )

set counter[PlayerNumber] = counter[PlayerNumber] - 1
endloop

Another way is to add unit to unit group, then just remove it when you defeat player.
Another way -> hashtables.

 

[Marshmalo]

Kobas I don't really know enough about triggers to do arrays and hash tables, all sounds very complex to me :s

KDH, your way sounds simpler, how do I make it unselectable via triggers?

 

[Halo7568]

Just manually add every locust unit you want to consider to a unit group upon the unit's creation. Then, when removing units inside "Crystals01", just loop through the aforementioned unit group and check if the unit is in the region before removing the unit.

Locust units can still be part of unit groups. You just have to make sure you add them manually rather than try to find them all at once with a "pick every unit in region" or some such action.

The action would be this for a single locust unit being added to the group after creation:

• Unit Group - Add (Last created unit) to thegroup

Or this if you create n > 1 units:

• Unit Group - Add all units of (Last created unit group) to thegroup

Then removal becomes this:

• Unit Group - Pick every unit in thegroup and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (theregion contains (Picked unit)) Equal to True
      • Then - Actions
        • Unit - Remove (Picked unit) from the game
      • Else - Actions

 

[-Kobas-]

Yeah that will work.

 

[Marshmalo]

o0 that worked thanks