[Trigger] Things that may leak help

[deathdoorway]

I have aton of lag or delay in game. So if someone could i have alot of triggers to post if someone could look through and see if someone leaks or I'm doing it wrong?

Unit die check

• Check prob
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
    • ((Triggering unit) is in ShamanicAuraGroup) Equal to False
  • Actions
    • -------- //////////Item Remove////////// --------
    • Set emo[1] = (Units in (Playable map area) owned by (Triggering player))
    • Unit Group - Pick every unit in emo[1] and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (DropZoneWalk <gen> contains (Picked unit)) Equal to True
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Triggering unit)) Equal to Player 1 (Red)
              • Then - Actions
                • Item - Pick every item in ItemDropZone player 1 <gen> and do (Actions)
                  • Loop - Actions
                    • Item - Remove (Picked item)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Triggering unit)) Equal to Player 2 (Blue)
              • Then - Actions
                • Item - Pick every item in ItemDropZone player 2 <gen> and do (Actions)
                  • Loop - Actions
                    • Item - Remove (Picked item)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Triggering unit)) Equal to Player 3 (Teal)
              • Then - Actions
                • Item - Pick every item in ItemDropZone player 3 <gen> and do (Actions)
                  • Loop - Actions
                    • Item - Remove (Picked item)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Triggering unit)) Equal to Player 4 (Purple)
              • Then - Actions
                • Item - Pick every item in ItemDropZone player 4 <gen> and do (Actions)
                  • Loop - Actions
                    • Item - Remove (Picked item)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Triggering unit)) Equal to Player 5 (Yellow)
              • Then - Actions
                • Item - Pick every item in ItemDropZone player 5 <gen> and do (Actions)
                  • Loop - Actions
                    • Item - Remove (Picked item)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Triggering unit)) Equal to Player 6 (Orange)
              • Then - Actions
                • Item - Pick every item in ItemDropZone player 6 <gen> and do (Actions)
                  • Loop - Actions
                    • Item - Remove (Picked item)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Triggering unit)) Equal to Player 7 (Green)
              • Then - Actions
                • Item - Pick every item in ItemDropZone player 7 <gen> and do (Actions)
                  • Loop - Actions
                    • Item - Remove (Picked item)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Triggering unit)) Equal to Player 8 (Pink)
              • Then - Actions
                • Item - Pick every item in ItemDropZone player 8 <gen> and do (Actions)
                  • Loop - Actions
                    • Item - Remove (Picked item)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Triggering unit)) Equal to Player 9 (Gray)
              • Then - Actions
                • Item - Pick every item in ItemDropZone player 9 <gen> and do (Actions)
                  • Loop - Actions
                    • Item - Remove (Picked item)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Triggering unit)) Equal to Player 10 (Light Blue)
              • Then - Actions
                • Item - Pick every item in ItemDropZone player 10 <gen> and do (Actions)
                  • Loop - Actions
                    • Item - Remove (Picked item)
              • Else - Actions
          • Else - Actions
    • Custom script: call DestroyGroup (udg_emo[1])
    • -------- //////////Destro////////// --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is in Lokf_heroGroup) Equal to True
      • Then - Actions
        • Wait 1.00 seconds
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Lokf_heroGroup is empty) Equal to True
          • Then - Actions
            • Set Activation[8] = False
            • Destructible - Pick every destructible in Lokf Instance <gen> and do (Destructible - Close (Picked destructible))
            • Set LeakGroup[48] = (Units in Lokf Instance <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[48] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Custom script: call DestroyGroup(udg_LeakGroup[48])
            • Skip remaining actions
          • Else - Actions
      • Else - Actions
    • -------- //////////ORC////////// --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is in OrcHeroGroup) Equal to True
      • Then - Actions
        • Wait 1.00 seconds
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (OrcHeroGroup is empty) Equal to True
          • Then - Actions
            • Set Activation[5] = False
            • Set Activation[4] = False
            • Trigger - Turn off OrcBoss Lava <gen>
            • Destructible - Pick every destructible in Orchen Dungeon <gen> and do (Destructible - Close (Picked destructible))
            • Set LeakGroup[49] = (Units in Orchen Dungeon <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[49] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Custom script: call DestroyGroup(udg_LeakGroup[49])
            • Skip remaining actions
          • Else - Actions
      • Else - Actions
    • -------- //////////NAGA////////// --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is in NagaHeroGroup) Equal to True
      • Then - Actions
        • Wait 1.00 seconds
        • Unit Group - Remove (Dying unit) from NagaHeroGroup
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (NagaHeroGroup is empty) Equal to True
          • Then - Actions
            • Set LeakGroup[50] = (Units in Naga Instance Weather <gen> owned by Player 12 (Brown))
            • Destructible - Pick every destructible in Naga Instance Weather <gen> and do (Destructible - Close (Picked destructible))
            • Unit Group - Pick every unit in LeakGroup[50] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Custom script: call DestroyGroup(udg_LeakGroup[50])
            • Set LeakGroup[51] = (Units in Naga Boss Region <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[51] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
                • Destructible - Pick every destructible in Naga Boss Region <gen> and do (Destructible - Close (Picked destructible))
            • Custom script: call DestroyGroup(udg_LeakGroup[51])
            • Destructible - Pick every destructible in Naga First Door <gen> and do (Destructible - Close (Picked destructible))
            • Destructible - Pick every destructible in Naga Second Door <gen> and do (Destructible - Close (Picked destructible))
            • Destructible - Pick every destructible in Naga Third Door <gen> and do (Destructible - Close (Picked destructible))
            • Set Activation[1] = False
            • Set Activation[2] = False
            • Set Activation[3] = False
            • Trigger - Turn on Naga Doors 1 leave <gen>
            • Trigger - Turn on Naga Doors 2 leave <gen>
            • Trigger - Turn on Naga Doors 3 leave <gen>
            • Trigger - Turn on Naga Bosses <gen>
            • Skip remaining actions
          • Else - Actions
      • Else - Actions
    • -------- //////////SATYR////////// --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is in Satyr_heroGroup) Equal to True
      • Then - Actions
        • Wait 1.00 seconds
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Satyr_heroGroup is empty) Equal to True
          • Then - Actions
            • Set Activation[10] = False
            • Set SentinelBool = False
            • Destructible - Pick every destructible in Satyr Instance <gen> and do (Destructible - Close (Picked destructible))
            • Set LeakGroup[52] = (Units in Satyr Instance <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[52] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Set LeakGroup[53] = (Units in Satyr Boss Region <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[53] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Custom script: call DestroyGroup(udg_LeakGroup[53])
            • Set LeakGroup[53] = (Units in Satyr Instance <gen> owned by Neutral Passive)
            • Unit Group - Pick every unit in LeakGroup[53] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Custom script: call DestroyGroup(udg_LeakGroup[53])
            • Custom script: call DestroyGroup(udg_LeakGroup[52])
            • Skip remaining actions
          • Else - Actions
      • Else - Actions
    • -------- //////////GRUKK////////// --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is in Grukk_Herogroup) Equal to True
      • Then - Actions
        • Wait 1.00 seconds
        • Unit Group - Remove (Dying unit) from Grukk_Herogroup
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Grukk_Herogroup is empty) Equal to True
          • Then - Actions
            • Set Activation[6] = False
            • Set Activation[7] = False
            • Set LeakGroup[54] = (Units in Grukk Control Area <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[54] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Destructible - Pick every destructible in Grukk Control Area <gen> and do (Destructible - Close (Picked destructible))
            • Custom script: call DestroyGroup(udg_LeakGroup[54])
            • Skip remaining actions
          • Else - Actions
      • Else - Actions
    • -------- //////////LICH/ZYKEN////////// --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is in LichHerogroup) Equal to True
      • Then - Actions
        • Wait 1.00 seconds
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (LichHerogroup is empty) Equal to True
          • Then - Actions
            • Visibility - Disable LichRoomvis
            • Set LeakGroup[55] = (Units in Remove Lich units 1 <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[55] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
                • Destructible - Pick every destructible in Remove Lich units 1 <gen> and do (Destructible - Close (Picked destructible))
            • Custom script: call DestroyGroup(udg_LeakGroup[55])
            • Set LeakGroup[56] = (Units in Remove Lich units 2 <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[56] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
                • Destructible - Pick every destructible in Remove Lich units 2 <gen> and do (Destructible - Close (Picked destructible))
            • Custom script: call DestroyGroup(udg_LeakGroup[56])
            • Set LeakGroup[57] = (Units in Remove Lich units 3 <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[57] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
                • Destructible - Pick every destructible in Remove Lich units 3 <gen> and do (Destructible - Close (Picked destructible))
            • Custom script: call DestroyGroup(udg_LeakGroup[57])
            • Set LeakGroup[58] = (Units in Remove Lich units 4 <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[58] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
                • Destructible - Pick every destructible in Remove Lich units 4 <gen> and do (Destructible - Close (Picked destructible))
            • Custom script: call DestroyGroup(udg_LeakGroup[58])
            • Set LeakGroup[59] = (Units in Remove Lich units 5 <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[59] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
                • Destructible - Pick every destructible in Remove Lich units 5 <gen> and do (Destructible - Close (Picked destructible))
            • Custom script: call DestroyGroup(udg_LeakGroup[59])
            • Skip remaining actions
          • Else - Actions
      • Else - Actions
    • -------- //////////Volcano////////// --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is in Volcano_HeroGroup) Equal to True
      • Then - Actions
        • Wait 1.00 seconds
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Volcano_HeroGroup is empty) Equal to True
          • Then - Actions
            • Set Activation[12] = False
            • Set Activation[11] = False
            • Set LeakGroup[60] = (Units in Red Volcano Smoke <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[60] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Custom script: call DestroyGroup(udg_LeakGroup[60])
            • Set LeakGroup[60] = (Units owned by Player 12 (Brown) of type Boomer)
            • Unit Group - Pick every unit in LeakGroup[60] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Custom script: call DestroyGroup(udg_LeakGroup[60])
            • Set LeakGroup[61] = (Units owned by Player 12 (Brown) of type Volcano Summoner)
            • Unit Group - Pick every unit in LeakGroup[61] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Custom script: call DestroyGroup(udg_LeakGroup[61])
            • Skip remaining actions
          • Else - Actions
      • Else - Actions
    • -------- //////////Kobold////////// --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) is in KoboldheroGroup) Equal to True
      • Then - Actions
        • Wait 1.00 seconds
        • Unit Group - Remove (Dying unit) from KoboldheroGroup
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (KoboldheroGroup is empty) Equal to True
          • Then - Actions
            • Set LeakGroup[60] = (Units in Kobold Weather <gen> owned by Player 12 (Brown))
            • Unit Group - Pick every unit in LeakGroup[100] and do (Actions)
              • Loop - Actions
                • Unit - Remove (Picked unit) from the game
            • Custom script: call DestroyGroup(udg_LeakGroup[100])
            • Skip remaining actions
          • Else - Actions
      • Else - Actions

Volcano Enterance

• Volcano Entrance
  • Events
    • Unit - A unit enters Volcano Dome Entrance <gen>
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
    • ((Entering unit) belongs to an ally of Player 11 (Dark Green)) Equal to True
  • Actions
    • Set LeakPoint[244] = ((Center of Inside Volcano Dome <gen>) offset by (-100.00, 0.00))
    • Unit - Move (Entering unit) instantly to LeakPoint[244], facing Default building facing degrees
    • Camera - Pan camera for (Owner of (Entering unit)) to LeakPoint[244] over 0.00 seconds
    • Custom script: call RemoveLocation(udg_LeakPoint[244])

Volcano Hero Group

• Volcano Hero Group
  • Events
    • Unit - A unit enters Catapult Landning <gen>
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
  • Actions
    • Game - Display to (Player group((Owner of (Triggering unit)))) the text: |cff7777aaSlay the ...
    • Unit Group - Add (Triggering unit) to Volcano_HeroGroup
    • Set LeakGroup[60] = (Units in Red Volcano Smoke <gen> owned by Player 12 (Brown))
    • Unit Group - Pick every unit in LeakGroup[60] and do (Actions)
      • Loop - Actions
        • Unit - Remove (Picked unit) from the game
    • Custom script: call DestroyGroup(udg_LeakGroup[60])
    • Set LeakGroup[61] = (Units owned by Player 12 (Brown) of type Volcano Summoner)
    • Unit Group - Pick every unit in LeakGroup[61] and do (Actions)
      • Loop - Actions
        • Unit - Remove (Picked unit) from the game
    • Custom script: call DestroyGroup(udg_LeakGroup[61])
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in Volcano_HeroGroup) Greater than or equal to 1
      • Then - Actions
        • Set LeakPoint[265] = (Center of FireSpawn 2 <gen>)
        • Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[265] facing LeakPoint[265]
        • Custom script: call RemoveLocation(udg_LeakPoint[265])
        • Wait 0.01 seconds
        • Set LeakPoint[225] = (Center of FireSpawn 1 <gen>)
        • Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[225] facing LeakPoint[225]
        • Custom script: call RemoveLocation(udg_LeakPoint[225])
        • Wait 0.01 seconds
        • Set LeakPoint[243] = (Center of LaveSpawn 1 <gen>)
        • Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[243] facing LeakPoint[243]
        • Custom script: call RemoveLocation(udg_LeakPoint[243])
        • Wait 0.01 seconds
        • Set LeakPoint[242] = (Center of LavaSpawn 2 <gen>)
        • Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[242] facing LeakPoint[242]
        • Custom script: call RemoveLocation(udg_LeakPoint[242])
        • Wait 0.01 seconds
        • Set LeakPoint[241] = (Center of FireSpawn 3 <gen>)
        • Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[241] facing LeakPoint[241]
        • Custom script: call RemoveLocation(udg_LeakPoint[241])
        • Wait 0.01 seconds
        • Set LeakPoint[240] = (Center of LavaSpawn 3 <gen>)
        • Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[240] facing LeakPoint[240]
        • Custom script: call RemoveLocation(udg_LeakPoint[240])
        • Wait 0.01 seconds
        • Set LeakPoint[239] = (Center of LavaSpawn 4 <gen>)
        • Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[239] facing LeakPoint[239]
        • Custom script: call RemoveLocation(udg_LeakPoint[239])
        • Wait 0.01 seconds
        • Set LeakPoint[238] = (Center of LavaSpawn 6 <gen>)
        • Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[238] facing LeakPoint[238]
        • Custom script: call RemoveLocation(udg_LeakPoint[238])
        • Wait 0.01 seconds
        • Set LeakPoint[237] = (Center of LavaSpawn 5 <gen>)
        • Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[237] facing LeakPoint[237]
        • Custom script: call RemoveLocation(udg_LeakPoint[237])
        • Wait 0.01 seconds
        • Set LeakPoint[236] = (Center of FireSpawn 4 <gen>)
        • Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[236] facing LeakPoint[236]
        • Custom script: call RemoveLocation(udg_LeakPoint[236])
        • Wait 0.01 seconds
        • Set LeakPoint[235] = (Center of FireSpawn 5 <gen>)
        • Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[235] facing LeakPoint[235]
        • Custom script: call RemoveLocation(udg_LeakPoint[235])
        • Wait 0.01 seconds
        • Set LeakPoint[234] = (Center of FireSpawn 6 <gen>)
        • Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[234] facing LeakPoint[234]
        • Custom script: call RemoveLocation(udg_LeakPoint[234])
        • Wait 0.01 seconds
        • Set LeakPoint[233] = (Center of FireSpawn 7 <gen>)
        • Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[233] facing LeakPoint[233]
        • Custom script: call RemoveLocation(udg_LeakPoint[233])
        • Wait 0.01 seconds
        • Set LeakPoint[232] = (Center of FireSpawn 8 <gen>)
        • Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[232] facing LeakPoint[232]
        • Custom script: call RemoveLocation(udg_LeakPoint[232])
        • Wait 0.01 seconds
        • Set LeakPoint[231] = (Center of FireSpawn 9 <gen>)
        • Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[231] facing LeakPoint[231]
        • Custom script: call RemoveLocation(udg_LeakPoint[231])
        • Wait 0.01 seconds
        • Set LeakPoint[230] = (Center of LavaSpawn 7 <gen>)
        • Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[230] facing LeakPoint[230]
        • Custom script: call RemoveLocation(udg_LeakPoint[230])
        • Wait 0.01 seconds
        • Set LeakPoint[229] = (Center of LavaSpawn 11 <gen>)
        • Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[229] facing LeakPoint[229]
        • Custom script: call RemoveLocation(udg_LeakPoint[229])
        • Wait 0.01 seconds
        • Set LeakPoint[228] = (Center of LavaSpawn 10 <gen>)
        • Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[228] facing LeakPoint[228]
        • Custom script: call RemoveLocation(udg_LeakPoint[228])
        • Wait 0.01 seconds
        • Set LeakPoint[227] = (Center of Volcano Summoner <gen>)
        • Unit - Create 1 Volcano Summoner for Player 12 (Brown) at LeakPoint[227] facing LeakPoint[227]
        • Custom script: call RemoveLocation(udg_LeakPoint[227])
      • Else - Actions

I have a ton more but if someone could help me with these first it be great

 

[millzy]

u dont need an array for each leak variable

 

[baassee]

My eyes really hurt right now...

Just some basics.

-Change all Owning of triggering unit to Triggering Player.

-First you check if the hero is in the group
((Triggering unit) is in Lokf_heroGroup) Equal to True
Then 1 second after you check if the group is empty
(Lokf_heroGroup is empty) Equal to True

Does this make any sense to you at all? Of course not it's not empty if it contains the hero previously.

This goes with all the thingies.

-You don't need arrayed variables for this one, just create at max 4 different of them.

You'll never use 53 unit groups at the same time anyway.

-Dying Unit -> TriggeringUnit

-Also Triggering Unit can be stored into a unit variable to get rid of the function calls.

-Leak

Set LeakPoint[244] = ((Center of Inside Volcano Dome <gen>) offset by (-100.00, 0.00))

The center point leaks as well.

-Leak force (playergroup)

Game - Display to (Player group((Owner of (Triggering unit)))) the text: |cff7777aaSlay the ...

-Actually, you will not need the group variables at all, just put this line

Customscript: set bj_wantDestroyGroup = true

above all unitgroup loopings.

-Instead of all the waits and setting variable and removing variable in this part, just set them all at ini and use them over and over again and wait 0.01 doesn't work either. If you want an 0.01 interval you need to use timers as waits cannot handle lower periods.

THIS PART

Set LeakPoint[265] = (Center of FireSpawn 2 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[265] facing LeakPoint[265]
Custom script: call RemoveLocation(udg_LeakPoint[265])
Wait 0.01 seconds
Set LeakPoint[225] = (Center of FireSpawn 1 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[225] facing LeakPoint[225]
Custom script: call RemoveLocation(udg_LeakPoint[225])
Wait 0.01 seconds
Set LeakPoint[243] = (Center of LaveSpawn 1 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[243] facing LeakPoint[243]
Custom script: call RemoveLocation(udg_LeakPoint[243])
Wait 0.01 seconds
Set LeakPoint[242] = (Center of LavaSpawn 2 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[242] facing LeakPoint[242]
Custom script: call RemoveLocation(udg_LeakPoint[242])
Wait 0.01 seconds
Set LeakPoint[241] = (Center of FireSpawn 3 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[241] facing LeakPoint[241]
Custom script: call RemoveLocation(udg_LeakPoint[241])
Wait 0.01 seconds
Set LeakPoint[240] = (Center of LavaSpawn 3 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[240] facing LeakPoint[240]
Custom script: call RemoveLocation(udg_LeakPoint[240])
Wait 0.01 seconds
Set LeakPoint[239] = (Center of LavaSpawn 4 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[239] facing LeakPoint[239]
Custom script: call RemoveLocation(udg_LeakPoint[239])
Wait 0.01 seconds
Set LeakPoint[238] = (Center of LavaSpawn 6 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[238] facing LeakPoint[238]
Custom script: call RemoveLocation(udg_LeakPoint[238])
Wait 0.01 seconds
Set LeakPoint[237] = (Center of LavaSpawn 5 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[237] facing LeakPoint[237]
Custom script: call RemoveLocation(udg_LeakPoint[237])
Wait 0.01 seconds
Set LeakPoint[236] = (Center of FireSpawn 4 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[236] facing LeakPoint[236]
Custom script: call RemoveLocation(udg_LeakPoint[236])
Wait 0.01 seconds
Set LeakPoint[235] = (Center of FireSpawn 5 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[235] facing LeakPoint[235]
Custom script: call RemoveLocation(udg_LeakPoint[235])
Wait 0.01 seconds
Set LeakPoint[234] = (Center of FireSpawn 6 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[234] facing LeakPoint[234]
Custom script: call RemoveLocation(udg_LeakPoint[234])
Wait 0.01 seconds
Set LeakPoint[233] = (Center of FireSpawn 7 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[233] facing LeakPoint[233]
Custom script: call RemoveLocation(udg_LeakPoint[233])
Wait 0.01 seconds
Set LeakPoint[232] = (Center of FireSpawn 8 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[232] facing LeakPoint[232]
Custom script: call RemoveLocation(udg_LeakPoint[232])
Wait 0.01 seconds
Set LeakPoint[231] = (Center of FireSpawn 9 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[231] facing LeakPoint[231]
Custom script: call RemoveLocation(udg_LeakPoint[231])
Wait 0.01 seconds
Set LeakPoint[230] = (Center of LavaSpawn 7 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[230] facing LeakPoint[230]
Custom script: call RemoveLocation(udg_LeakPoint[230])
Wait 0.01 seconds
Set LeakPoint[229] = (Center of LavaSpawn 11 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[229] facing LeakPoint[229]
Custom script: call RemoveLocation(udg_LeakPoint[229])
Wait 0.01 seconds
Set LeakPoint[228] = (Center of LavaSpawn 10 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[228] facing LeakPoint[228]
Custom script: call RemoveLocation(udg_LeakPoint[228])
Wait 0.01 seconds
Set LeakPoint[227] = (Center of Volcano Summoner <gen>)
Unit - Create 1 Volcano Summoner for Player 12 (Brown) at LeakPoint[227] facing LeakPoint[227]
Custom script: call RemoveLocation(udg_LeakPoint[227])

 

[deathdoorway]

baassee i need unitgroups for those due to each dungeon needs a unit group whichis why there is so many.

The reason there is so many leakpoints is because i use 1 variable for every leak in the game just give it a diff array

how do i not leak center of point??

where do i put this Customscript: set bj_wantDestroyGroup = true

and i need a wait which does work btw to avoid mass lag when spawning dungeons instead of just creating like 100 units at once uunless u got abetter way im all for it

 

[baassee]

Instead of dynamically setting a point and removing it you should set a variable and then reuse it over and over again as the centers of those regions will never be changed (yet it generates a new handle everytime center of region is used without a variable to refer to).

And if you dont wanna do this way, you should at least know that you only need one variable when you set a point and remove it instantly after.

So instead of doing this:

Set LeakPoint[225] = (Center of FireSpawn 1 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at LeakPoint[225] facing LeakPoint[225]
Custom script: call RemoveLocation(udg_LeakPoint[225])
Wait 0.01 seconds
Set LeakPoint[243] = (Center of LaveSpawn 1 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at LeakPoint[243] facing LeakPoint[243]
Custom script: call RemoveLocation(udg_LeakPoint[243])

It should be:

Set TempPoint = (Center of FireSpawn 1 <gen>)
Unit - Create 1 FireSpawn for Player 12 (Brown) at TempPoint facing TempPoint
Custom script: call RemoveLocation(udg_TempPoint)
Wait 0.01 seconds
Set TempPoint = (Center of LaveSpawn 1 <gen>)
Unit - Create 1 LavaSpawn for Player 12 (Brown) at TempPoint facing TempPoint
Custom script: call RemoveLocation(udg_TempPoint)

As arrays take unnecessary memory and shouldn't be used when you don't need to use it.

 

[deathdoorway]

But i cant use tempoint for 10 dungeons now can i. doesnt arrays save you the trouble of creating multiple variables and save memory and if you delete them it doesnt cause lag. I meant this is from what I took from everything.

 

[baassee]

If you see my example, when the variable is supposed to be removed after an instant action (like creating a unit) it will not interfere with itself as WC3 is single threaded. BUT IF THERE IS A WAIT BETWEEN THE SETTING AND THE REMOVING OF THE VARIABLE THEN IT WILL NOT BE POSSIBLE AND BE VERY STUPID.

 

[deathdoorway]

Ya im working on condensing the map. Care to help me if i send the map would ya look it and tell me howgood?

 

[baassee]

Ya im working on condensing the map. Care to help me if i send the map would ya look it and tell me howgood?

If there are more triggers like those you posted that behaves the same then you should probably fix those as I told you to fix those you posted in the main post. Working on my own map as we speak so don't have the time at the moment.

 

[deathdoorway]

well what about these two you said about

where do i put this Customscript: set bj_wantDestroyGroup = true

and i need a wait which does work btw to avoid mass lag when spawning dungeons instead of just creating like 100 units at once uunless u got abetter way im all for it

 

[baassee]

1. Above the

Pick all units in ...

Remember that you will not need to set the group variable if you use it like this.

2. Use some kind of spawn system that relies on a timer instead. Search the spell section.